[v4,0/1] ALSA: hda/realtek: Fix internal speakers for Legion Y9000X 2022 IAH7

Message

ArcticLampyrid May 6, 2024, 7:27 a.m. UTC

This fixes the sound not working from internal speakers on
Lenovo Legion Y9000X 2022 IAH7 models.

Closes: https://bugzilla.kernel.org/show_bug.cgi?id=218744

This patch depends on [PATCH v1 1/2] ALSA: hda: cs35l41: Ignore errors when configuring IRQs (by Stefan Binding)
See also <https://lore.kernel.org/lkml/[e-mail]/>

Change from v3 <https://lore.kernel.org/lkml/[e-mail]/T/>:
- Remove the patch for cs35l41 to obey the trigger type from DSDT, for it is rarely used, and
  the existing samples (Y9000X 2022 IAH7) has wrong trigger type in DSDT, which makes this change
  useless.
- Instead, ignore errors when configuring interrupts to allow laptops with bad ACPI to play audio.
  (via a patch from Stefan Binding)

Change from v2 <https://lore.kernel.org/lkml/[e-mail]/T/>:
- Correct spkid gpio index.

Change from v1 <https://lore.kernel.org/lkml/[e-mail]/T/>:
- Add a patch for cs35l41 to obey the trigger type from DSDT.
- Avoid disabling interupts for second amps.

ArcticLampyrid (1):
  ALSA: hda/realtek: Fix internal speakers for Legion Y9000X 2022 IAH7

 sound/pci/hda/cs35l41_hda_property.c | 2 ++
 sound/pci/hda/patch_realtek.c        | 1 +
 2 files changed, 3 insertions(+)

Comments

Jaroslav Kysela May 6, 2024, 7:31 a.m. UTC | #1

On 06. 05. 24 9:27, ArcticLampyrid wrote:
> This fixes the sound not working from internal speakers on
> Lenovo Legion Y9000X 2022 IAH7 models.
> 
> Closes: https://bugzilla.kernel.org/show_bug.cgi?id=218744
> 
> This patch depends on [PATCH v1 1/2] ALSA: hda: cs35l41: Ignore errors when configuring IRQs (by Stefan Binding)
> See also <https://lore.kernel.org/lkml/[e-mail]/>

We don't accept commits from anonymous sources. Please, follow 
Documentation/process/submitting-patches.rst .

					Jaroslav

ArcticLampyrid May 6, 2024, 7:32 a.m. UTC | #2

> On 06. 05. 24 9:27, ArcticLampyrid wrote:
> > This fixes the sound not working from internal speakers on
> > Lenovo Legion Y9000X 2022 IAH7 models.
> > 
> > Closes: https://bugzilla.kernel.org/show_bug.cgi?id=218744
> > 
> > This patch depends on [PATCH v1 1/2] ALSA: hda: cs35l41: Ignore errors
> > when configuring IRQs (by Stefan Binding) See also
> > <https://lore.kernel.org/lkml/20240429154853.9393-2-sbinding@opensource.c
> > irrus.com/>
> We don't accept commits from anonymous sources. Please, follow
> Documentation/process/submitting-patches.rst .
> 
> 					Jaroslav

I've signed it off in commit message.
> Signed-off-by: Junhao Pei <[e-mail]>

Takashi Iwai May 6, 2024, 7:51 a.m. UTC | #3

On Mon, 06 May 2024 09:32:56 +0200,
ArcticLampyrid wrote:
> 
> > On 06. 05. 24 9:27, ArcticLampyrid wrote:
> > > This fixes the sound not working from internal speakers on
> > > Lenovo Legion Y9000X 2022 IAH7 models.
> > > 
> > > Closes: https://bugzilla.kernel.org/show_bug.cgi?id=218744
> > > 
> > > This patch depends on [PATCH v1 1/2] ALSA: hda: cs35l41: Ignore errors
> > > when configuring IRQs (by Stefan Binding) See also
> > > <https://lore.kernel.org/lkml/20240429154853.9393-2-sbinding@opensource.c
> > > irrus.com/>
> > We don't accept commits from anonymous sources. Please, follow
> > Documentation/process/submitting-patches.rst .
> > 
> > 					Jaroslav
> 
> I've signed it off in commit message.
> > Signed-off-by: Junhao Pei <[e-mail]>

The From line doesn't match with your Signed-off-by line.
Please align it and resubmit.


thanks,

Takashi

ArcticLampyrid May 6, 2024, 8:13 a.m. UTC | #4

> The From line doesn't match with your Signed-off-by line.
> Please align it and resubmit.

Well, okey, it's okey...
Resend here: <https://lore.kernel.org/lkml/[e-mail]/T/>