| Message ID | 20240509064336.9803-1-lvzhaoxiong@huaqin.corp-partner.google.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v1,1/2] dt-bindings: input: i2c-hid: Introduce Ilitek ili2900 | expand |
hi all Sorry, there is a problem with this patch, please ignore this email. On Thu, May 9, 2024 at 2:43 PM Zhaoxiong Lv < lvzhaoxiong@huaqin.corp-partner.google.com> wrote: > From: lvzhaoxiong <lvzhaoxiong@huaqin.corp-partner.google.com> > > The ili2900 touch screen chip same as ilitek ili9882t controller > has a reset gpio. > > Signed-off-by: lvzhaoxiong <lvzhaoxiong@huaqin.corp-partner.google.com> > --- > Documentation/devicetree/bindings/input/ilitek,ili9882t.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/input/ilitek,ili9882t.yaml > b/Documentation/devicetree/bindings/input/ilitek,ili9882t.yaml > index c5d9e0e919f9..5063ea2c8375 100644 > --- a/Documentation/devicetree/bindings/input/ilitek,ili9882t.yaml > +++ b/Documentation/devicetree/bindings/input/ilitek,ili9882t.yaml > @@ -19,6 +19,7 @@ allOf: > properties: > compatible: > const: ilitek,ili9882t > + const: ilitek,ili2900 > > reg: > const: 0x41 > -- > 2.17.1 > >
On Thu, 09 May 2024 14:43:35 +0800, Zhaoxiong Lv wrote: > From: lvzhaoxiong <lvzhaoxiong@huaqin.corp-partner.google.com> > > The ili2900 touch screen chip same as ilitek ili9882t controller > has a reset gpio. > > Signed-off-by: lvzhaoxiong <lvzhaoxiong@huaqin.corp-partner.google.com> > --- > Documentation/devicetree/bindings/input/ilitek,ili9882t.yaml | 1 + > 1 file changed, 1 insertion(+) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: ./Documentation/devicetree/bindings/input/ilitek,ili9882t.yaml:22:5: [error] duplication of key "const" in mapping (key-duplicates) dtschema/dtc warnings/errors: make[2]: *** Deleting file 'Documentation/devicetree/bindings/input/ilitek,ili9882t.example.dts' Documentation/devicetree/bindings/input/ilitek,ili9882t.yaml:22:5: found duplicate key "const" with value "ilitek,ili2900" (original value: "ilitek,ili9882t") make[2]: *** [Documentation/devicetree/bindings/Makefile:26: Documentation/devicetree/bindings/input/ilitek,ili9882t.example.dts] Error 1 make[2]: *** Waiting for unfinished jobs.... ./Documentation/devicetree/bindings/input/ilitek,ili9882t.yaml:22:5: found duplicate key "const" with value "ilitek,ili2900" (original value: "ilitek,ili9882t") /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/input/ilitek,ili9882t.yaml: ignoring, error parsing file make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1430: dt_binding_check] Error 2 make: *** [Makefile:240: __sub-make] Error 2 doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240509064336.9803-1-lvzhaoxiong@huaqin.corp-partner.google.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On 09/05/2024 08:43, Zhaoxiong Lv wrote: > From: lvzhaoxiong <lvzhaoxiong@huaqin.corp-partner.google.com> > > The ili2900 touch screen chip same as ilitek ili9882t controller > has a reset gpio. > > Signed-off-by: lvzhaoxiong <lvzhaoxiong@huaqin.corp-partner.google.com> You just sent the same, ignoring entire feedback. That's a shortcut to get ignored on your contributions... :( Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/input/ilitek,ili9882t.yaml b/Documentation/devicetree/bindings/input/ilitek,ili9882t.yaml index c5d9e0e919f9..5063ea2c8375 100644 --- a/Documentation/devicetree/bindings/input/ilitek,ili9882t.yaml +++ b/Documentation/devicetree/bindings/input/ilitek,ili9882t.yaml @@ -19,6 +19,7 @@ allOf: properties: compatible: const: ilitek,ili9882t + const: ilitek,ili2900 reg: const: 0x41