| Message ID | cover.1715108589.git.dsterba@suse.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Move test cased from shared to generic | expand |
On Tue, May 07, 2024 at 09:07:28PM +0200, David Sterba wrote: > Hi, > > as discussed recently, the tests in shared should be in generic. > > Based on branch patches-in-queue, commit e098483c662d8f0b7583edca1501d8addd3b7549. I'm glad to get rid of shared/ finally. Modulo my question about the .out files, I agree with this change. Acked-by: Darrick J. Wong <djwong@kernel.org> --D > > David Sterba (4): > Move shared/298 to generic/740 > Move shared/002 to generic/745 > Move shared/298 to generic/746 > Remove rest of shared/ > > check | 2 +- > tests/{shared/032 => generic/740} | 2 +- > tests/{shared/032.out => generic/740.out} | 0 > tests/{shared/002 => generic/745} | 2 +- > tests/{shared/002.out => generic/745.out} | 0 > tests/{shared/298 => generic/746} | 2 +- > tests/{shared/298.out => generic/746.out} | 0 > tests/shared/Makefile | 24 ----------------------- > 8 files changed, 4 insertions(+), 28 deletions(-) > rename tests/{shared/032 => generic/740} (99%) > rename tests/{shared/032.out => generic/740.out} (100%) > rename tests/{shared/002 => generic/745} (99%) > rename tests/{shared/002.out => generic/745.out} (100%) > rename tests/{shared/298 => generic/746} (99%) > rename tests/{shared/298.out => generic/746.out} (100%) > delete mode 100644 tests/shared/Makefile > > -- > 2.44.0 > >
On Tue, May 07, 2024 at 09:07:28PM +0200, David Sterba wrote: > Hi, > > as discussed recently, the tests in shared should be in generic. > > Based on branch patches-in-queue, commit e098483c662d8f0b7583edca1501d8addd3b7549. > > David Sterba (4): > Move shared/298 to generic/740 > Move shared/002 to generic/745 > Move shared/298 to generic/746 Thanks David! There're two shared/298 above, I think the former is shared/032 :) And I foundd that all .out files were not changed properly, so I suppose you did that manually. The "mvtest" tool will help you, e.g. # ./tools/mvtest shared/032 generic/740 # ./tools/mvtest shared/002 generic/745 # ./tools/mvtest shared/298 generic/746 Thanks, Zorro > Remove rest of shared/ > > check | 2 +- > tests/{shared/032 => generic/740} | 2 +- > tests/{shared/032.out => generic/740.out} | 0 > tests/{shared/002 => generic/745} | 2 +- > tests/{shared/002.out => generic/745.out} | 0 > tests/{shared/298 => generic/746} | 2 +- > tests/{shared/298.out => generic/746.out} | 0 > tests/shared/Makefile | 24 ----------------------- > 8 files changed, 4 insertions(+), 28 deletions(-) > rename tests/{shared/032 => generic/740} (99%) > rename tests/{shared/032.out => generic/740.out} (100%) > rename tests/{shared/002 => generic/745} (99%) > rename tests/{shared/002.out => generic/745.out} (100%) > rename tests/{shared/298 => generic/746} (99%) > rename tests/{shared/298.out => generic/746.out} (100%) > delete mode 100644 tests/shared/Makefile > > -- > 2.44.0 > >
On Thu, May 09, 2024 at 01:29:01PM +0800, Zorro Lang wrote: > On Tue, May 07, 2024 at 09:07:28PM +0200, David Sterba wrote: > > Hi, > > > > as discussed recently, the tests in shared should be in generic. > > > > Based on branch patches-in-queue, commit e098483c662d8f0b7583edca1501d8addd3b7549. > > > > David Sterba (4): > > Move shared/298 to generic/740 > > Move shared/002 to generic/745 > > Move shared/298 to generic/746 > > Thanks David! There're two shared/298 above, I think the former is shared/032 :) I noticed the wrong subject of patch before sending and updated the patch manually but not the summary in the cover letter. > And I foundd that all .out files were not changed properly, so I suppose you > did that manually. The "mvtest" tool will help you, e.g. > > # ./tools/mvtest shared/032 generic/740 > # ./tools/mvtest shared/002 generic/745 > # ./tools/mvtest shared/298 generic/746 I didn't know such tool exist so yeah I forgot to update the .out too. Do you want a resend or can you fix that when committing?
On Thu, May 09, 2024 at 06:28:55PM +0200, David Sterba wrote: > On Thu, May 09, 2024 at 01:29:01PM +0800, Zorro Lang wrote: > > On Tue, May 07, 2024 at 09:07:28PM +0200, David Sterba wrote: > > > Hi, > > > > > > as discussed recently, the tests in shared should be in generic. > > > > > > Based on branch patches-in-queue, commit e098483c662d8f0b7583edca1501d8addd3b7549. > > > > > > David Sterba (4): > > > Move shared/298 to generic/740 > > > Move shared/002 to generic/745 > > > Move shared/298 to generic/746 > > > > Thanks David! There're two shared/298 above, I think the former is shared/032 :) > > I noticed the wrong subject of patch before sending and updated the > patch manually but not the summary in the cover letter. > > > And I foundd that all .out files were not changed properly, so I suppose you > > did that manually. The "mvtest" tool will help you, e.g. > > > > # ./tools/mvtest shared/032 generic/740 > > # ./tools/mvtest shared/002 generic/745 > > # ./tools/mvtest shared/298 generic/746 > > I didn't know such tool exist so yeah I forgot to update the .out too. > Do you want a resend or can you fix that when committing? Sure, as this patch has gotten RVB from Darrick, and if you and Christoph all tend to improve the _require_xxx helpers later, I can merge this patchset at first (rewrite with mvtest script :) Thanks, Zorro >
Hi, as discussed recently, the tests in shared should be in generic. Based on branch patches-in-queue, commit e098483c662d8f0b7583edca1501d8addd3b7549. David Sterba (4): Move shared/298 to generic/740 Move shared/002 to generic/745 Move shared/298 to generic/746 Remove rest of shared/ check | 2 +- tests/{shared/032 => generic/740} | 2 +- tests/{shared/032.out => generic/740.out} | 0 tests/{shared/002 => generic/745} | 2 +- tests/{shared/002.out => generic/745.out} | 0 tests/{shared/298 => generic/746} | 2 +- tests/{shared/298.out => generic/746.out} | 0 tests/shared/Makefile | 24 ----------------------- 8 files changed, 4 insertions(+), 28 deletions(-) rename tests/{shared/032 => generic/740} (99%) rename tests/{shared/032.out => generic/740.out} (100%) rename tests/{shared/002 => generic/745} (99%) rename tests/{shared/002.out => generic/745.out} (100%) rename tests/{shared/298 => generic/746} (99%) rename tests/{shared/298.out => generic/746.out} (100%) delete mode 100644 tests/shared/Makefile