diff mbox series

modules: Drop the .export_symbol section from the final modules

Message ID 20240417053530.30995-1-wangyao@lemote.com (mailing list archive)
State New, archived
Headers show
Series modules: Drop the .export_symbol section from the final modules | expand

Commit Message

wangyao@lemote.com April 17, 2024, 5:35 a.m. UTC 
From: Wang Yao <wangyao@lemote.com>

Commit ddb5cdbafaaa ("kbuild: generate KSYMTAB entries by modpost")
forget drop the .export_symbol section from the final modules.

Signed-off-by: Wang Yao <wangyao@lemote.com>
---
 scripts/module.lds.S | 1 +
 1 file changed, 1 insertion(+)

Comments

Ainux Wang April 22, 2024, 2:02 a.m. UTC | #1 
Hi, everyone:
Could someone review this patch?
Best regards,
Ainux Wang.

<wangyao@lemote.com> 于2024年4月17日周三 13:35写道：
>
> From: Wang Yao <wangyao@lemote.com>
>
> Commit ddb5cdbafaaa ("kbuild: generate KSYMTAB entries by modpost")
> forget drop the .export_symbol section from the final modules.
>
> Signed-off-by: Wang Yao <wangyao@lemote.com>
> ---
>  scripts/module.lds.S | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/scripts/module.lds.S b/scripts/module.lds.S
> index bf5bcf2836d8..89ff01a22634 100644
> --- a/scripts/module.lds.S
> +++ b/scripts/module.lds.S
> @@ -13,6 +13,7 @@ SECTIONS {
>         /DISCARD/ : {
>                 *(.discard)
>                 *(.discard.*)
> +               *(.export_symbol)
>         }
>
>         __ksymtab               0 : { *(SORT(___ksymtab+*)) }
> --
> 2.27.0
>
Ainux Wang May 7, 2024, 5:15 a.m. UTC | #2 
Hi, everyone:

Could someone review this patch?

Best regards,
Ainux Wang.

<wangyao@lemote.com> 于2024年4月17日周三 13:35写道：

>
> From: Wang Yao <wangyao@lemote.com>
>
> Commit ddb5cdbafaaa ("kbuild: generate KSYMTAB entries by modpost")
> forget drop the .export_symbol section from the final modules.
>
> Signed-off-by: Wang Yao <wangyao@lemote.com>
> ---
>  scripts/module.lds.S | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/scripts/module.lds.S b/scripts/module.lds.S
> index bf5bcf2836d8..89ff01a22634 100644
> --- a/scripts/module.lds.S
> +++ b/scripts/module.lds.S
> @@ -13,6 +13,7 @@ SECTIONS {
>         /DISCARD/ : {
>                 *(.discard)
>                 *(.discard.*)
> +               *(.export_symbol)
>         }
>
>         __ksymtab               0 : { *(SORT(___ksymtab+*)) }
> --
> 2.27.0
>
Ainux Wang May 11, 2024, 1:03 a.m. UTC | #3 
Hi, everyone:

Could someone help to review this patch?

Best regards,
 Ainux Wang.


Ainux Wang <ainux.wang@gmail.com> 于2024年5月7日周二 13:15写道：
>
> Hi, everyone:
>
> Could someone review this patch?
>
> Best regards,
> Ainux Wang.
>
> <wangyao@lemote.com> 于2024年4月17日周三 13:35写道：
>
> >
> > From: Wang Yao <wangyao@lemote.com>
> >
> > Commit ddb5cdbafaaa ("kbuild: generate KSYMTAB entries by modpost")
> > forget drop the .export_symbol section from the final modules.
> >
> > Signed-off-by: Wang Yao <wangyao@lemote.com>
> > ---
> >  scripts/module.lds.S | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/scripts/module.lds.S b/scripts/module.lds.S
> > index bf5bcf2836d8..89ff01a22634 100644
> > --- a/scripts/module.lds.S
> > +++ b/scripts/module.lds.S
> > @@ -13,6 +13,7 @@ SECTIONS {
> >         /DISCARD/ : {
> >                 *(.discard)
> >                 *(.discard.*)
> > +               *(.export_symbol)
> >         }
> >
> >         __ksymtab               0 : { *(SORT(___ksymtab+*)) }
> > --
> > 2.27.0
> >
Luis Chamberlain May 11, 2024, 10:41 p.m. UTC | #4 
On Wed, Apr 17, 2024 at 01:35:30PM +0800, wangyao@lemote.com wrote:
> From: Wang Yao <wangyao@lemote.com>
> 
> Commit ddb5cdbafaaa ("kbuild: generate KSYMTAB entries by modpost")
> forget drop the .export_symbol section from the final modules.
> 
> Signed-off-by: Wang Yao <wangyao@lemote.com>

Masahiro, commit ddb5cdbafaaa ("kbuild: generate KSYMTAB entries by
modpost") was your change, wanna address / take it through your
tree? It makes sense to me though.

  Luis

> ---
>  scripts/module.lds.S | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/scripts/module.lds.S b/scripts/module.lds.S
> index bf5bcf2836d8..89ff01a22634 100644
> --- a/scripts/module.lds.S
> +++ b/scripts/module.lds.S
> @@ -13,6 +13,7 @@ SECTIONS {
>  	/DISCARD/ : {
>  		*(.discard)
>  		*(.discard.*)
> +		*(.export_symbol)
>  	}
>  
>  	__ksymtab		0 : { *(SORT(___ksymtab+*)) }
> -- 
> 2.27.0
>
Masahiro Yamada May 13, 2024, 11:10 p.m. UTC | #5 
On Sun, May 12, 2024 at 7:42 AM Luis Chamberlain <mcgrof@kernel.org> wrote:
>
> On Wed, Apr 17, 2024 at 01:35:30PM +0800, wangyao@lemote.com wrote:
> > From: Wang Yao <wangyao@lemote.com>
> >
> > Commit ddb5cdbafaaa ("kbuild: generate KSYMTAB entries by modpost")
> > forget drop the .export_symbol section from the final modules.
> >
> > Signed-off-by: Wang Yao <wangyao@lemote.com>
>
> Masahiro, commit ddb5cdbafaaa ("kbuild: generate KSYMTAB entries by
> modpost") was your change, wanna address / take it through your
> tree? It makes sense to me though.


Yes, applied now.

Thanks for the reminder.





>
>   Luis
>
> > ---
> >  scripts/module.lds.S | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/scripts/module.lds.S b/scripts/module.lds.S
> > index bf5bcf2836d8..89ff01a22634 100644
> > --- a/scripts/module.lds.S
> > +++ b/scripts/module.lds.S
> > @@ -13,6 +13,7 @@ SECTIONS {
> >       /DISCARD/ : {
> >               *(.discard)
> >               *(.discard.*)
> > +             *(.export_symbol)
> >       }
> >
> >       __ksymtab               0 : { *(SORT(___ksymtab+*)) }
> > --
> > 2.27.0
> >
diff mbox series

Patch

diff --git a/scripts/module.lds.S b/scripts/module.lds.S
index bf5bcf2836d8..89ff01a22634 100644
--- a/scripts/module.lds.S
+++ b/scripts/module.lds.S
@@ -13,6 +13,7 @@  SECTIONS {
 	/DISCARD/ : {
 		*(.discard)
 		*(.discard.*)
+		*(.export_symbol)
 	}
 
 	__ksymtab		0 : { *(SORT(___ksymtab+*)) }