| Message ID | 20240501042847.1545145-6-mr.nuke.me@gmail.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | ipq9574: Enable PCI-Express support | expand |
On 01/05/2024 06:28, Alexandru Gagniuc wrote: > IPQ9574 has four PCIe controllers: two single-lane Gen3, and two > dual-lane Gen3. The controllers are identical from a software > perspective, with the differences appearing in the PHYs. > > Add a compatible for the PCIe on IPQ9574. This is a friendly reminder during the review process. It looks like you received a tag and forgot to add it. If you do not know the process, here is a short explanation: Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions, under or above your Signed-off-by tag. Tag is "received", when provided in a message replied to you on the mailing list. Tools like b4 can help here. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for tags received on the version they apply. https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577 If a tag was not added on purpose, please state why and what changed. Best regards, Krzysztof
On 5/1/24 5:21 AM, Krzysztof Kozlowski wrote: > On 01/05/2024 06:28, Alexandru Gagniuc wrote: >> IPQ9574 has four PCIe controllers: two single-lane Gen3, and two >> dual-lane Gen3. The controllers are identical from a software >> perspective, with the differences appearing in the PHYs. >> >> Add a compatible for the PCIe on IPQ9574. > > This is a friendly reminder during the review process. > > It looks like you received a tag and forgot to add it. > > If you do not know the process, here is a short explanation: > Please add Acked-by/Reviewed-by/Tested-by tags when posting new > versions, under or above your Signed-off-by tag. Tag is "received", when > provided in a message replied to you on the mailing list. Tools like b4 > can help here. However, there's no need to repost patches *only* to add > the tags. The upstream maintainer will do that for tags received on the > version they apply. > > https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577 > > If a tag was not added on purpose, please state why and what changed. I had an Acked-by tag from Rob for what is now patch 6/8 -- previously 5/7. Due to last-minute info from QUIC Inc, Dmitry and I decided to move the "snoc" and "anoc" clocks out of the PHY and to the PCIe controller. This change resulted in a 6/8 patch that is substantially different from what Rob acked. I felt it was inappropriate to keep the tag. Alex
On 01/05/2024 17:43, mr.nuke.me@gmail.com wrote: > On 5/1/24 5:21 AM, Krzysztof Kozlowski wrote: >> On 01/05/2024 06:28, Alexandru Gagniuc wrote: >>> IPQ9574 has four PCIe controllers: two single-lane Gen3, and two >>> dual-lane Gen3. The controllers are identical from a software >>> perspective, with the differences appearing in the PHYs. >>> >>> Add a compatible for the PCIe on IPQ9574. >> >> This is a friendly reminder during the review process. >> >> It looks like you received a tag and forgot to add it. >> >> If you do not know the process, here is a short explanation: >> Please add Acked-by/Reviewed-by/Tested-by tags when posting new >> versions, under or above your Signed-off-by tag. Tag is "received", when >> provided in a message replied to you on the mailing list. Tools like b4 >> can help here. However, there's no need to repost patches *only* to add >> the tags. The upstream maintainer will do that for tags received on the >> version they apply. >> >> https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577 >> >> If a tag was not added on purpose, please state why and what changed. > > I had an Acked-by tag from Rob for what is now patch 6/8 -- previously > 5/7. Due to last-minute info from QUIC Inc, Dmitry and I decided to move > the "snoc" and "anoc" clocks out of the PHY and to the PCIe controller. > > This change resulted in a 6/8 patch that is substantially different from > what Rob acked. I felt it was inappropriate to keep the tag. So please read my message again: "If a tag was not added on purpose, please state why and what changed." Your changelog for that patch should say that. Best regards, Krzysztof
On Tue, Apr 30, 2024 at 11:28:44PM -0500, Alexandru Gagniuc wrote: > IPQ9574 has four PCIe controllers: two single-lane Gen3, and two > dual-lane Gen3. The controllers are identical from a software You mean to say, 'identical to IPQ8074 Gen3 platform' since you are reusing the 2_9_0 cfg? > perspective, with the differences appearing in the PHYs. > > Add a compatible for the PCIe on IPQ9574. > > Signed-off-by: Alexandru Gagniuc <mr.nuke.me@gmail.com> But the change looks good to me. Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> - Mani > --- > drivers/pci/controller/dwc/pcie-qcom.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c > index ea81ff68d433..e61888e6c63d 100644 > --- a/drivers/pci/controller/dwc/pcie-qcom.c > +++ b/drivers/pci/controller/dwc/pcie-qcom.c > @@ -1551,6 +1551,7 @@ static const struct of_device_id qcom_pcie_match[] = { > { .compatible = "qcom,pcie-ipq8064-v2", .data = &cfg_2_1_0 }, > { .compatible = "qcom,pcie-ipq8074", .data = &cfg_2_3_3 }, > { .compatible = "qcom,pcie-ipq8074-gen3", .data = &cfg_2_9_0 }, > + { .compatible = "qcom,pcie-ipq9574", .data = &cfg_2_9_0 }, > { .compatible = "qcom,pcie-msm8996", .data = &cfg_2_3_2 }, > { .compatible = "qcom,pcie-qcs404", .data = &cfg_2_4_0 }, > { .compatible = "qcom,pcie-sa8540p", .data = &cfg_sc8280xp }, > -- > 2.40.1 >
diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c index ea81ff68d433..e61888e6c63d 100644 --- a/drivers/pci/controller/dwc/pcie-qcom.c +++ b/drivers/pci/controller/dwc/pcie-qcom.c @@ -1551,6 +1551,7 @@ static const struct of_device_id qcom_pcie_match[] = { { .compatible = "qcom,pcie-ipq8064-v2", .data = &cfg_2_1_0 }, { .compatible = "qcom,pcie-ipq8074", .data = &cfg_2_3_3 }, { .compatible = "qcom,pcie-ipq8074-gen3", .data = &cfg_2_9_0 }, + { .compatible = "qcom,pcie-ipq9574", .data = &cfg_2_9_0 }, { .compatible = "qcom,pcie-msm8996", .data = &cfg_2_3_2 }, { .compatible = "qcom,pcie-qcs404", .data = &cfg_2_4_0 }, { .compatible = "qcom,pcie-sa8540p", .data = &cfg_sc8280xp },
IPQ9574 has four PCIe controllers: two single-lane Gen3, and two dual-lane Gen3. The controllers are identical from a software perspective, with the differences appearing in the PHYs. Add a compatible for the PCIe on IPQ9574. Signed-off-by: Alexandru Gagniuc <mr.nuke.me@gmail.com> --- drivers/pci/controller/dwc/pcie-qcom.c | 1 + 1 file changed, 1 insertion(+)