mbox series

[0/9] drm/i915: Plane fb refactoring

Message ID 20240506125718.26001-1-ville.syrjala@linux.intel.com (mailing list archive)
Headers show
Series drm/i915: Plane fb refactoring | expand

Message

Ville Syrjala May 6, 2024, 12:57 p.m. UTC
From: Ville Syrjälä <ville.syrjala@linux.intel.com>

A bit of cleanup/refactoring around plane fb stuff.
This is mainly prep work for a slightly bigger rework
of alignment handling.

Ville Syrjälä (9):
  drm/i915: Split gen2 vs. gen3 .max_stride()
  drm/i915: Clean up skl+ plane stride limits
  drm/i915: Drop 'uses_fence' parameter from intel_pin_fb_obj_dpt()
  drm/i915: Extract intel_plane_needs_physical()
  drm/i915: Polish types in fb calculations
  drm/i915: Constify 'fb' in during pinning
  drm/i915: Change intel_fbdev_fb_alloc() reuturn type
  drm/i915: Cleanup fbdev fb setup
  drm/i915: Rename the fb pinning functions to indicate the address
    space

 drivers/gpu/drm/i915/display/i9xx_plane.c     | 34 ++++---
 .../gpu/drm/i915/display/intel_atomic_plane.c |  8 ++
 .../gpu/drm/i915/display/intel_atomic_plane.h |  1 +
 drivers/gpu/drm/i915/display/intel_dpt.c      |  6 +-
 drivers/gpu/drm/i915/display/intel_dpt.h      |  6 +-
 drivers/gpu/drm/i915/display/intel_fb.c       | 27 +++---
 drivers/gpu/drm/i915/display/intel_fb_pin.c   | 73 +++++++-------
 drivers/gpu/drm/i915/display/intel_fb_pin.h   | 12 +--
 drivers/gpu/drm/i915/display/intel_fbdev.c    | 39 ++++----
 drivers/gpu/drm/i915/display/intel_fbdev_fb.c |  6 +-
 drivers/gpu/drm/i915/display/intel_fbdev_fb.h |  5 +-
 .../drm/i915/display/skl_universal_plane.c    | 94 ++++++++++---------
 drivers/gpu/drm/xe/display/xe_fb_pin.c        | 18 ++--
 drivers/gpu/drm/xe/display/xe_plane_initial.c |  4 +-
 14 files changed, 175 insertions(+), 158 deletions(-)

Comments

Ville Syrjala May 10, 2024, 4:55 p.m. UTC | #1
On Mon, May 06, 2024 at 03:57:09PM +0300, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> A bit of cleanup/refactoring around plane fb stuff.
> This is mainly prep work for a slightly bigger rework
> of alignment handling.
> 
> Ville Syrjälä (9):
>   drm/i915: Split gen2 vs. gen3 .max_stride()
>   drm/i915: Clean up skl+ plane stride limits
>   drm/i915: Drop 'uses_fence' parameter from intel_pin_fb_obj_dpt()
>   drm/i915: Extract intel_plane_needs_physical()
>   drm/i915: Polish types in fb calculations

Pushed up to here. Thanks for the review.

>   drm/i915: Constify 'fb' in during pinning
>   drm/i915: Change intel_fbdev_fb_alloc() reuturn type
>   drm/i915: Cleanup fbdev fb setup
>   drm/i915: Rename the fb pinning functions to indicate the address
>     space

Some of the rest touch xe as well.

Lucas, can you toss me an ack to merge via drm-intel-next?

> 
>  drivers/gpu/drm/i915/display/i9xx_plane.c     | 34 ++++---
>  .../gpu/drm/i915/display/intel_atomic_plane.c |  8 ++
>  .../gpu/drm/i915/display/intel_atomic_plane.h |  1 +
>  drivers/gpu/drm/i915/display/intel_dpt.c      |  6 +-
>  drivers/gpu/drm/i915/display/intel_dpt.h      |  6 +-
>  drivers/gpu/drm/i915/display/intel_fb.c       | 27 +++---
>  drivers/gpu/drm/i915/display/intel_fb_pin.c   | 73 +++++++-------
>  drivers/gpu/drm/i915/display/intel_fb_pin.h   | 12 +--
>  drivers/gpu/drm/i915/display/intel_fbdev.c    | 39 ++++----
>  drivers/gpu/drm/i915/display/intel_fbdev_fb.c |  6 +-
>  drivers/gpu/drm/i915/display/intel_fbdev_fb.h |  5 +-
>  .../drm/i915/display/skl_universal_plane.c    | 94 ++++++++++---------
>  drivers/gpu/drm/xe/display/xe_fb_pin.c        | 18 ++--
>  drivers/gpu/drm/xe/display/xe_plane_initial.c |  4 +-
>  14 files changed, 175 insertions(+), 158 deletions(-)
> 
> -- 
> 2.43.2
Lucas De Marchi May 11, 2024, 7 p.m. UTC | #2
On Fri, May 10, 2024 at 07:55:15PM GMT, Ville Syrjälä wrote:
>On Mon, May 06, 2024 at 03:57:09PM +0300, Ville Syrjala wrote:
>> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>>
>> A bit of cleanup/refactoring around plane fb stuff.
>> This is mainly prep work for a slightly bigger rework
>> of alignment handling.
>>
>> Ville Syrjälä (9):
>>   drm/i915: Split gen2 vs. gen3 .max_stride()
>>   drm/i915: Clean up skl+ plane stride limits
>>   drm/i915: Drop 'uses_fence' parameter from intel_pin_fb_obj_dpt()
>>   drm/i915: Extract intel_plane_needs_physical()
>>   drm/i915: Polish types in fb calculations
>
>Pushed up to here. Thanks for the review.
>
>>   drm/i915: Constify 'fb' in during pinning
>>   drm/i915: Change intel_fbdev_fb_alloc() reuturn type
>>   drm/i915: Cleanup fbdev fb setup
>>   drm/i915: Rename the fb pinning functions to indicate the address
>>     space
>
>Some of the rest touch xe as well.
>
>Lucas, can you toss me an ack to merge via drm-intel-next?



Acked-by: Lucas De Marchi <lucas.demarchi@intel.com>

thanks
Lucas De Marchi