mbox series

[0/4] drm/panthor: More reset fixes

Message ID 20240502183813.1612017-1-boris.brezillon@collabora.com (mailing list archive)
Headers show
Series drm/panthor: More reset fixes | expand

Message

Boris Brezillon May 2, 2024, 6:38 p.m. UTC 
Hello,

This is a collection of fixes for bugs found while chasing an
unrecoverable fault leading to a device unplug (because of some
other bugs that was introduced in my local dev branch).

The first patch makes sure we immediately reset the GPU on an
unrecoverable fault, and following patches are fixing various
NULL/invalid pointer derefs caused by use-after-free situations
following a device unplug.

Regards,

Boris

Boris Brezillon (4):
  drm/panthor: Force an immediate reset on unrecoverable faults
  drm/panthor: Keep a ref to the VM at the panthor_kernel_bo level
  drm/panthor: Reset the FW VM to NULL on unplug
  drm/panthor: Call panthor_sched_post_reset() even if the reset failed

 drivers/gpu/drm/panthor/panthor_device.c |  8 ++---
 drivers/gpu/drm/panthor/panthor_device.h |  1 +
 drivers/gpu/drm/panthor/panthor_fw.c     |  5 +--
 drivers/gpu/drm/panthor/panthor_gem.c    |  8 +++--
 drivers/gpu/drm/panthor/panthor_gem.h    |  8 +++--
 drivers/gpu/drm/panthor/panthor_heap.c   |  8 ++---
 drivers/gpu/drm/panthor/panthor_sched.c  | 40 +++++++++++++++++-------
 drivers/gpu/drm/panthor/panthor_sched.h  |  2 +-
 8 files changed, 51 insertions(+), 29 deletions(-)

Comments

Boris Brezillon May 13, 2024, 11:40 a.m. UTC | #1 
On Thu,  2 May 2024 20:38:08 +0200
Boris Brezillon <boris.brezillon@collabora.com> wrote:

> Hello,
> 
> This is a collection of fixes for bugs found while chasing an
> unrecoverable fault leading to a device unplug (because of some
> other bugs that was introduced in my local dev branch).
> 
> The first patch makes sure we immediately reset the GPU on an
> unrecoverable fault, and following patches are fixing various
> NULL/invalid pointer derefs caused by use-after-free situations
> following a device unplug.
> 
> Regards,
> 
> Boris
> 
> Boris Brezillon (4):
>   drm/panthor: Force an immediate reset on unrecoverable faults
>   drm/panthor: Keep a ref to the VM at the panthor_kernel_bo level
>   drm/panthor: Reset the FW VM to NULL on unplug
>   drm/panthor: Call panthor_sched_post_reset() even if the reset failed

Queued to drm-misc-next-fixes.

> 
>  drivers/gpu/drm/panthor/panthor_device.c |  8 ++---
>  drivers/gpu/drm/panthor/panthor_device.h |  1 +
>  drivers/gpu/drm/panthor/panthor_fw.c     |  5 +--
>  drivers/gpu/drm/panthor/panthor_gem.c    |  8 +++--
>  drivers/gpu/drm/panthor/panthor_gem.h    |  8 +++--
>  drivers/gpu/drm/panthor/panthor_heap.c   |  8 ++---
>  drivers/gpu/drm/panthor/panthor_sched.c  | 40 +++++++++++++++++-------
>  drivers/gpu/drm/panthor/panthor_sched.h  |  2 +-
>  8 files changed, 51 insertions(+), 29 deletions(-)
>