| Message ID | 20240513115345.2452799-1-vladimir.oltean@nxp.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | afd29f36aaf733985df1ba162424581b8b8853b4 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] net: pcs: lynx: no need to read LPA in lynx_pcs_get_state_2500basex() | expand |
On Mon, May 13, 2024 at 02:53:45PM +0300, Vladimir Oltean wrote: > Nothing useful is done with the LPA variable in lynx_pcs_get_state_2500basex(), > we can just remove the read. > > Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Mon, 13 May 2024 14:53:45 +0300 you wrote: > Nothing useful is done with the LPA variable in lynx_pcs_get_state_2500basex(), > we can just remove the read. > > Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com> > --- > drivers/net/pcs/pcs-lynx.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) Here is the summary with links: - [net-next] net: pcs: lynx: no need to read LPA in lynx_pcs_get_state_2500basex() https://git.kernel.org/netdev/net-next/c/afd29f36aaf7 You are awesome, thank you!
diff --git a/drivers/net/pcs/pcs-lynx.c b/drivers/net/pcs/pcs-lynx.c index 853b8c138718..b79aedad855b 100644 --- a/drivers/net/pcs/pcs-lynx.c +++ b/drivers/net/pcs/pcs-lynx.c @@ -61,11 +61,10 @@ static void lynx_pcs_get_state_usxgmii(struct mdio_device *pcs, static void lynx_pcs_get_state_2500basex(struct mdio_device *pcs, struct phylink_link_state *state) { - int bmsr, lpa; + int bmsr; bmsr = mdiodev_read(pcs, MII_BMSR); - lpa = mdiodev_read(pcs, MII_LPA); - if (bmsr < 0 || lpa < 0) { + if (bmsr < 0) { state->link = false; return; }
Nothing useful is done with the LPA variable in lynx_pcs_get_state_2500basex(), we can just remove the read. Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com> --- drivers/net/pcs/pcs-lynx.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)