| Message ID | cover.1715340032.git.jani.nikula@intel.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | drm/i915/pciids: PCI ID macro cleanups | expand |
On Fri, 10 May 2024, Jani Nikula <jani.nikula@intel.com> wrote: > This is a spin-off from [1], including just the PCI ID macro cleanups, > as well as adding a bunch more cleanups. > > BR, > Jani. > > [1] https://lore.kernel.org/all/cover.1715086509.git.jani.nikula@intel.com/ > > > Jani Nikula (8): > drm/i915/pciids: add INTEL_PNV_IDS(), use acronym > drm/i915/pciids: add INTEL_ILK_IDS(), use acronym > drm/i915/pciids: add INTEL_SNB_IDS() > drm/i915/pciids: add INTEL_IVB_IDS() > drm/i915/pciids: don't include WHL/CML PCI IDs in CFL > drm/i915/pciids: remove 11 from INTEL_ICL_IDS() > drm/i915/pciids: remove 12 from INTEL_TGL_IDS() > drm/i915/pciids: don't include RPL-U PCI IDs in RPL-P > > arch/x86/kernel/early-quirks.c | 19 +++--- Bjorn, ack for merging this via drm-intel-next? BR, Jani. > .../drm/i915/display/intel_display_device.c | 20 +++--- > drivers/gpu/drm/i915/i915_pci.c | 13 ++-- > drivers/gpu/drm/i915/intel_device_info.c | 3 +- > include/drm/i915_pciids.h | 67 ++++++++++++------- > 5 files changed, 71 insertions(+), 51 deletions(-)
On Fri, 10 May 2024, Jani Nikula <jani.nikula@intel.com> wrote: > On Fri, 10 May 2024, Jani Nikula <jani.nikula@intel.com> wrote: >> This is a spin-off from [1], including just the PCI ID macro cleanups, >> as well as adding a bunch more cleanups. >> >> BR, >> Jani. >> >> [1] https://lore.kernel.org/all/cover.1715086509.git.jani.nikula@intel.com/ >> >> >> Jani Nikula (8): >> drm/i915/pciids: add INTEL_PNV_IDS(), use acronym >> drm/i915/pciids: add INTEL_ILK_IDS(), use acronym >> drm/i915/pciids: add INTEL_SNB_IDS() >> drm/i915/pciids: add INTEL_IVB_IDS() >> drm/i915/pciids: don't include WHL/CML PCI IDs in CFL >> drm/i915/pciids: remove 11 from INTEL_ICL_IDS() >> drm/i915/pciids: remove 12 from INTEL_TGL_IDS() >> drm/i915/pciids: don't include RPL-U PCI IDs in RPL-P >> >> arch/x86/kernel/early-quirks.c | 19 +++--- > > Bjorn, ack for merging this via drm-intel-next? No reply from Bjorn, Cc: the x86 maintainers and list, could I get an ack from you please? I'd like to get these PCI ID macro changes moving forward, I've got more work pending on this. Lore link to the whole series [1]. Thanks, Jani. [1] https://lore.kernel.org/r/cover.1715340032.git.jani.nikula@intel.com > >> .../drm/i915/display/intel_display_device.c | 20 +++--- >> drivers/gpu/drm/i915/i915_pci.c | 13 ++-- >> drivers/gpu/drm/i915/intel_device_info.c | 3 +- >> include/drm/i915_pciids.h | 67 ++++++++++++------- >> 5 files changed, 71 insertions(+), 51 deletions(-)
On Fri, May 10, 2024 at 04:55:07PM +0300, Jani Nikula wrote: > On Fri, 10 May 2024, Jani Nikula <jani.nikula@intel.com> wrote: > > This is a spin-off from [1], including just the PCI ID macro cleanups, > > as well as adding a bunch more cleanups. > > > > BR, > > Jani. > > > > [1] https://lore.kernel.org/all/cover.1715086509.git.jani.nikula@intel.com/ > > > > > > Jani Nikula (8): > > drm/i915/pciids: add INTEL_PNV_IDS(), use acronym > > drm/i915/pciids: add INTEL_ILK_IDS(), use acronym > > drm/i915/pciids: add INTEL_SNB_IDS() > > drm/i915/pciids: add INTEL_IVB_IDS() > > drm/i915/pciids: don't include WHL/CML PCI IDs in CFL > > drm/i915/pciids: remove 11 from INTEL_ICL_IDS() > > drm/i915/pciids: remove 12 from INTEL_TGL_IDS() > > drm/i915/pciids: don't include RPL-U PCI IDs in RPL-P > > > > arch/x86/kernel/early-quirks.c | 19 +++--- > > Bjorn, ack for merging this via drm-intel-next? Sorry, I had ignored this because I didn't think it affected any PCI stuff. This is fine with me: Acked-by: Bjorn Helgaas <bhelgaas@google.com> But since you asked :), I'll gripe again about the fact that this intel_early_ids[] list needs continual maintenance, which is not the way things are supposed to work. Long thread about it here: https://lore.kernel.org/linux-pci/20201104120506.172447-1-tejaskumarx.surendrakumar.upadhyay@intel.com/t/#u > > .../drm/i915/display/intel_display_device.c | 20 +++--- > > drivers/gpu/drm/i915/i915_pci.c | 13 ++-- > > drivers/gpu/drm/i915/intel_device_info.c | 3 +- > > include/drm/i915_pciids.h | 67 ++++++++++++------- > > 5 files changed, 71 insertions(+), 51 deletions(-) > > -- > Jani Nikula, Intel
On Wed, 15 May 2024, Bjorn Helgaas <helgaas@kernel.org> wrote: > Sorry, I had ignored this because I didn't think it affected any PCI > stuff. This is fine with me: > > Acked-by: Bjorn Helgaas <bhelgaas@google.com> Thanks, pushed to drm-intel-next. > But since you asked :), I'll gripe again about the fact that this > intel_early_ids[] list needs continual maintenance, which is not the > way things are supposed to work. Long thread about it here: > > https://lore.kernel.org/linux-pci/20201104120506.172447-1-tejaskumarx.surendrakumar.upadhyay@intel.com/t/#u Right. I was under the impression we'd cease doing this for new platforms, and see if we can get away with it. For example, we don't have Meteorlake or Lunarlake there. Fingers crossed. But we probably don't want to touch the old stuff. Except now that I'm doing some non-functional refactoring to be able to better reuse the macros for something else. There's a bit more coming, please bear with me. :) I just tend to err on the side of getting the acks than pushing away. BR, Jani.
On 5/15/24 07:25, Jani Nikula wrote: > No reply from Bjorn, Cc: the x86 maintainers and list, could I get an > ack from you please? x86 is just a consumer of the drm/i915_pciids.h macros. The name change is perfectly fine with me. No objections. But I really don't think you need our acks to move forward. Either way: Acked-by: Dave Hansen <dave.hansen@linux.intel.com> # for x86
On Wed, 15 May 2024, Dave Hansen <dave.hansen@intel.com> wrote: > On 5/15/24 07:25, Jani Nikula wrote: >> No reply from Bjorn, Cc: the x86 maintainers and list, could I get an >> ack from you please? > > x86 is just a consumer of the drm/i915_pciids.h macros. The name change > is perfectly fine with me. No objections. But I really don't think you > need our acks to move forward. > > Either way: > > Acked-by: Dave Hansen <dave.hansen@linux.intel.com> # for x86 Thanks, I know the changes are benign, but it's just that I tend to err on the side of getting the acks rather than stepping on anyone's toes. :) BR, Jani.