| Message ID | 20240516133211.251205-1-linux@treblig.org (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | dmaengine: qcom: gpi: remove unused struct 'gpi_desc' | expand |
On Thu, May 16, 2024 at 02:32:11PM +0100, linux@treblig.org wrote: > From: "Dr. David Alan Gilbert" <linux@treblig.org> > > 'gpi_desc' seems like it was never used. > Remove it. code change show 'reg_info', not 'gpi_desc'. You need make sure that it really is not used, not "seems like". 'struct reg_info' is never used, so remove it. > > Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org> > --- > drivers/dma/qcom/gpi.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/drivers/dma/qcom/gpi.c b/drivers/dma/qcom/gpi.c > index 1c93864e0e4d..639ab304db9b 100644 > --- a/drivers/dma/qcom/gpi.c > +++ b/drivers/dma/qcom/gpi.c > @@ -476,12 +476,6 @@ struct gpi_dev { > struct gpii *gpiis; > }; > > -struct reg_info { > - char *name; > - u32 offset; > - u32 val; > -}; > - > struct gchan { > struct virt_dma_chan vc; > u32 chid; > -- > 2.45.0 >
* Frank Li (Frank.li@nxp.com) wrote: > On Thu, May 16, 2024 at 02:32:11PM +0100, linux@treblig.org wrote: > > From: "Dr. David Alan Gilbert" <linux@treblig.org> > > > > 'gpi_desc' seems like it was never used. > > Remove it. > > code change show 'reg_info', not 'gpi_desc'. You need make sure that it > really is not used, not "seems like". Oops that was a cut-and-paste when I did the commit on the name. It was build tested. V2 coming along now. Dave > 'struct reg_info' is never used, so remove it. > > > > > Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org> > > --- > > drivers/dma/qcom/gpi.c | 6 ------ > > 1 file changed, 6 deletions(-) > > > > diff --git a/drivers/dma/qcom/gpi.c b/drivers/dma/qcom/gpi.c > > index 1c93864e0e4d..639ab304db9b 100644 > > --- a/drivers/dma/qcom/gpi.c > > +++ b/drivers/dma/qcom/gpi.c > > @@ -476,12 +476,6 @@ struct gpi_dev { > > struct gpii *gpiis; > > }; > > > > -struct reg_info { > > - char *name; > > - u32 offset; > > - u32 val; > > -}; > > - > > struct gchan { > > struct virt_dma_chan vc; > > u32 chid; > > -- > > 2.45.0 > >
diff --git a/drivers/dma/qcom/gpi.c b/drivers/dma/qcom/gpi.c index 1c93864e0e4d..639ab304db9b 100644 --- a/drivers/dma/qcom/gpi.c +++ b/drivers/dma/qcom/gpi.c @@ -476,12 +476,6 @@ struct gpi_dev { struct gpii *gpiis; }; -struct reg_info { - char *name; - u32 offset; - u32 val; -}; - struct gchan { struct virt_dma_chan vc; u32 chid;