| Message ID | 20240423213240.91412-4-adrian.larumbe@collabora.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Support fdinfo runtime and memory stats on Panthor | expand |
Hello, On Tue, Apr 23, 2024 at 10:32:36PM +0100, Adrián Larumbe wrote: > When vm-binding an already-created BO, the entirety of its virtual size is > then backed by system memory, so its RSS is always the same as its virtual > size. How is that relevant to this patch? Or to put it differently: how are your words describing your code change here? > > Also, we consider a PRIME imported BO to be resident if its matching > dma_buf has an open attachment, which means its backing storage had already > been allocated. Reviewed-by: Liviu Dudau <liviu.dudau@arm.com> Best regards, Liviu > > Signed-off-by: Adrián Larumbe <adrian.larumbe@collabora.com> > --- > drivers/gpu/drm/panthor/panthor_gem.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/drivers/gpu/drm/panthor/panthor_gem.c b/drivers/gpu/drm/panthor/panthor_gem.c > index d6483266d0c2..386c0dfeeb5f 100644 > --- a/drivers/gpu/drm/panthor/panthor_gem.c > +++ b/drivers/gpu/drm/panthor/panthor_gem.c > @@ -143,6 +143,17 @@ panthor_gem_prime_export(struct drm_gem_object *obj, int flags) > return drm_gem_prime_export(obj, flags); > } > > +static enum drm_gem_object_status panthor_gem_status(struct drm_gem_object *obj) > +{ > + struct panthor_gem_object *bo = to_panthor_bo(obj); > + enum drm_gem_object_status res = 0; > + > + if (bo->base.base.import_attach || bo->base.pages) > + res |= DRM_GEM_OBJECT_RESIDENT; > + > + return res; > +} > + > static const struct drm_gem_object_funcs panthor_gem_funcs = { > .free = panthor_gem_free_object, > .print_info = drm_gem_shmem_object_print_info, > @@ -152,6 +163,7 @@ static const struct drm_gem_object_funcs panthor_gem_funcs = { > .vmap = drm_gem_shmem_object_vmap, > .vunmap = drm_gem_shmem_object_vunmap, > .mmap = panthor_gem_mmap, > + .status = panthor_gem_status, > .export = panthor_gem_prime_export, > .vm_ops = &drm_gem_shmem_vm_ops, > }; > -- > 2.44.0 >
On 24.04.2024 18:34, Liviu Dudau wrote: > Hello, > > On Tue, Apr 23, 2024 at 10:32:36PM +0100, Adrián Larumbe wrote: > > When vm-binding an already-created BO, the entirety of its virtual size is > > then backed by system memory, so its RSS is always the same as its virtual > > size. > > How is that relevant to this patch? Or to put it differently: how are your > words describing your code change here? I think I wrote this as a throw-back to the time when we handled RSS calculations for Panfrost objects, because heap BO's would be mapped on demand at every page fault. I understand that without mention of this the remark seems out of context, so depending on your taste I can either expand the message to underline this, or perhaps drop it altogether. I think I'd rather go for the latter, since the fact that panthor_gem_funcs includes no binding for drm_gem_object_funcs::rss() should be enough of a hint at this. > > > > Also, we consider a PRIME imported BO to be resident if its matching > > dma_buf has an open attachment, which means its backing storage had already > > been allocated. > > Reviewed-by: Liviu Dudau <liviu.dudau@arm.com> > > Best regards, > Liviu > > > > > Signed-off-by: Adrián Larumbe <adrian.larumbe@collabora.com> > > --- > > drivers/gpu/drm/panthor/panthor_gem.c | 12 ++++++++++++ > > 1 file changed, 12 insertions(+) > > > > diff --git a/drivers/gpu/drm/panthor/panthor_gem.c b/drivers/gpu/drm/panthor/panthor_gem.c > > index d6483266d0c2..386c0dfeeb5f 100644 > > --- a/drivers/gpu/drm/panthor/panthor_gem.c > > +++ b/drivers/gpu/drm/panthor/panthor_gem.c > > @@ -143,6 +143,17 @@ panthor_gem_prime_export(struct drm_gem_object *obj, int flags) > > return drm_gem_prime_export(obj, flags); > > } > > > > +static enum drm_gem_object_status panthor_gem_status(struct drm_gem_object *obj) > > +{ > > + struct panthor_gem_object *bo = to_panthor_bo(obj); > > + enum drm_gem_object_status res = 0; > > + > > + if (bo->base.base.import_attach || bo->base.pages) > > + res |= DRM_GEM_OBJECT_RESIDENT; > > + > > + return res; > > +} > > + > > static const struct drm_gem_object_funcs panthor_gem_funcs = { > > .free = panthor_gem_free_object, > > .print_info = drm_gem_shmem_object_print_info, > > @@ -152,6 +163,7 @@ static const struct drm_gem_object_funcs panthor_gem_funcs = { > > .vmap = drm_gem_shmem_object_vmap, > > .vunmap = drm_gem_shmem_object_vunmap, > > .mmap = panthor_gem_mmap, > > + .status = panthor_gem_status, > > .export = panthor_gem_prime_export, > > .vm_ops = &drm_gem_shmem_vm_ops, > > }; > > -- > > 2.44.0 > > Adrian Larumbe
diff --git a/drivers/gpu/drm/panthor/panthor_gem.c b/drivers/gpu/drm/panthor/panthor_gem.c index d6483266d0c2..386c0dfeeb5f 100644 --- a/drivers/gpu/drm/panthor/panthor_gem.c +++ b/drivers/gpu/drm/panthor/panthor_gem.c @@ -143,6 +143,17 @@ panthor_gem_prime_export(struct drm_gem_object *obj, int flags) return drm_gem_prime_export(obj, flags); } +static enum drm_gem_object_status panthor_gem_status(struct drm_gem_object *obj) +{ + struct panthor_gem_object *bo = to_panthor_bo(obj); + enum drm_gem_object_status res = 0; + + if (bo->base.base.import_attach || bo->base.pages) + res |= DRM_GEM_OBJECT_RESIDENT; + + return res; +} + static const struct drm_gem_object_funcs panthor_gem_funcs = { .free = panthor_gem_free_object, .print_info = drm_gem_shmem_object_print_info, @@ -152,6 +163,7 @@ static const struct drm_gem_object_funcs panthor_gem_funcs = { .vmap = drm_gem_shmem_object_vmap, .vunmap = drm_gem_shmem_object_vunmap, .mmap = panthor_gem_mmap, + .status = panthor_gem_status, .export = panthor_gem_prime_export, .vm_ops = &drm_gem_shmem_vm_ops, };
When vm-binding an already-created BO, the entirety of its virtual size is then backed by system memory, so its RSS is always the same as its virtual size. Also, we consider a PRIME imported BO to be resident if its matching dma_buf has an open attachment, which means its backing storage had already been allocated. Signed-off-by: Adrián Larumbe <adrian.larumbe@collabora.com> --- drivers/gpu/drm/panthor/panthor_gem.c | 12 ++++++++++++ 1 file changed, 12 insertions(+)