diff mbox series

[1/2] PCI: dra7xx: Fix cpu_addr_fixup parameter name

Message ID 20240430071054.248008-3-cassel@kernel.org (mailing list archive)
State New, archived
Headers show
Series [1/2] PCI: dra7xx: Fix cpu_addr_fixup parameter name | expand

Commit Message

Niklas Cassel April 30, 2024, 7:10 a.m. UTC
The function pointer declaration for the cpu_addr_fixup() callback uses
"cpu_addr" as parameter name.

Likewise, the argument that is supplied to the function pointer when the
function is actually called is "cpu_addr".

Rename the cpu_addr_fixup parameter name to match reality.

Signed-off-by: Niklas Cassel <cassel@kernel.org>
---
 drivers/pci/controller/dwc/pci-dra7xx.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Krzysztof WilczyƄski May 17, 2024, 5:11 p.m. UTC | #1
Hello,

> The function pointer declaration for the cpu_addr_fixup() callback uses
> "cpu_addr" as parameter name.
> 
> Likewise, the argument that is supplied to the function pointer when the
> function is actually called is "cpu_addr".
> 
> Rename the cpu_addr_fixup parameter name to match reality.

Applied to controller/dwc, thank you!

[01/02] PCI: dra7xx: Fix dra7xx_pcie_cpu_addr_fixup() parameter name
        https://git.kernel.org/pci/pci/c/6f4c62fd8a32
[02/02] PCI: artpec6: Fix artpec6_pcie_cpu_addr_fixup() parameter name
        https://git.kernel.org/pci/pci/c/49993453e079

	Krzysztof
diff mbox series

Patch

diff --git a/drivers/pci/controller/dwc/pci-dra7xx.c b/drivers/pci/controller/dwc/pci-dra7xx.c
index d2d17d37d3e0..2b818346bb37 100644
--- a/drivers/pci/controller/dwc/pci-dra7xx.c
+++ b/drivers/pci/controller/dwc/pci-dra7xx.c
@@ -113,9 +113,9 @@  static inline void dra7xx_pcie_writel(struct dra7xx_pcie *pcie, u32 offset,
 	writel(value, pcie->base + offset);
 }
 
-static u64 dra7xx_pcie_cpu_addr_fixup(struct dw_pcie *pci, u64 pci_addr)
+static u64 dra7xx_pcie_cpu_addr_fixup(struct dw_pcie *pci, u64 cpu_addr)
 {
-	return pci_addr & DRA7XX_CPU_TO_BUS_ADDR;
+	return cpu_addr & DRA7XX_CPU_TO_BUS_ADDR;
 }
 
 static int dra7xx_pcie_link_up(struct dw_pcie *pci)