| Message ID | 20240518-dt-bindings-ti-soc-mfd-v1-2-b3952f104c9a@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | ti: fix dtbs_check for some syscon bindings and DTS node | expand |
On 18/05/2024 23:07, Krzysztof Kozlowski wrote: > Add dedicated binding for the AM654 MCU SCM system controller registers, > already used in the DTS to properly describe its children. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > .../soc/ti/ti,am654-system-controller.yaml | 60 ++++++++++++++++++++++ > 1 file changed, 60 insertions(+) > > diff --git a/Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml b/Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml > new file mode 100644 > index 000000000000..e79803e586ca > --- /dev/null > +++ b/Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml > @@ -0,0 +1,60 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/soc/ti/ti,am654-system-controller.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: TI AM654 System Controller Registers R/W > + > +maintainers: > + - Kishon Vijay Abraham I <kishon@ti.com> Please update the email address to Kishon Vijay Abraham I <kishon@kernel.org> > + - Roger Quadros <rogerq@kernel.org> > + > +properties: > + compatible: > + items: > + - enum: > + - ti,am654-system-controller > + - const: syscon > + - const: simple-mfd > + > + reg: > + maxItems: 1 > + > + "#address-cells": > + const: 1 > + > + "#size-cells": > + const: 1 > + > + ranges: true > + > +patternProperties: > + "^phy@[0-9a-f]+$": > + type: object > + $ref: /schemas/phy/ti,phy-gmii-sel.yaml# > + > +required: > + - compatible > + - reg > + - "#address-cells" > + - "#size-cells" > + - ranges > + > +additionalProperties: false > + > +examples: > + - | > + syscon@40f00000 { > + compatible = "ti,am654-system-controller", "syscon", "simple-mfd"; > + reg = <0x40f00000 0x20000>; > + ranges = <0x0 0x40f00000 0x20000>; > + #address-cells = <1>; > + #size-cells = <1>; > + > + phy@4040 { > + compatible = "ti,am654-phy-gmii-sel"; > + reg = <0x4040 0x4>; > + #phy-cells = <1>; > + }; > + }; >
On Sat, May 18, 2024 at 10:07:17PM +0200, Krzysztof Kozlowski wrote: > Add dedicated binding for the AM654 MCU SCM system controller registers, > already used in the DTS to properly describe its children. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > .../soc/ti/ti,am654-system-controller.yaml | 60 ++++++++++++++++++++++ > 1 file changed, 60 insertions(+) > > diff --git a/Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml b/Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml > new file mode 100644 > index 000000000000..e79803e586ca > --- /dev/null > +++ b/Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml > @@ -0,0 +1,60 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/soc/ti/ti,am654-system-controller.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: TI AM654 System Controller Registers R/W "R/W"? Is that a copy-paste mistake from the register map for this SoC? Otherwise, Reviewed-by: Conor Dooley <conor.dooley@microchip.com> Cheers, Conor.
On 20/05/2024 19:14, Conor Dooley wrote: > On Sat, May 18, 2024 at 10:07:17PM +0200, Krzysztof Kozlowski wrote: >> Add dedicated binding for the AM654 MCU SCM system controller registers, >> already used in the DTS to properly describe its children. >> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> --- >> .../soc/ti/ti,am654-system-controller.yaml | 60 ++++++++++++++++++++++ >> 1 file changed, 60 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml b/Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml >> new file mode 100644 >> index 000000000000..e79803e586ca >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml >> @@ -0,0 +1,60 @@ >> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/soc/ti/ti,am654-system-controller.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: TI AM654 System Controller Registers R/W > > "R/W"? Is that a copy-paste mistake from the register map for this SoC? Other TI syscon bindings had it. I'll drop it. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml b/Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml new file mode 100644 index 000000000000..e79803e586ca --- /dev/null +++ b/Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml @@ -0,0 +1,60 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/soc/ti/ti,am654-system-controller.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: TI AM654 System Controller Registers R/W + +maintainers: + - Kishon Vijay Abraham I <kishon@ti.com> + - Roger Quadros <rogerq@kernel.org> + +properties: + compatible: + items: + - enum: + - ti,am654-system-controller + - const: syscon + - const: simple-mfd + + reg: + maxItems: 1 + + "#address-cells": + const: 1 + + "#size-cells": + const: 1 + + ranges: true + +patternProperties: + "^phy@[0-9a-f]+$": + type: object + $ref: /schemas/phy/ti,phy-gmii-sel.yaml# + +required: + - compatible + - reg + - "#address-cells" + - "#size-cells" + - ranges + +additionalProperties: false + +examples: + - | + syscon@40f00000 { + compatible = "ti,am654-system-controller", "syscon", "simple-mfd"; + reg = <0x40f00000 0x20000>; + ranges = <0x0 0x40f00000 0x20000>; + #address-cells = <1>; + #size-cells = <1>; + + phy@4040 { + compatible = "ti,am654-phy-gmii-sel"; + reg = <0x4040 0x4>; + #phy-cells = <1>; + }; + };
Add dedicated binding for the AM654 MCU SCM system controller registers, already used in the DTS to properly describe its children. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- .../soc/ti/ti,am654-system-controller.yaml | 60 ++++++++++++++++++++++ 1 file changed, 60 insertions(+)