diff mbox series

[2/6] generic/352: require no compression

Message ID d3e67b7d53f21d3e290384760ffbfda02c43cc8c.1715896529.git.dsterba@suse.com (mailing list archive)
State New, archived
Headers show
Series Btrfs test updates and fixups | expand

Commit Message

David Sterba May 16, 2024, 10:12 p.m. UTC 
From: Josef Bacik <josef@toxicpanda.com>

Our CI has been failing on this test for compression since 0fc226e7
("fstests: generic/352 should accomodate other pwrite behaviors").  This
is because we changed the size of the initial write down to 4k, and we
write a repeatable pattern.  With compression on btrfs this results in
an inline extent, and when you reflink an inline extent this just turns
it into full on copies instead of a reflink.

As this isn't a bug with compression, it's just not well aligned with
how compression interacts with the allocation of space, simply exclude
this test from running when you have compression enabled.

Signed-off-by: Josef Bacik <josef@toxicpanda.com>
Signed-off-by: David Sterba <dsterba@suse.com>
---
 tests/generic/352 | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Anand Jain May 21, 2024, 12:04 a.m. UTC | #1 
On 5/17/24 06:12, David Sterba wrote:
> From: Josef Bacik <josef@toxicpanda.com>
> 
> Our CI has been failing on this test for compression since 0fc226e7
> ("fstests: generic/352 should accomodate other pwrite behaviors").  This
> is because we changed the size of the initial write down to 4k, and we
> write a repeatable pattern.  With compression on btrfs this results in
> an inline extent, and when you reflink an inline extent this just turns
> it into full on copies instead of a reflink.
> 
> As this isn't a bug with compression, it's just not well aligned with
> how compression interacts with the allocation of space, simply exclude
> this test from running when you have compression enabled.
> 
> Signed-off-by: Josef Bacik <josef@toxicpanda.com>
> Signed-off-by: David Sterba <dsterba@suse.com>
> ---




>   tests/generic/352 | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/tests/generic/352 b/tests/generic/352
> index acc17dac38d061..3a18f07601de96 100755
> --- a/tests/generic/352
> +++ b/tests/generic/352
> @@ -25,6 +25,10 @@ _supported_fs generic
>   _require_scratch_reflink
>   _require_xfs_io_command "fiemap"
>   
> +# The size is too small, this will result in an inline extent and then reflink
> +# will simply be a copy on btrfs, so exclude compression.
> + _require_no_compress
> +


Reviewed-by: Anand Jain <anand.jain@oracle.com>

Thanks, Anand
>   _scratch_mkfs > /dev/null 2>&1
>   _scratch_mount
>
diff mbox series

Patch

diff --git a/tests/generic/352 b/tests/generic/352
index acc17dac38d061..3a18f07601de96 100755
--- a/tests/generic/352
+++ b/tests/generic/352
@@ -25,6 +25,10 @@  _supported_fs generic
 _require_scratch_reflink
 _require_xfs_io_command "fiemap"
 
+# The size is too small, this will result in an inline extent and then reflink
+# will simply be a copy on btrfs, so exclude compression.
+ _require_no_compress
+
 _scratch_mkfs > /dev/null 2>&1
 _scratch_mount