diff mbox series

[3/6] generic/027: require no compression

Message ID 9d61a72884ab0c7233ebfcc172407b465e372735.1715896529.git.dsterba@suse.com (mailing list archive)
State New, archived
Headers show
Series Btrfs test updates and fixups | expand

Commit Message

David Sterba May 16, 2024, 10:12 p.m. UTC
From: Josef Bacik <josef@toxicpanda.com>

This test creates a small file and then a giant file and then tries to
create a bunch of small files in a loop to exercise ENOPSC.  The problem
is that with compression the giant file isn't actually giant, so it can
make this test take forever.  Simply disable it for compression.

Signed-off-by: Josef Bacik <josef@toxicpanda.com>
Signed-off-by: David Sterba <dsterba@suse.com>
---
 tests/generic/027 | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Anand Jain May 21, 2024, 12:09 a.m. UTC | #1
On 5/17/24 06:12, David Sterba wrote:
> From: Josef Bacik <josef@toxicpanda.com>
> 
> This test creates a small file and then a giant file and then tries to
> create a bunch of small files in a loop to exercise ENOPSC.  The problem
> is that with compression the giant file isn't actually giant, so it can
> make this test take forever.  Simply disable it for compression.
> 
> Signed-off-by: Josef Bacik <josef@toxicpanda.com>
> Signed-off-by: David Sterba <dsterba@suse.com>
> ---
>   tests/generic/027 | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/tests/generic/027 b/tests/generic/027
> index 47f1981d4e51b7..eace1b358cdf34 100755
> --- a/tests/generic/027
> +++ b/tests/generic/027
> @@ -33,6 +33,10 @@ _supported_fs generic
>   
>   _require_scratch
>   
> +# This takes forever with compression because we don't actually fill up the
> +# disk, simply disable it if we have compression enabled.
> +_require_no_compress
> +
>   echo "Silence is golden"
>   
>   _scratch_mkfs_sized $((256 * 1024 * 1024)) >>$seqres.full 2>&1

Reviewed-by: Anand Jain <anand.jain@oracle.com>

Thanks, Anand
diff mbox series

Patch

diff --git a/tests/generic/027 b/tests/generic/027
index 47f1981d4e51b7..eace1b358cdf34 100755
--- a/tests/generic/027
+++ b/tests/generic/027
@@ -33,6 +33,10 @@  _supported_fs generic
 
 _require_scratch
 
+# This takes forever with compression because we don't actually fill up the
+# disk, simply disable it if we have compression enabled.
+_require_no_compress
+
 echo "Silence is golden"
 
 _scratch_mkfs_sized $((256 * 1024 * 1024)) >>$seqres.full 2>&1