mbox series

[net-next,0/7] virtnet_net: prepare for af-xdp

Message ID 20240508080514.99458-1-xuanzhuo@linux.alibaba.com (mailing list archive)
Headers show
Series virtnet_net: prepare for af-xdp | expand

Message

Xuan Zhuo May 8, 2024, 8:05 a.m. UTC
This patch set prepares for supporting af-xdp zerocopy.
There is no feature change in this patch set.
I just want to reduce the patch num of the final patch set,
so I split the patch set.

#1-#3 add independent directory for virtio-net
#4-#7 do some refactor, the sub-functions will be used by the subsequent commits

Thanks.

Xuan Zhuo (7):
  virtio_net: independent directory
  virtio_net: move core structures to virtio_net.h
  virtio_net: add prefix virtnet to all struct inside virtio_net.h
  virtio_net: separate virtnet_rx_resize()
  virtio_net: separate virtnet_tx_resize()
  virtio_net: separate receive_mergeable
  virtio_net: separate receive_buf

 MAINTAINERS                                   |   2 +-
 drivers/net/Kconfig                           |   9 +-
 drivers/net/Makefile                          |   2 +-
 drivers/net/virtio/Kconfig                    |  12 +
 drivers/net/virtio/Makefile                   |   8 +
 drivers/net/virtio/virtnet.h                  | 246 ++++++++
 .../{virtio_net.c => virtio/virtnet_main.c}   | 534 ++++++------------
 7 files changed, 452 insertions(+), 361 deletions(-)
 create mode 100644 drivers/net/virtio/Kconfig
 create mode 100644 drivers/net/virtio/Makefile
 create mode 100644 drivers/net/virtio/virtnet.h
 rename drivers/net/{virtio_net.c => virtio/virtnet_main.c} (94%)

--
2.32.0.3.g01195cf9f

Comments

Simon Horman May 8, 2024, 8:53 a.m. UTC | #1
On Wed, May 08, 2024 at 04:05:07PM +0800, Xuan Zhuo wrote:
> This patch set prepares for supporting af-xdp zerocopy.
> There is no feature change in this patch set.
> I just want to reduce the patch num of the final patch set,
> so I split the patch set.
> 
> #1-#3 add independent directory for virtio-net
> #4-#7 do some refactor, the sub-functions will be used by the subsequent commits

Hi Xuan Zhuo,

This patch is targeted at net-next,
but unfortunately it does not apply to current net-next.
Please rebase and repost taking care to observe the 24h rule.

Link: https://docs.kernel.org/process/maintainer-netdev.html
Jakub Kicinski May 8, 2024, 3:20 p.m. UTC | #2
On Wed, 8 May 2024 09:53:08 +0100 Simon Horman wrote:
> On Wed, May 08, 2024 at 04:05:07PM +0800, Xuan Zhuo wrote:
> > This patch set prepares for supporting af-xdp zerocopy.
> > There is no feature change in this patch set.
> > I just want to reduce the patch num of the final patch set,
> > so I split the patch set.
> > 
> > #1-#3 add independent directory for virtio-net
> > #4-#7 do some refactor, the sub-functions will be used by the subsequent commits  
> 
> Hi Xuan Zhuo,
> 
> This patch is targeted at net-next,
> but unfortunately it does not apply to current net-next.
> Please rebase and repost taking care to observe the 24h rule.

Also - is this going to conflict with your premapped DMA work in the
vhost tree? If it does - just wait, please, the merge window is in 
a week..
Xuan Zhuo May 9, 2024, 1:58 a.m. UTC | #3
On Wed, 8 May 2024 08:20:00 -0700, Jakub Kicinski <kuba@kernel.org> wrote:
> On Wed, 8 May 2024 09:53:08 +0100 Simon Horman wrote:
> > On Wed, May 08, 2024 at 04:05:07PM +0800, Xuan Zhuo wrote:
> > > This patch set prepares for supporting af-xdp zerocopy.
> > > There is no feature change in this patch set.
> > > I just want to reduce the patch num of the final patch set,
> > > so I split the patch set.
> > >
> > > #1-#3 add independent directory for virtio-net
> > > #4-#7 do some refactor, the sub-functions will be used by the subsequent commits
> >
> > Hi Xuan Zhuo,
> >
> > This patch is targeted at net-next,
> > but unfortunately it does not apply to current net-next.
> > Please rebase and repost taking care to observe the 24h rule.
>
> Also - is this going to conflict with your premapped DMA work in the
> vhost tree? If it does - just wait, please, the merge window is in
> a week..

NO.

This is on the top of

	http://lore.kernel.org/all/20240508063718.69806-1-xuanzhuo@linux.alibaba.com

That is targeted to net-next.

I will wait until it is merged to repost.

Thanks.
Xuan Zhuo May 23, 2024, 2:26 a.m. UTC | #4
Any comments for this.

Thanks.

On Wed,  8 May 2024 16:05:07 +0800, Xuan Zhuo <xuanzhuo@linux.alibaba.com> wrote:
> This patch set prepares for supporting af-xdp zerocopy.
> There is no feature change in this patch set.
> I just want to reduce the patch num of the final patch set,
> so I split the patch set.
>
> #1-#3 add independent directory for virtio-net
> #4-#7 do some refactor, the sub-functions will be used by the subsequent commits
>
> Thanks.
>
> Xuan Zhuo (7):
>   virtio_net: independent directory
>   virtio_net: move core structures to virtio_net.h
>   virtio_net: add prefix virtnet to all struct inside virtio_net.h
>   virtio_net: separate virtnet_rx_resize()
>   virtio_net: separate virtnet_tx_resize()
>   virtio_net: separate receive_mergeable
>   virtio_net: separate receive_buf
>
>  MAINTAINERS                                   |   2 +-
>  drivers/net/Kconfig                           |   9 +-
>  drivers/net/Makefile                          |   2 +-
>  drivers/net/virtio/Kconfig                    |  12 +
>  drivers/net/virtio/Makefile                   |   8 +
>  drivers/net/virtio/virtnet.h                  | 246 ++++++++
>  .../{virtio_net.c => virtio/virtnet_main.c}   | 534 ++++++------------
>  7 files changed, 452 insertions(+), 361 deletions(-)
>  create mode 100644 drivers/net/virtio/Kconfig
>  create mode 100644 drivers/net/virtio/Makefile
>  create mode 100644 drivers/net/virtio/virtnet.h
>  rename drivers/net/{virtio_net.c => virtio/virtnet_main.c} (94%)
>
> --
> 2.32.0.3.g01195cf9f
>
Jason Wang May 27, 2024, 3:38 a.m. UTC | #5
On Thu, May 23, 2024 at 10:27 AM Xuan Zhuo <xuanzhuo@linux.alibaba.com> wrote:
>
> Any comments for this.
>
> Thanks.

Will have a look.

Btw, does Michael happy with moving files into a dedicated directory?

Thanks

>
> On Wed,  8 May 2024 16:05:07 +0800, Xuan Zhuo <xuanzhuo@linux.alibaba.com> wrote:
> > This patch set prepares for supporting af-xdp zerocopy.
> > There is no feature change in this patch set.
> > I just want to reduce the patch num of the final patch set,
> > so I split the patch set.
> >
> > #1-#3 add independent directory for virtio-net
> > #4-#7 do some refactor, the sub-functions will be used by the subsequent commits
> >
> > Thanks.
> >
> > Xuan Zhuo (7):
> >   virtio_net: independent directory
> >   virtio_net: move core structures to virtio_net.h
> >   virtio_net: add prefix virtnet to all struct inside virtio_net.h
> >   virtio_net: separate virtnet_rx_resize()
> >   virtio_net: separate virtnet_tx_resize()
> >   virtio_net: separate receive_mergeable
> >   virtio_net: separate receive_buf
> >
> >  MAINTAINERS                                   |   2 +-
> >  drivers/net/Kconfig                           |   9 +-
> >  drivers/net/Makefile                          |   2 +-
> >  drivers/net/virtio/Kconfig                    |  12 +
> >  drivers/net/virtio/Makefile                   |   8 +
> >  drivers/net/virtio/virtnet.h                  | 246 ++++++++
> >  .../{virtio_net.c => virtio/virtnet_main.c}   | 534 ++++++------------
> >  7 files changed, 452 insertions(+), 361 deletions(-)
> >  create mode 100644 drivers/net/virtio/Kconfig
> >  create mode 100644 drivers/net/virtio/Makefile
> >  create mode 100644 drivers/net/virtio/virtnet.h
> >  rename drivers/net/{virtio_net.c => virtio/virtnet_main.c} (94%)
> >
> > --
> > 2.32.0.3.g01195cf9f
> >
>
Xuan Zhuo May 28, 2024, 2:06 a.m. UTC | #6
On Mon, 27 May 2024 11:38:49 +0800, Jason Wang <jasowang@redhat.com> wrote:
> On Thu, May 23, 2024 at 10:27 AM Xuan Zhuo <xuanzhuo@linux.alibaba.com> wrote:
> >
> > Any comments for this.
> >
> > Thanks.
>
> Will have a look.
>
> Btw, does Michael happy with moving files into a dedicated directory?


Based on our previous discussions, I believe that he is okay.

Thanks


>
> Thanks
>
> >
> > On Wed,  8 May 2024 16:05:07 +0800, Xuan Zhuo <xuanzhuo@linux.alibaba.com> wrote:
> > > This patch set prepares for supporting af-xdp zerocopy.
> > > There is no feature change in this patch set.
> > > I just want to reduce the patch num of the final patch set,
> > > so I split the patch set.
> > >
> > > #1-#3 add independent directory for virtio-net
> > > #4-#7 do some refactor, the sub-functions will be used by the subsequent commits
> > >
> > > Thanks.
> > >
> > > Xuan Zhuo (7):
> > >   virtio_net: independent directory
> > >   virtio_net: move core structures to virtio_net.h
> > >   virtio_net: add prefix virtnet to all struct inside virtio_net.h
> > >   virtio_net: separate virtnet_rx_resize()
> > >   virtio_net: separate virtnet_tx_resize()
> > >   virtio_net: separate receive_mergeable
> > >   virtio_net: separate receive_buf
> > >
> > >  MAINTAINERS                                   |   2 +-
> > >  drivers/net/Kconfig                           |   9 +-
> > >  drivers/net/Makefile                          |   2 +-
> > >  drivers/net/virtio/Kconfig                    |  12 +
> > >  drivers/net/virtio/Makefile                   |   8 +
> > >  drivers/net/virtio/virtnet.h                  | 246 ++++++++
> > >  .../{virtio_net.c => virtio/virtnet_main.c}   | 534 ++++++------------
> > >  7 files changed, 452 insertions(+), 361 deletions(-)
> > >  create mode 100644 drivers/net/virtio/Kconfig
> > >  create mode 100644 drivers/net/virtio/Makefile
> > >  create mode 100644 drivers/net/virtio/virtnet.h
> > >  rename drivers/net/{virtio_net.c => virtio/virtnet_main.c} (94%)
> > >
> > > --
> > > 2.32.0.3.g01195cf9f
> > >
> >
>