| Message ID | 20240527021916.12953-3-duchao@eswincomputing.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | target/riscv/kvm: QEMU support for KVM Guest Debug on RISC-V | expand |
On 5/26/24 23:19, Chao Du wrote: > Set the control flag when there are active breakpoints. This will > help KVM to know the status in the userspace. > > Signed-off-by: Chao Du <duchao@eswincomputing.com> > --- Reviewed-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com> > target/riscv/kvm/kvm-cpu.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/target/riscv/kvm/kvm-cpu.c b/target/riscv/kvm/kvm-cpu.c > index cba55c552d..0bc3348b91 100644 > --- a/target/riscv/kvm/kvm-cpu.c > +++ b/target/riscv/kvm/kvm-cpu.c > @@ -2039,5 +2039,7 @@ void kvm_arch_remove_all_hw_breakpoints(void) > > void kvm_arch_update_guest_debug(CPUState *cs, struct kvm_guest_debug *dbg) > { > - /* TODO; To be implemented later. */ > + if (kvm_sw_breakpoints_active(cs)) { > + dbg->control |= KVM_GUESTDBG_ENABLE; > + } > }
On Mon, May 27, 2024 at 02:19:14AM GMT, Chao Du wrote: > Set the control flag when there are active breakpoints. This will > help KVM to know the status in the userspace. > > Signed-off-by: Chao Du <duchao@eswincomputing.com> > --- > target/riscv/kvm/kvm-cpu.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/target/riscv/kvm/kvm-cpu.c b/target/riscv/kvm/kvm-cpu.c > index cba55c552d..0bc3348b91 100644 > --- a/target/riscv/kvm/kvm-cpu.c > +++ b/target/riscv/kvm/kvm-cpu.c > @@ -2039,5 +2039,7 @@ void kvm_arch_remove_all_hw_breakpoints(void) > > void kvm_arch_update_guest_debug(CPUState *cs, struct kvm_guest_debug *dbg) > { > - /* TODO; To be implemented later. */ > + if (kvm_sw_breakpoints_active(cs)) { > + dbg->control |= KVM_GUESTDBG_ENABLE; > + } > } > -- > 2.17.1 > > Should squash this into the previous patch. Thanks, drew
diff --git a/target/riscv/kvm/kvm-cpu.c b/target/riscv/kvm/kvm-cpu.c index cba55c552d..0bc3348b91 100644 --- a/target/riscv/kvm/kvm-cpu.c +++ b/target/riscv/kvm/kvm-cpu.c @@ -2039,5 +2039,7 @@ void kvm_arch_remove_all_hw_breakpoints(void) void kvm_arch_update_guest_debug(CPUState *cs, struct kvm_guest_debug *dbg) { - /* TODO; To be implemented later. */ + if (kvm_sw_breakpoints_active(cs)) { + dbg->control |= KVM_GUESTDBG_ENABLE; + } }
Set the control flag when there are active breakpoints. This will help KVM to know the status in the userspace. Signed-off-by: Chao Du <duchao@eswincomputing.com> --- target/riscv/kvm/kvm-cpu.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)