| Message ID | 20240220-lm3630a-fixups-v1-0-9ca62f7e4a33@z3ntu.xyz (mailing list archive) |
|---|---|
| Headers | show |
| Series | Various fixes for the lm3630a backlight driver | expand |
On Tue, 20 Feb 2024 00:11:18 +0100, Luca Weiss wrote: > On the MSM8974 Nexus 5 and OnePlus One phones (latter doesn't have > display upstream) the display backlight was turning off whenever you > would write a brightness to sysfs since a recent commit to the driver > (kernel v6.5). > > backlight: lm3630a: Turn off both led strings when display is blank > > [...] Applied, thanks! [1/4] backlight: lm3630a: Initialize backlight_properties on init commit: 4602c7615989e6e7052e317995a66014eb318082 [2/4] backlight: lm3630a: Don't set bl->props.brightness in get_brightness commit: ebb3b9a65b56e9b21841ab9a15b946407cd6b104 [3/4] backlight: lm3630a: Use backlight_get_brightness helper in update_status commit: 3c40590fafd4cc2447fb482a640c450e1a58ffa1 -- Lee Jones [李琼斯]
On Tue, 20 Feb 2024 00:11:18 +0100, Luca Weiss wrote: > On the MSM8974 Nexus 5 and OnePlus One phones (latter doesn't have > display upstream) the display backlight was turning off whenever you > would write a brightness to sysfs since a recent commit to the driver > (kernel v6.5). > > backlight: lm3630a: Turn off both led strings when display is blank > > [...] Applied, thanks! [4/4] ARM: dts: qcom: msm8974-hammerhead: Hook up backlight commit: e23dfb4ee30a120a947abb94a718ccc1eb5f87ff Best regards,
On the MSM8974 Nexus 5 and OnePlus One phones (latter doesn't have display upstream) the display backlight was turning off whenever you would write a brightness to sysfs since a recent commit to the driver (kernel v6.5). backlight: lm3630a: Turn off both led strings when display is blank Turns out, backlight_is_blank() thought the display was blanked because the props variable is was checking was never actually initialized so it was just reading some value that was left before. The first commit in this series fixes this, and the others are some cleanups / fixes I noticed while working on this. As last commit, we can finally hook up the panel and backlight on the Nexus 5 so blanking the screen actually turns off the backlight. Signed-off-by: Luca Weiss <luca@z3ntu.xyz> --- Luca Weiss (4): backlight: lm3630a: Initialize backlight_properties on init backlight: lm3630a: Don't set bl->props.brightness in get_brightness backlight: lm3630a: Use backlight_get_brightness helper in update_status ARM: dts: qcom: msm8974-hammerhead: Hook up backlight .../qcom/qcom-msm8974-lge-nexus5-hammerhead.dts | 4 ++- drivers/video/backlight/lm3630a_bl.c | 29 ++++++++++------------ 2 files changed, 16 insertions(+), 17 deletions(-) --- base-commit: b401b621758e46812da61fa58a67c3fd8d91de0d change-id: 20240219-lm3630a-fixups-8a9359e5a8ce Best regards,