| Message ID | 20240530082556.2960148-2-quic_kriskura@quicinc.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Disable SS instances in park mode for SC7180/ SC7280 | expand |
On Thu, May 30, 2024 at 01:55:55PM +0530, Krishna Kurapati wrote: > On SC7180, in host mode, it is observed that stressing out controller > in host mode results in HC died error and only restarting the host > mode fixes it. Disable SS instances in park mode for these targets to > avoid host controller being dead. Just out of curiosity, what is the park mode? > > Reported-by: Doug Anderson <dianders@google.com> > Cc: <stable@vger.kernel.org> > Fixes: 0b766e7fe5a2 ("arm64: dts: qcom: sc7180: Add USB related nodes") > Signed-off-by: Krishna Kurapati <quic_kriskura@quicinc.com> > --- > arch/arm64/boot/dts/qcom/sc7180.dtsi | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi > index 2b481e20ae38..cc93b5675d5d 100644 > --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi > @@ -3063,6 +3063,7 @@ usb_1_dwc3: usb@a600000 { > iommus = <&apps_smmu 0x540 0>; > snps,dis_u2_susphy_quirk; > snps,dis_enblslpm_quirk; > + snps,parkmode-disable-ss-quirk; > phys = <&usb_1_hsphy>, <&usb_1_qmpphy QMP_USB43DP_USB3_PHY>; > phy-names = "usb2-phy", "usb3-phy"; > maximum-speed = "super-speed"; > -- > 2.34.1 >
Hi, On Thu, May 30, 2024 at 1:26 AM Krishna Kurapati <quic_kriskura@quicinc.com> wrote: > > On SC7180, in host mode, it is observed that stressing out controller > in host mode results in HC died error and only restarting the host > mode fixes it. Disable SS instances in park mode for these targets to > avoid host controller being dead. > > Reported-by: Doug Anderson <dianders@google.com> > Cc: <stable@vger.kernel.org> > Fixes: 0b766e7fe5a2 ("arm64: dts: qcom: sc7180: Add USB related nodes") > Signed-off-by: Krishna Kurapati <quic_kriskura@quicinc.com> > --- > arch/arm64/boot/dts/qcom/sc7180.dtsi | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Douglas Anderson <dianders@chromium.org> Tested-by: Douglas Anderson <dianders@chromium.org>
On Thu, May 30, 2024 at 01:55:55PM GMT, Krishna Kurapati wrote: > On SC7180, in host mode, it is observed that stressing out controller > in host mode results in HC died error and only restarting the host Could you please include a copy of that error message, so that others searching for that error message will be able to find this commit? Also, there's three "in host mode"s in this sentence. > mode fixes it. Disable SS instances in park mode for these targets to Please spell SS SuperSpeed. Regards, Bjorn > avoid host controller being dead. > > Reported-by: Doug Anderson <dianders@google.com> > Cc: <stable@vger.kernel.org> > Fixes: 0b766e7fe5a2 ("arm64: dts: qcom: sc7180: Add USB related nodes") > Signed-off-by: Krishna Kurapati <quic_kriskura@quicinc.com> > --- > arch/arm64/boot/dts/qcom/sc7180.dtsi | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi > index 2b481e20ae38..cc93b5675d5d 100644 > --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi > @@ -3063,6 +3063,7 @@ usb_1_dwc3: usb@a600000 { > iommus = <&apps_smmu 0x540 0>; > snps,dis_u2_susphy_quirk; > snps,dis_enblslpm_quirk; > + snps,parkmode-disable-ss-quirk; > phys = <&usb_1_hsphy>, <&usb_1_qmpphy QMP_USB43DP_USB3_PHY>; > phy-names = "usb2-phy", "usb3-phy"; > maximum-speed = "super-speed"; > -- > 2.34.1 >
diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi index 2b481e20ae38..cc93b5675d5d 100644 --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi @@ -3063,6 +3063,7 @@ usb_1_dwc3: usb@a600000 { iommus = <&apps_smmu 0x540 0>; snps,dis_u2_susphy_quirk; snps,dis_enblslpm_quirk; + snps,parkmode-disable-ss-quirk; phys = <&usb_1_hsphy>, <&usb_1_qmpphy QMP_USB43DP_USB3_PHY>; phy-names = "usb2-phy", "usb3-phy"; maximum-speed = "super-speed";
On SC7180, in host mode, it is observed that stressing out controller in host mode results in HC died error and only restarting the host mode fixes it. Disable SS instances in park mode for these targets to avoid host controller being dead. Reported-by: Doug Anderson <dianders@google.com> Cc: <stable@vger.kernel.org> Fixes: 0b766e7fe5a2 ("arm64: dts: qcom: sc7180: Add USB related nodes") Signed-off-by: Krishna Kurapati <quic_kriskura@quicinc.com> --- arch/arm64/boot/dts/qcom/sc7180.dtsi | 1 + 1 file changed, 1 insertion(+)