| Message ID | 20240530111918.21974-1-peter.ujfalusi@linux.intel.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | ASoC: SOF: ipc4-topology: Fix nhlt configuration blob selection | expand |
On Thu, 30 May 2024 14:19:13 +0300, Peter Ujfalusi wrote: > the existing logic to pick a DMIC blob is based on several historical assumptions > that the NHLT in BIOS always contains 32-bits per sample type (first patch, [1]). > > The other issue with the existing logic is that it was designed to care only > about the bit depth of the format and fails to find the existing and correct > blob when rate/channels are different on the FE side compared to what we should > be using on the DAI side (we have components in path which can change > rate/channel count). > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/5] ASoC: SOF: ipc4-topology: Add support for NHLT with 16-bit only DMIC blob commit: 49cb894d567980235b6e64d5e69950ff77debd8c [2/5] ASoC: SOF: ipc4-topology: Print out the channel count in sof_ipc4_dbg_audio_format commit: 2a865c9c3fb0289a95f1cb51b42d248736ff45cb [3/5] ASoC: SOF: ipc4-topology/pcm: Rename sof_ipc4_copier_is_single_format() commit: 3b64fd2f83f203f5a34faed3dadf6464313f827d [4/5] ASoC: SOF: ipc4-topology: Improve readability of sof_ipc4_prepare_dai_copier() commit: 2fcad03eaba1b86e6b829f73a9e75e681b7f3106 [5/5] ASoC: SOF: ipc4-topology: Adjust the params based on DAI formats commit: b65456b7b379e20ab225a4e906dc4a0c98fddd7a All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
Hi, the existing logic to pick a DMIC blob is based on several historical assumptions that the NHLT in BIOS always contains 32-bits per sample type (first patch, [1]). The other issue with the existing logic is that it was designed to care only about the bit depth of the format and fails to find the existing and correct blob when rate/channels are different on the FE side compared to what we should be using on the DAI side (we have components in path which can change rate/channel count). These issues have not been observed in past but with new MTL based (Windows) laptops and new topologies to enhance the audio quality, we started to see weird issues around how our assumptions of vendors failed. Since some NHLT blob handling cleanup has been done for 6.10, this series will complete that work to cover even cases that we don't anticipate to see. [1] https://github.com/thesofproject/linux/issues/4973 Regards, Peter --- Peter Ujfalusi (5): ASoC: SOF: ipc4-topology: Add support for NHLT with 16-bit only DMIC blob ASoC: SOF: ipc4-topology: Print out the channel count in sof_ipc4_dbg_audio_format ASoC: SOF: ipc4-topology/pcm: Rename sof_ipc4_copier_is_single_format() ASoC: SOF: ipc4-topology: Improve readability of sof_ipc4_prepare_dai_copier() ASoC: SOF: ipc4-topology: Adjust the params based on DAI formats sound/soc/sof/ipc4-pcm.c | 12 +-- sound/soc/sof/ipc4-topology.c | 155 +++++++++++++++++++++++----------- sound/soc/sof/ipc4-topology.h | 6 +- 3 files changed, 115 insertions(+), 58 deletions(-)