| Message ID | 20240529-feature_ptp_netnext-v13-12-6eda4d40fa4f@bootlin.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: Make timestamping selectable | expand |
> -----Original Message----- > From: Kory Maincent <kory.maincent@bootlin.com> > Sent: Wednesday, May 29, 2024 3:10 PM > To: Florian Fainelli <florian.fainelli@broadcom.com>; Broadcom internal kernel > review list <bcm-kernel-feedback-list@broadcom.com>; Andrew Lunn > <andrew@lunn.ch>; Heiner Kallweit <hkallweit1@gmail.com>; Russell King > <linux@armlinux.org.uk>; David S. Miller <davem@davemloft.net>; Eric > Dumazet <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>; Paolo > Abeni <pabeni@redhat.com>; Richard Cochran <richardcochran@gmail.com>; > Radu Pirea <radu-nicolae.pirea@oss.nxp.com>; Jay Vosburgh > <j.vosburgh@gmail.com>; Andy Gospodarek <andy@greyhouse.net>; Nicolas > Ferre <nicolas.ferre@microchip.com>; Claudiu Beznea > <claudiu.beznea@tuxon.dev>; Willem de Bruijn > <willemdebruijn.kernel@gmail.com>; Jonathan Corbet <corbet@lwn.net>; > Horatiu Vultur <horatiu.vultur@microchip.com>; > UNGLinuxDriver@microchip.com; Simon Horman <horms@kernel.org>; > Vladimir Oltean <vladimir.oltean@nxp.com> > Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>; > netdev@vger.kernel.org; linux-kernel@vger.kernel.org; linux- > doc@vger.kernel.org; Maxime Chevallier <maxime.chevallier@bootlin.com>; > Rahul Rameshbabu <rrameshbabu@nvidia.com>; Kory Maincent > <kory.maincent@bootlin.com> > Subject: [PATCH net-next v13 12/14] net: ptp: Move > ptp_clock_index() to builtin symbol > > Move ptp_clock_index() to builtin symbols to prepare for supporting get and > set hardware timestamps from ethtool, which is builtin. > > Signed-off-by: Kory Maincent <kory.maincent@bootlin.com> > --- > > Change in v13: > - New patch > --- > drivers/ptp/ptp_clock.c | 6 ------ > drivers/ptp/ptp_clock_consumer.c | 6 ++++++ > 2 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/ptp/ptp_clock.c b/drivers/ptp/ptp_clock.c index > 593b5c906314..fc4b266abe1d 100644 > --- a/drivers/ptp/ptp_clock.c > +++ b/drivers/ptp/ptp_clock.c > @@ -460,12 +460,6 @@ void ptp_clock_event(struct ptp_clock *ptp, struct > ptp_clock_event *event) } EXPORT_SYMBOL(ptp_clock_event); > > -int ptp_clock_index(struct ptp_clock *ptp) -{ > - return ptp->index; > -} > -EXPORT_SYMBOL(ptp_clock_index); > - > int ptp_find_pin(struct ptp_clock *ptp, > enum ptp_pin_function func, unsigned int chan) { diff --git > a/drivers/ptp/ptp_clock_consumer.c b/drivers/ptp/ptp_clock_consumer.c > index 759dd6f63405..2322fa65075e 100644 > --- a/drivers/ptp/ptp_clock_consumer.c > +++ b/drivers/ptp/ptp_clock_consumer.c > @@ -97,3 +97,9 @@ void ptp_clock_put(struct device *dev, struct ptp_clock > *ptp) > put_device(&ptp->dev); > module_put(ptp->info->owner); > } > + > +int ptp_clock_index(struct ptp_clock *ptp) { > + return ptp->index; > +} > +EXPORT_SYMBOL(ptp_clock_index); > Please check the "build_clang - FAILED", "build_32bit - FAILED" build errors. > -- > 2.34.1 >
Hello Sai, On Thu, 30 May 2024 11:23:10 +0000 Sai Krishna Gajula <saikrishnag@marvell.com> wrote: > > Move ptp_clock_index() to builtin symbols to prepare for supporting get and > > set hardware timestamps from ethtool, which is builtin. > > > > Signed-off-by: Kory Maincent <kory.maincent@bootlin.com> > > } > > + > > +int ptp_clock_index(struct ptp_clock *ptp) { > > + return ptp->index; > > +} > > +EXPORT_SYMBOL(ptp_clock_index); > > > Please check the "build_clang - FAILED", "build_32bit - FAILED" build errors. Could you be more explicit? Which config are you using? What is the build error? I don't really see how this patch can bring a 32bit or clang build error. Regards,
On Thu, 30 May 2024 14:53:50 +0200 Kory Maincent wrote: > > Please check the "build_clang - FAILED", "build_32bit - FAILED" build errors. > > Could you be more explicit? Which config are you using? > What is the build error? > > I don't really see how this patch can bring a 32bit or clang build error. Must be the same build problem I reported.
diff --git a/drivers/ptp/ptp_clock.c b/drivers/ptp/ptp_clock.c index 593b5c906314..fc4b266abe1d 100644 --- a/drivers/ptp/ptp_clock.c +++ b/drivers/ptp/ptp_clock.c @@ -460,12 +460,6 @@ void ptp_clock_event(struct ptp_clock *ptp, struct ptp_clock_event *event) } EXPORT_SYMBOL(ptp_clock_event); -int ptp_clock_index(struct ptp_clock *ptp) -{ - return ptp->index; -} -EXPORT_SYMBOL(ptp_clock_index); - int ptp_find_pin(struct ptp_clock *ptp, enum ptp_pin_function func, unsigned int chan) { diff --git a/drivers/ptp/ptp_clock_consumer.c b/drivers/ptp/ptp_clock_consumer.c index 759dd6f63405..2322fa65075e 100644 --- a/drivers/ptp/ptp_clock_consumer.c +++ b/drivers/ptp/ptp_clock_consumer.c @@ -97,3 +97,9 @@ void ptp_clock_put(struct device *dev, struct ptp_clock *ptp) put_device(&ptp->dev); module_put(ptp->info->owner); } + +int ptp_clock_index(struct ptp_clock *ptp) +{ + return ptp->index; +} +EXPORT_SYMBOL(ptp_clock_index);
Move ptp_clock_index() to builtin symbols to prepare for supporting get and set hardware timestamps from ethtool, which is builtin. Signed-off-by: Kory Maincent <kory.maincent@bootlin.com> --- Change in v13: - New patch --- drivers/ptp/ptp_clock.c | 6 ------ drivers/ptp/ptp_clock_consumer.c | 6 ++++++ 2 files changed, 6 insertions(+), 6 deletions(-)