| Message ID | 20240528120246.3313723-1-arnd@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | mailbox: zynqmp-ipi: drop irq_to_desc() call | expand |
Hello Arnd, Thanks for your patch. I am okay to remove it. I will test this and provide TB. Thanks, Tanmay On 5/28/24 7:02 AM, Arnd Bergmann wrote: > From: Arnd Bergmann <arnd@arndb.de> > > irq_to_desc() is not exported to loadable modules, so this driver now > fails to link in some configurations: > > ERROR: modpost: "irq_to_desc" [drivers/mailbox/zynqmp-ipi-mailbox.ko] undefined! > > I can't see a purpose for this call, since the return value is unused > and probably left over from some code refactoring. > > Address the link failure by just removing the line. > > Fixes: 6ffb1635341b ("mailbox: zynqmp: handle SGI for shared IPI") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > drivers/mailbox/zynqmp-ipi-mailbox.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/mailbox/zynqmp-ipi-mailbox.c b/drivers/mailbox/zynqmp-ipi-mailbox.c > index 7c90bac3de21..4acf5612487c 100644 > --- a/drivers/mailbox/zynqmp-ipi-mailbox.c > +++ b/drivers/mailbox/zynqmp-ipi-mailbox.c > @@ -850,7 +850,6 @@ static int xlnx_mbox_init_sgi(struct platform_device *pdev, > return ret; > } > > - irq_to_desc(pdata->virq_sgi); > irq_set_status_flags(pdata->virq_sgi, IRQ_PER_CPU); > > /* Setup function for the CPU hot-plug cases */
Tested-by: Tanmay Shah <tanmay.shah@amd.com> On 5/28/24 7:02 AM, Arnd Bergmann wrote: > From: Arnd Bergmann <arnd@arndb.de> > > irq_to_desc() is not exported to loadable modules, so this driver now > fails to link in some configurations: > > ERROR: modpost: "irq_to_desc" [drivers/mailbox/zynqmp-ipi-mailbox.ko] undefined! > > I can't see a purpose for this call, since the return value is unused > and probably left over from some code refactoring. > > Address the link failure by just removing the line. > > Fixes: 6ffb1635341b ("mailbox: zynqmp: handle SGI for shared IPI") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > drivers/mailbox/zynqmp-ipi-mailbox.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/mailbox/zynqmp-ipi-mailbox.c b/drivers/mailbox/zynqmp-ipi-mailbox.c > index 7c90bac3de21..4acf5612487c 100644 > --- a/drivers/mailbox/zynqmp-ipi-mailbox.c > +++ b/drivers/mailbox/zynqmp-ipi-mailbox.c > @@ -850,7 +850,6 @@ static int xlnx_mbox_init_sgi(struct platform_device *pdev, > return ret; > } > > - irq_to_desc(pdata->virq_sgi); > irq_set_status_flags(pdata->virq_sgi, IRQ_PER_CPU); > > /* Setup function for the CPU hot-plug cases */
diff --git a/drivers/mailbox/zynqmp-ipi-mailbox.c b/drivers/mailbox/zynqmp-ipi-mailbox.c index 7c90bac3de21..4acf5612487c 100644 --- a/drivers/mailbox/zynqmp-ipi-mailbox.c +++ b/drivers/mailbox/zynqmp-ipi-mailbox.c @@ -850,7 +850,6 @@ static int xlnx_mbox_init_sgi(struct platform_device *pdev, return ret; } - irq_to_desc(pdata->virq_sgi); irq_set_status_flags(pdata->virq_sgi, IRQ_PER_CPU); /* Setup function for the CPU hot-plug cases */