| Message ID | 20240529220026.1644986-2-wsadowski@marvell.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Marvell HW overlay support for Cadence xSPI | expand |
On Wed, May 29, 2024 at 03:00:23PM -0700, Witold Sadowski wrote: > Add new bindings for the v2 Marvell xSPI overlay: marvell,cn10-xspi-nor > compatible string. This new compatible string distinguishes between the > original and modified xSPI block. > > Also add an optional base for the xfer register set with an additional > reg field to allocate the xSPI Marvell overlay XFER block. > > Signed-off-by: Witold Sadowski <wsadowski@marvell.com> Missing a tag. But since you want it reviewed again... > --- > .../devicetree/bindings/spi/cdns,xspi.yaml | 32 ++++++++++++++++--- > 1 file changed, 28 insertions(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/spi/cdns,xspi.yaml b/Documentation/devicetree/bindings/spi/cdns,xspi.yaml > index eb0f92468185..49c6a2c82fc4 100644 > --- a/Documentation/devicetree/bindings/spi/cdns,xspi.yaml > +++ b/Documentation/devicetree/bindings/spi/cdns,xspi.yaml > @@ -15,24 +15,27 @@ description: | > single, dual, quad or octal wire transmission modes for > read/write access to slaves such as SPI-NOR flash. > > -allOf: > - - $ref: spi-controller.yaml# > - > properties: > compatible: > - const: cdns,xspi-nor > + enum: > + - cdns,xspi-nor > + - marvell,cn10-xspi-nor > > reg: > items: > - description: address and length of the controller register set > - description: address and length of the Slave DMA data port > - description: address and length of the auxiliary registers > + - description: address and length of the xfer registers > + minItems: 3 > > reg-names: > items: > - const: io > - const: sdma > - const: aux > + - const: xferbase 'base' is redundant. > + minItems: 3 > > interrupts: > maxItems: 1 > @@ -42,6 +45,27 @@ required: > - reg > - interrupts > > +allOf: > + - $ref: spi-controller.yaml# > + - if: > + properties: > + compatible: > + contains: > + enum: > + - marvell,cn10-xspi-nor > + then: > + properties: > + reg: > + minItems: 4 > + reg-names: > + minItems: 4 > + else: > + properties: > + reg: > + maxItems: 3 > + reg-names: > + maxItems: 3 > + > unevaluatedProperties: false > > examples: > -- > 2.43.0 >
On 30/05/2024 00:00, Witold Sadowski wrote: > Add new bindings for the v2 Marvell xSPI overlay: marvell,cn10-xspi-nor > compatible string. This new compatible string distinguishes between the > original and modified xSPI block. > > Also add an optional base for the xfer register set with an additional > reg field to allocate the xSPI Marvell overlay XFER block. > > Signed-off-by: Witold Sadowski <wsadowski@marvell.com> This is a friendly reminder during the review process. It looks like you received a tag and forgot to add it. If you do not know the process, here is a short explanation: Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions, under or above your Signed-off-by tag. Tag is "received", when provided in a message replied to you on the mailing list. Tools like b4 can help here. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for tags received on the version they apply. https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577 If a tag was not added on purpose, please state why and what changed. +the change by Rob Best regards, Krzysztof
> ---------------------------------------------------------------------- > On Wed, May 29, 2024 at 03:00:23PM -0700, Witold Sadowski wrote: > > Add new bindings for the v2 Marvell xSPI overlay: > > marvell,cn10-xspi-nor compatible string. This new compatible string > > distinguishes between the original and modified xSPI block. > > > > Also add an optional base for the xfer register set with an additional > > reg field to allocate the xSPI Marvell overlay XFER block. > > > > Signed-off-by: Witold Sadowski <wsadowski@marvell.com> > > Missing a tag. > > But since you want it reviewed again... > > > --- > > .../devicetree/bindings/spi/cdns,xspi.yaml | 32 ++++++++++++++++--- > > 1 file changed, 28 insertions(+), 4 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/spi/cdns,xspi.yaml > > b/Documentation/devicetree/bindings/spi/cdns,xspi.yaml > > index eb0f92468185..49c6a2c82fc4 100644 > > --- a/Documentation/devicetree/bindings/spi/cdns,xspi.yaml > > +++ b/Documentation/devicetree/bindings/spi/cdns,xspi.yaml > > @@ -15,24 +15,27 @@ description: | > > single, dual, quad or octal wire transmission modes for > > read/write access to slaves such as SPI-NOR flash. > > > > -allOf: > > - - $ref: spi-controller.yaml# > > - > > properties: > > compatible: > > - const: cdns,xspi-nor > > + enum: > > + - cdns,xspi-nor > > + - marvell,cn10-xspi-nor > > > > reg: > > items: > > - description: address and length of the controller register set > > - description: address and length of the Slave DMA data port > > - description: address and length of the auxiliary registers > > + - description: address and length of the xfer registers > > + minItems: 3 > > > > reg-names: > > items: > > - const: io > > - const: sdma > > - const: aux > > + - const: xferbase > > 'base' is redundant. Ok > > > + minItems: 3 > > > > interrupts: > > maxItems: 1 > > @@ -42,6 +45,27 @@ required: > > - reg > > - interrupts > > > > +allOf: > > + - $ref: spi-controller.yaml# > > + - if: > > + properties: > > + compatible: > > + contains: > > + enum: > > + - marvell,cn10-xspi-nor > > + then: > > + properties: > > + reg: > > + minItems: 4 > > + reg-names: > > + minItems: 4 > > + else: > > + properties: > > + reg: > > + maxItems: 3 > > + reg-names: > > + maxItems: 3 > > + > > unevaluatedProperties: false > > > > examples: > > -- > > 2.43.0 > >
diff --git a/Documentation/devicetree/bindings/spi/cdns,xspi.yaml b/Documentation/devicetree/bindings/spi/cdns,xspi.yaml index eb0f92468185..49c6a2c82fc4 100644 --- a/Documentation/devicetree/bindings/spi/cdns,xspi.yaml +++ b/Documentation/devicetree/bindings/spi/cdns,xspi.yaml @@ -15,24 +15,27 @@ description: | single, dual, quad or octal wire transmission modes for read/write access to slaves such as SPI-NOR flash. -allOf: - - $ref: spi-controller.yaml# - properties: compatible: - const: cdns,xspi-nor + enum: + - cdns,xspi-nor + - marvell,cn10-xspi-nor reg: items: - description: address and length of the controller register set - description: address and length of the Slave DMA data port - description: address and length of the auxiliary registers + - description: address and length of the xfer registers + minItems: 3 reg-names: items: - const: io - const: sdma - const: aux + - const: xferbase + minItems: 3 interrupts: maxItems: 1 @@ -42,6 +45,27 @@ required: - reg - interrupts +allOf: + - $ref: spi-controller.yaml# + - if: + properties: + compatible: + contains: + enum: + - marvell,cn10-xspi-nor + then: + properties: + reg: + minItems: 4 + reg-names: + minItems: 4 + else: + properties: + reg: + maxItems: 3 + reg-names: + maxItems: 3 + unevaluatedProperties: false examples:
Add new bindings for the v2 Marvell xSPI overlay: marvell,cn10-xspi-nor compatible string. This new compatible string distinguishes between the original and modified xSPI block. Also add an optional base for the xfer register set with an additional reg field to allocate the xSPI Marvell overlay XFER block. Signed-off-by: Witold Sadowski <wsadowski@marvell.com> --- .../devicetree/bindings/spi/cdns,xspi.yaml | 32 ++++++++++++++++--- 1 file changed, 28 insertions(+), 4 deletions(-)