| Message ID | xmqqbk4np77d.fsf@gitster.g (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | t1517: more coverage for commands that work without repository | expand |
On Thu, May 30, 2024 at 09:58:46AM -0700, Junio C Hamano wrote: [snip] > +test_expect_success 'stripspace outside repository' ' > + nongit git stripspace -s </dev/null > +' I was wondering whether we also want to verify that it does the correct thing here as it's comparatively easy: test_expect_success 'stripspace outside repository' ' cat >input <<-EOF && # foo bar EOF cat >expect <<-EOF && bar EOF git stripspace -s <input >actual && test_cmp expect actual && nongit git stripspace -s <input >actual && test_cmp expect actual ' For the other tests it's a bit more involved. And given that these are all designed as smoke tests, I think it's fine overall. Thanks! Patrick
Patrick Steinhardt <ps@pks.im> writes: > On Thu, May 30, 2024 at 09:58:46AM -0700, Junio C Hamano wrote: > [snip] >> +test_expect_success 'stripspace outside repository' ' >> + nongit git stripspace -s </dev/null >> +' > > I was wondering whether we also want to verify that it does the correct > thing here as it's comparatively easy: > ... > For the other tests it's a bit more involved. And given that these are > all designed as smoke tests, I think it's fine overall. Yup, as I said in the proposed log message, we may want to update them to actually do something useful later, but this would at least help us catch regressions by mistake.
diff --git c/t/t1517-outside-repo.sh w/t/t1517-outside-repo.sh index 557808ffa7..b77017ac5f 100755 --- c/t/t1517-outside-repo.sh +++ w/t/t1517-outside-repo.sh @@ -56,4 +56,52 @@ test_expect_success 'grep outside repository' ' test_cmp expect actual ' +test_expect_success 'imap-send outside repository' ' + test_config_global imap.host imaps://localhost && + test_config_global imap.folder Drafts && + + echo nothing to send >expect && + test_must_fail git imap-send -v </dev/null 2>actual && + test_cmp expect actual && + + ( + cd non-repo && + test_must_fail git imap-send -v </dev/null 2>../actual + ) && + test_cmp expect actual +' + +test_expect_success 'check-ref-format outside repository' ' + git check-ref-format --branch refs/heads/xyzzy >expect && + nongit git check-ref-format --branch refs/heads/xyzzy >actual && + test_cmp expect actual +' + +test_expect_success 'diff outside repository' ' + echo one >one && + echo two >two && + test_must_fail git diff --no-index one two >expect && + ( + cd non-repo && + cp ../one . && + cp ../two . && + test_must_fail git diff one two >../actual + ) && + test_cmp expect actual +' + +test_expect_success 'stripspace outside repository' ' + nongit git stripspace -s </dev/null +' + +test_expect_success 'remote-http outside repository' ' + test_must_fail git remote-http 2>actual && + test_grep "^error: remote-curl" actual && + ( + cd non-repo && + test_must_fail git remote-http 2>../actual + ) && + test_grep "^error: remote-curl" actual +' + test_done
While most of the commands in Git suite are designed to do useful things in Git repositories, some commands are also usable outside any repository. Building on top of an earlier work abece6e9 (t1517: test commands that are designed to be run outside repository, 2024-05-20) that adds tests for such commands, let's give coverage to some more commands. This patch covers commands whose code has hits for $ git grep setup_git_directory_gently and passes a pointer to nongit_ok variable it uses to allow it to run outside a Git repository, but mostly they are tested only to see that they start up (as opposed to dying with "not in a git repository" complaint). We may want to update them to actually do something useful later, but this would at least help us catch regressions by mistake. Signed-off-by: Junio C Hamano <gitster@pobox.com> --- * Designed to apply on top of jc/undecided-is-not-necessarily-sha1-fix that introduces t1517. t/t1517-outside-repo.sh | 48 ++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 48 insertions(+)