diff mbox series

can: mscan: remove unused struct 'mscan_state'

Message ID 20240525232509.191735-1-linux@treblig.org (mailing list archive)
State Awaiting Upstream
Delegated to: Netdev Maintainers
Headers show
Series can: mscan: remove unused struct 'mscan_state' | expand

Checks

Context Check Description
netdev/tree_selection success Series ignored based on subject

Commit Message

Dr. David Alan Gilbert May 25, 2024, 11:25 p.m. UTC 
From: "Dr. David Alan Gilbert" <linux@treblig.org>

'mscan_state' is unused since the original
commit afa17a500a36 ("net/can: add driver for mscan family &
mpc52xx_mscan").

Remove it.

Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
---
 drivers/net/can/mscan/mscan.c | 6 ------
 1 file changed, 6 deletions(-)

Comments

Simon Horman May 31, 2024, 3:40 p.m. UTC | #1 
On Sun, May 26, 2024 at 12:25:09AM +0100, linux@treblig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
> 
> 'mscan_state' is unused since the original
> commit afa17a500a36 ("net/can: add driver for mscan family &
> mpc52xx_mscan").
> 
> Remove it.
> 
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>

Reviewed-by: Simon Horman <horms@kernel.org>
Wolfram Sang June 3, 2024, 10:56 a.m. UTC | #2 
> 'mscan_state' is unused since the original
> commit afa17a500a36 ("net/can: add driver for mscan family &
> mpc52xx_mscan").
> 
> Remove it.
> 
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>

Wow, that driver was a long time ago. Thanks for the flashback :)

Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
diff mbox series

Patch

diff --git a/drivers/net/can/mscan/mscan.c b/drivers/net/can/mscan/mscan.c
index a6829cdc0e81..8c2a7bc64d3d 100644
--- a/drivers/net/can/mscan/mscan.c
+++ b/drivers/net/can/mscan/mscan.c
@@ -34,12 +34,6 @@  static const struct can_bittiming_const mscan_bittiming_const = {
 	.brp_inc = 1,
 };
 
-struct mscan_state {
-	u8 mode;
-	u8 canrier;
-	u8 cantier;
-};
-
 static enum can_state state_map[] = {
 	CAN_STATE_ERROR_ACTIVE,
 	CAN_STATE_ERROR_WARNING,