mbox series

[0/2] Fix ADDR_CHANGE event handling for NFSD

Message ID 20240531131550.64044-4-cel@kernel.org (mailing list archive)
Headers show
Series Fix ADDR_CHANGE event handling for NFSD | expand

Message

Chuck Lever May 31, 2024, 1:15 p.m. UTC
From: Chuck Lever <chuck.lever@oracle.com>

Sagi recently pointed out that the CM ADDR_CHANGE event handler in
svcrdma has a bug similar to one he fixed in the NVMe target. This
series attempts to address that issue.

Chuck Lever (2):
  svcrdma: Refactor the creation of listener CMA ID
  svcrdma: Handle ADDR_CHANGE CM event properly

 net/sunrpc/xprtrdma/svc_rdma_transport.c | 83 ++++++++++++++++--------
 1 file changed, 55 insertions(+), 28 deletions(-)

Comments

Sagi Grimberg June 2, 2024, 7:50 a.m. UTC | #1
On 31/05/2024 16:15, cel@kernel.org wrote:
> From: Chuck Lever <chuck.lever@oracle.com>
>
> Sagi recently pointed out that the CM ADDR_CHANGE event handler in
> svcrdma has a bug similar to one he fixed in the NVMe target. This
> series attempts to address that issue.
>
> Chuck Lever (2):
>    svcrdma: Refactor the creation of listener CMA ID
>    svcrdma: Handle ADDR_CHANGE CM event properly
>
>   net/sunrpc/xprtrdma/svc_rdma_transport.c | 83 ++++++++++++++++--------
>   1 file changed, 55 insertions(+), 28 deletions(-)
>

Looks good, For the series:

Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
Chuck Lever III June 3, 2024, 1:24 p.m. UTC | #2
> On Jun 2, 2024, at 3:50 AM, Sagi Grimberg <sagi@grimberg.me> wrote:
> 
> 
> 
> On 31/05/2024 16:15, cel@kernel.org wrote:
>> From: Chuck Lever <chuck.lever@oracle.com>
>> 
>> Sagi recently pointed out that the CM ADDR_CHANGE event handler in
>> svcrdma has a bug similar to one he fixed in the NVMe target. This
>> series attempts to address that issue.
>> 
>> Chuck Lever (2):
>>   svcrdma: Refactor the creation of listener CMA ID
>>   svcrdma: Handle ADDR_CHANGE CM event properly
>> 
>>  net/sunrpc/xprtrdma/svc_rdma_transport.c | 83 ++++++++++++++++--------
>>  1 file changed, 55 insertions(+), 28 deletions(-)
>> 
> 
> Looks good, For the series:
> 
> Reviewed-by: Sagi Grimberg <sagi@grimberg.me>

Thank you! Applied to nfsd-next (for 6.11).


--
Chuck Lever