| Message ID | 20240603170217.6243-1-kerneljasonxing@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | tcp/mptcp: count CLOSE-WAIT for CurrEstab | expand |
Hi Jason,
Thank you for your modifications, that's great!
Our CI did some validations and here is its report:
- KVM Validation: normal: Success! ✅
- KVM Validation: debug: Success! ✅
- KVM Validation: btf (only bpftest_all): Success! ✅
- Task: https://github.com/multipath-tcp/mptcp_net-next/actions/runs/9355807888
Initiator: Matthieu Baerts (NGI0)
Commits: https://github.com/multipath-tcp/mptcp_net-next/commits/3b2b65c4b8ae
Patchwork: https://patchwork.kernel.org/project/mptcp/list/?series=858351
If there are some issues, you can reproduce them using the same environment as
the one used by the CI thanks to a docker image, e.g.:
$ cd [kernel source code]
$ docker run -v "${PWD}:${PWD}:rw" -w "${PWD}" --privileged --rm -it \
--pull always mptcp/mptcp-upstream-virtme-docker:latest \
auto-normal
For more details:
https://github.com/multipath-tcp/mptcp-upstream-virtme-docker
Please note that despite all the efforts that have been already done to have a
stable tests suite when executed on a public CI like here, it is possible some
reported issues are not due to your modifications. Still, do not hesitate to
help us improve that ;-)
Cheers,
MPTCP GH Action bot
Bot operated by Matthieu Baerts (NGI0 Core)
Hi Jason,
Thank you for your modifications, that's great!
Our CI did some validations and here is its report:
- KVM Validation: normal: Success! ✅
- KVM Validation: debug: Success! ✅
- KVM Validation: btf (only bpftest_all): Success! ✅
- Task: https://github.com/multipath-tcp/mptcp_net-next/actions/runs/9369946878
Initiator: Patchew Applier
Commits: https://github.com/multipath-tcp/mptcp_net-next/commits/fc0f674bbb04
Patchwork: https://patchwork.kernel.org/project/mptcp/list/?series=858351
If there are some issues, you can reproduce them using the same environment as
the one used by the CI thanks to a docker image, e.g.:
$ cd [kernel source code]
$ docker run -v "${PWD}:${PWD}:rw" -w "${PWD}" --privileged --rm -it \
--pull always mptcp/mptcp-upstream-virtme-docker:latest \
auto-normal
For more details:
https://github.com/multipath-tcp/mptcp-upstream-virtme-docker
Please note that despite all the efforts that have been already done to have a
stable tests suite when executed on a public CI like here, it is possible some
reported issues are not due to your modifications. Still, do not hesitate to
help us improve that ;-)
Cheers,
MPTCP GH Action bot
Bot operated by Matthieu Baerts (NGI0 Core)
Hello: This series was applied to netdev/net.git (main) by David S. Miller <davem@davemloft.net>: On Tue, 4 Jun 2024 01:02:15 +0800 you wrote: > From: Jason Xing <kernelxing@tencent.com> > > Taking CLOSE-WAIT sockets into CurrEstab counters is in accordance with RFC > 1213, as suggested by Eric and Neal. > > v5 > Link: https://lore.kernel.org/all/20240531091753.75930-1-kerneljasonxing@gmail.com/ > 1. add more detailed comment (Matthieu) > > [...] Here is the summary with links: - [net,v5,1/2] tcp: count CLOSE-WAIT sockets for TCP_MIB_CURRESTAB https://git.kernel.org/netdev/net/c/a46d0ea5c942 - [net,v5,2/2] mptcp: count CLOSE-WAIT sockets for MPTCP_MIB_CURRESTAB https://git.kernel.org/netdev/net/c/9633e9377e6a You are awesome, thank you!
From: Jason Xing <kernelxing@tencent.com> Taking CLOSE-WAIT sockets into CurrEstab counters is in accordance with RFC 1213, as suggested by Eric and Neal. v5 Link: https://lore.kernel.org/all/20240531091753.75930-1-kerneljasonxing@gmail.com/ 1. add more detailed comment (Matthieu) v4 Link: https://lore.kernel.org/all/20240530131308.59737-1-kerneljasonxing@gmail.com/ 1. correct the Fixes: tag in patch [2/2]. (Eric) Previous discussion Link: https://lore.kernel.org/all/20240529033104.33882-1-kerneljasonxing@gmail.com/ Jason Xing (2): tcp: count CLOSE-WAIT sockets for TCP_MIB_CURRESTAB mptcp: count CLOSE-WAIT sockets for MPTCP_MIB_CURRESTAB net/ipv4/tcp.c | 6 +++++- net/mptcp/protocol.c | 9 +++++++-- 2 files changed, 12 insertions(+), 3 deletions(-)