| Message ID | 20240527134129.1695450-3-niklas.soderlund+renesas@ragnatech.se (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | arm64: dts: renesas: gray-hawk: Add video capture pipeline | expand |
Hi Niklas, On Mon, May 27, 2024 at 3:41 PM Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> wrote: > Before adding the CSI nodes for gray-hawk create a dedicated DTS file > for the CSI/DSI functionality to reflect what is done for white-hawk. > > For now its contents are limited to the Board ID EEPROM. > > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> Thanks for your patch > --- /dev/null > +++ b/arch/arm64/boot/dts/renesas/gray-hawk-csi-dsi.dtsi > @@ -0,0 +1,16 @@ > +// SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +/* > + * Device Tree Source for the R-Car V4M Gray Hawk CSI/DSI sub-board I have mixed feelings about this patch, as (AFAIK) there is no such thing as a Gray Hawk CSI/DSI sub-board, so at least the comment should be fixed. However, it does make sense to make things as similar as possible to White Hawk (Single). In the end, I do hope to share most of the White/Gray Hawk (Single) DTS. Of course we have to cater for the small differences like the use of a C-PHY vs. D-PHY, which is one difference I hadn't realized before. What do other people think? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
diff --git a/arch/arm64/boot/dts/renesas/gray-hawk-csi-dsi.dtsi b/arch/arm64/boot/dts/renesas/gray-hawk-csi-dsi.dtsi new file mode 100644 index 000000000000..68a37e2077e1 --- /dev/null +++ b/arch/arm64/boot/dts/renesas/gray-hawk-csi-dsi.dtsi @@ -0,0 +1,16 @@ +// SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +/* + * Device Tree Source for the R-Car V4M Gray Hawk CSI/DSI sub-board + * + * Copyright (C) 2023 Renesas Electronics Corp. + * Copyright (C) 2024 Niklas Söderlund <niklas.soderlund@ragnatech.se> + */ + +&i2c0 { + eeprom@52 { + compatible = "rohm,br24g01", "atmel,24c01"; + label = "csi-dsi-sub-board-id"; + reg = <0x52>; + pagesize = <8>; + }; +}; diff --git a/arch/arm64/boot/dts/renesas/r8a779h0-gray-hawk-single.dts b/arch/arm64/boot/dts/renesas/r8a779h0-gray-hawk-single.dts index bc8616a56c03..db144833550a 100644 --- a/arch/arm64/boot/dts/renesas/r8a779h0-gray-hawk-single.dts +++ b/arch/arm64/boot/dts/renesas/r8a779h0-gray-hawk-single.dts @@ -11,6 +11,7 @@ #include <dt-bindings/gpio/gpio.h> #include "r8a779h0.dtsi" +#include "gray-hawk-csi-dsi.dtsi" / { model = "Renesas Gray Hawk Single board based on r8a779h0"; @@ -111,13 +112,6 @@ eeprom@51 { pagesize = <8>; }; - eeprom@52 { - compatible = "rohm,br24g01", "atmel,24c01"; - label = "csi-dsi-sub-board-id"; - reg = <0x52>; - pagesize = <8>; - }; - eeprom@53 { compatible = "rohm,br24g01", "atmel,24c01"; label = "ethernet-sub-board-id";
Before adding the CSI nodes for gray-hawk create a dedicated DTS file for the CSI/DSI functionality to reflect what is done for white-hawk. For now its contents are limited to the Board ID EEPROM. Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> --- .../boot/dts/renesas/gray-hawk-csi-dsi.dtsi | 16 ++++++++++++++++ .../dts/renesas/r8a779h0-gray-hawk-single.dts | 8 +------- 2 files changed, 17 insertions(+), 7 deletions(-) create mode 100644 arch/arm64/boot/dts/renesas/gray-hawk-csi-dsi.dtsi