| Message ID | 20240603-x1e80100-dts-pmics-drop-4th-smb2360-from-crd-v2-1-fb63973cc07d@linaro.org (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [v2] arm64: dts: qcom: x1e80100: Disable the SMB2360 4th instance by default | expand |
On 6/3/24 10:17, Abel Vesa wrote: > The CRD board doesn't have the 4th SMB2360 PMIC populated while the QCP > does. So enable it on QCP only. This fixes the warning for the missing > PMIC on CRD as well. > > Fixes: 2559e61e7ef4 ("arm64: dts: qcom: x1e80100-pmics: Add the missing PMICs") > Reviewed-by: Johan Hovold <johan+linaro@kernel.org> > Tested-by: Johan Hovold <johan+linaro@kernel.org> > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > Signed-off-by: Abel Vesa <abel.vesa@linaro.org> > --- > Changes in v2: > - Fetched all R-b and T-b tags Almost.. gotta do it twice to make sure it's posted Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad
On 24-06-04 14:01:11, Konrad Dybcio wrote: > > > On 6/3/24 10:17, Abel Vesa wrote: > > The CRD board doesn't have the 4th SMB2360 PMIC populated while the QCP > > does. So enable it on QCP only. This fixes the warning for the missing > > PMIC on CRD as well. > > > > Fixes: 2559e61e7ef4 ("arm64: dts: qcom: x1e80100-pmics: Add the missing PMICs") > > Reviewed-by: Johan Hovold <johan+linaro@kernel.org> > > Tested-by: Johan Hovold <johan+linaro@kernel.org> > > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > > Signed-off-by: Abel Vesa <abel.vesa@linaro.org> > > --- > > Changes in v2: > > - Fetched all R-b and T-b tags > > Almost.. > > gotta do it twice to make sure it's posted Actually you sent your R-b tag to v1 exactly one day after v2 was already sent. :) But I think b4 would've picked up the one from v1 anyway. > > Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> > > Konrad
On Mon, 03 Jun 2024 11:17:17 +0300, Abel Vesa wrote: > The CRD board doesn't have the 4th SMB2360 PMIC populated while the QCP > does. So enable it on QCP only. This fixes the warning for the missing > PMIC on CRD as well. > > Applied, thanks! [1/1] arm64: dts: qcom: x1e80100: Disable the SMB2360 4th instance by default commit: 0e500122d0e9932f985ba13b9f66e191ff604ffd Best regards,
diff --git a/arch/arm64/boot/dts/qcom/x1e80100-pmics.dtsi b/arch/arm64/boot/dts/qcom/x1e80100-pmics.dtsi index a5662d39fdff..e34e70922cd3 100644 --- a/arch/arm64/boot/dts/qcom/x1e80100-pmics.dtsi +++ b/arch/arm64/boot/dts/qcom/x1e80100-pmics.dtsi @@ -522,6 +522,8 @@ smb2360_3: pmic@c { #address-cells = <1>; #size-cells = <0>; + status = "disabled"; + smb2360_3_eusb2_repeater: phy@fd00 { compatible = "qcom,smb2360-eusb2-repeater"; reg = <0xfd00>; diff --git a/arch/arm64/boot/dts/qcom/x1e80100-qcp.dts b/arch/arm64/boot/dts/qcom/x1e80100-qcp.dts index a8d0f743228a..1b2caa63859b 100644 --- a/arch/arm64/boot/dts/qcom/x1e80100-qcp.dts +++ b/arch/arm64/boot/dts/qcom/x1e80100-qcp.dts @@ -524,6 +524,10 @@ &remoteproc_cdsp { status = "okay"; }; +&smb2360_3 { + status = "okay"; +}; + &smb2360_0_eusb2_repeater { vdd18-supply = <&vreg_l3d_1p8>; vdd3-supply = <&vreg_l2b_3p0>;
The CRD board doesn't have the 4th SMB2360 PMIC populated while the QCP does. So enable it on QCP only. This fixes the warning for the missing PMIC on CRD as well. Fixes: 2559e61e7ef4 ("arm64: dts: qcom: x1e80100-pmics: Add the missing PMICs") Reviewed-by: Johan Hovold <johan+linaro@kernel.org> Tested-by: Johan Hovold <johan+linaro@kernel.org> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Signed-off-by: Abel Vesa <abel.vesa@linaro.org> --- Changes in v2: - Fetched all R-b and T-b tags - Rebased on next-20240603 - Mentioned in the commit message that the patch is fixing a warning w.r.t. missing PMIC on CRD - Link to v1: https://lore.kernel.org/r/20240602-x1e80100-dts-pmics-drop-4th-smb2360-from-crd-v1-1-0adf4dd87a9b@linaro.org --- arch/arm64/boot/dts/qcom/x1e80100-pmics.dtsi | 2 ++ arch/arm64/boot/dts/qcom/x1e80100-qcp.dts | 4 ++++ 2 files changed, 6 insertions(+) --- base-commit: 861a3cb5a2a8480d361fa6708da24747d6fa72fe change-id: 20240602-x1e80100-dts-pmics-drop-4th-smb2360-from-crd-501e8bb8bf95 Best regards,