mbox series

[v2,0/2] Print names of apicv inhibit reasons in traces

Message ID 20240506225321.3440701-1-alejandro.j.jimenez@oracle.com (mailing list archive)
Headers show
Series Print names of apicv inhibit reasons in traces | expand

Message

Alejandro Jimenez May 6, 2024, 10:53 p.m. UTC 
v2:
- Use Sean's implementation/patch from v1: https://lore.kernel.org/all/ZjVQOFLXWrZvoa-Y@google.com/
- Fix typo in commit message (s/inhbit/inhibit).
- Add patch renaming APICV_INHIBIT_REASON_DISABLE to APICV_INHIBIT_REASON_DISABLED.
- Drop Vasant's R-b from v1 since implementation was refined, even though the
general approach and behavior remains the same.

v1: https://lore.kernel.org/all/20240214223554.1033154-1-alejandro.j.jimenez@oracle.com/

Tested on Genoa system. With the proposed changes, the tracepoint output looks
like the following examples:

 qemu-system-x86-7068    [194] .....  1397.647770: kvm_apicv_inhibit_changed: set reason=2, inhibits=0x4 ABSENT
 qemu-system-x86-7068    [003] .....  1397.676703: kvm_apicv_inhibit_changed: cleared reason=2, inhibits=0x0
 qemu-system-x86-7074    [247] .....  1397.701398: kvm_apicv_inhibit_changed: cleared reason=4, inhibits=0x0

 qemu-system-x86-7074    [008] .....  1408.697413: kvm_apicv_inhibit_changed: set reason=8, inhibits=0x100 IRQWIN
 qemu-system-x86-7074    [008] .....  1408.697420: kvm_apicv_inhibit_changed: cleared reason=8, inhibits=0x0

[...]

 qemu-system-x86-7173    [056] .....  1570.541372: kvm_apicv_inhibit_changed: set reason=8, inhibits=0x300 IRQWIN|PIT_REINJ
 qemu-system-x86-7173    [056] .....  1570.541380: kvm_apicv_inhibit_changed: cleared reason=8, inhibits=0x200 PIT_REINJ


Alejandro Jimenez (2):
  KVM: x86: Print names of apicv inhibit reasons in traces
  KVM: x86: Keep consistent naming for APICv/AVIC inhibit reasons

 arch/x86/include/asm/kvm_host.h | 21 ++++++++++++++++++++-
 arch/x86/kvm/svm/svm.h          |  2 +-
 arch/x86/kvm/trace.h            |  9 +++++++--
 arch/x86/kvm/vmx/main.c         |  2 +-
 arch/x86/kvm/x86.c              |  6 +++++-
 5 files changed, 34 insertions(+), 6 deletions(-)


base-commit: d91a9cc16417b8247213a0144a1f0fd61dc855dd

Comments

Sean Christopherson June 4, 2024, 11:29 p.m. UTC | #1 
On Mon, 06 May 2024 22:53:19 +0000, Alejandro Jimenez wrote:
> v2:
> - Use Sean's implementation/patch from v1: https://lore.kernel.org/all/ZjVQOFLXWrZvoa-Y@google.com/
> - Fix typo in commit message (s/inhbit/inhibit).
> - Add patch renaming APICV_INHIBIT_REASON_DISABLE to APICV_INHIBIT_REASON_DISABLED.
> - Drop Vasant's R-b from v1 since implementation was refined, even though the
> general approach and behavior remains the same.
> 
> [...]

Applied to kvm-x86 misc, thanks!

[1/2] KVM: x86: Print names of apicv inhibit reasons in traces
      https://github.com/kvm-x86/linux/commit/8b5bf6b80eb3
[2/2] KVM: x86: Keep consistent naming for APICv/AVIC inhibit reasons
      https://github.com/kvm-x86/linux/commit/f9979c52eb02

--
https://github.com/kvm-x86/linux/tree/next
Sean Christopherson June 5, 2024, 3:10 p.m. UTC | #2 
On Tue, Jun 04, 2024, Sean Christopherson wrote:
> On Mon, 06 May 2024 22:53:19 +0000, Alejandro Jimenez wrote:
> > v2:
> > - Use Sean's implementation/patch from v1: https://lore.kernel.org/all/ZjVQOFLXWrZvoa-Y@google.com/
> > - Fix typo in commit message (s/inhbit/inhibit).
> > - Add patch renaming APICV_INHIBIT_REASON_DISABLE to APICV_INHIBIT_REASON_DISABLED.
> > - Drop Vasant's R-b from v1 since implementation was refined, even though the
> > general approach and behavior remains the same.
> > 
> > [...]
> 
> Applied to kvm-x86 misc, thanks!
> 
> [1/2] KVM: x86: Print names of apicv inhibit reasons in traces
>       https://github.com/kvm-x86/linux/commit/8b5bf6b80eb3
> [2/2] KVM: x86: Keep consistent naming for APICv/AVIC inhibit reasons
>       https://github.com/kvm-x86/linux/commit/f9979c52eb02

FYI, hashes changed due to dropping an unrelated commit.

[1/2] KVM: x86: Print names of apicv inhibit reasons in traces
      https://github.com/kvm-x86/linux/commit/69148ccec679
[2/2] KVM: x86: Keep consistent naming for APICv/AVIC inhibit reasons
      https://github.com/kvm-x86/linux/commit/f992572120fb