| Message ID | 20240605071553.1365557-2-edumazet@google.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | c34506406dd5cfb352f8c53bb6a1b9535c0905dd |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | tcp: small code reorg | expand |
Date: Wed, 5 Jun 2024 07:15:51 +0000 From: Eric Dumazet <edumazet@google.com> > In reqsk_free(), use DEBUG_NET_WARN_ON_ONCE() > instead of WARN_ON_ONCE() for a condition which never fired. > > In reqsk_put() directly call __reqsk_free(), there is no > point checking rsk_refcnt again right after a transition to zero. > > Signed-off-by: Eric Dumazet <edumazet@google.com> Reviewed-by: Kuniyuki Iwashima <kuniyu@amazon.com>
diff --git a/include/net/request_sock.h b/include/net/request_sock.h index ebcb8896bffc..a8f82216c628 100644 --- a/include/net/request_sock.h +++ b/include/net/request_sock.h @@ -172,14 +172,14 @@ static inline void __reqsk_free(struct request_sock *req) static inline void reqsk_free(struct request_sock *req) { - WARN_ON_ONCE(refcount_read(&req->rsk_refcnt) != 0); + DEBUG_NET_WARN_ON_ONCE(refcount_read(&req->rsk_refcnt) != 0); __reqsk_free(req); } static inline void reqsk_put(struct request_sock *req) { if (refcount_dec_and_test(&req->rsk_refcnt)) - reqsk_free(req); + __reqsk_free(req); } /*
In reqsk_free(), use DEBUG_NET_WARN_ON_ONCE() instead of WARN_ON_ONCE() for a condition which never fired. In reqsk_put() directly call __reqsk_free(), there is no point checking rsk_refcnt again right after a transition to zero. Signed-off-by: Eric Dumazet <edumazet@google.com> --- include/net/request_sock.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)