[v1,0/3] spi: bitbang: Clean up the driver

Message

Andy Shevchenko May 17, 2024, 7:40 p.m. UTC

A few cleanups to the driver. No functional change intended.

Andy Shevchenko (3):
  spi: bitbang: Use typedef for txrx_*() callbacks
  spi: bitbang: Convert unsigned to unsigned int
  spi: bitbang: Replace hard coded number of SPI modes

 drivers/spi/spi-bitbang.c       | 73 ++++++++++++---------------------
 include/linux/spi/spi_bitbang.h |  7 ++--
 2 files changed, 31 insertions(+), 49 deletions(-)

Comments

Andy Shevchenko June 5, 2024, 9:07 p.m. UTC | #1

On Fri, May 17, 2024 at 10:40:19PM +0300, Andy Shevchenko wrote:
> A few cleanups to the driver. No functional change intended.
> 
> Andy Shevchenko (3):
>   spi: bitbang: Use typedef for txrx_*() callbacks
>   spi: bitbang: Convert unsigned to unsigned int
>   spi: bitbang: Replace hard coded number of SPI modes

Hmm... It's not the first time I noticed that the series
(despite even appearing in the CI, but then disappearing)
left abandoned without clear feedback,

Should I do something here?

Mark Brown June 5, 2024, 9:21 p.m. UTC | #2

On Thu, Jun 06, 2024 at 12:07:14AM +0300, Andy Shevchenko wrote:
> On Fri, May 17, 2024 at 10:40:19PM +0300, Andy Shevchenko wrote:
> > A few cleanups to the driver. No functional change intended.
> > 
> > Andy Shevchenko (3):
> >   spi: bitbang: Use typedef for txrx_*() callbacks
> >   spi: bitbang: Convert unsigned to unsigned int
> >   spi: bitbang: Replace hard coded number of SPI modes
> 
> Hmm... It's not the first time I noticed that the series
> (despite even appearing in the CI, but then disappearing)
> left abandoned without clear feedback,

> Should I do something here?

Please don't send content free pings and please allow a reasonable time
for review.  People get busy, go on holiday, attend conferences and so 
on so unless there is some reason for urgency (like critical bug fixes)
please allow at least a couple of weeks for review.  If there have been
review comments then people may be waiting for those to be addressed.

Sending content free pings adds to the mail volume (if they are seen at
all) which is often the problem and since they can't be reviewed
directly if something has gone wrong you'll have to resend the patches
anyway, so sending again is generally a better approach though there are
some other maintainers who like them - if in doubt look at how patches
for the subsystem are normally handled.

Andy Shevchenko June 6, 2024, 10:47 a.m. UTC | #3

On Wed, Jun 05, 2024 at 10:21:35PM +0100, Mark Brown wrote:
> On Thu, Jun 06, 2024 at 12:07:14AM +0300, Andy Shevchenko wrote:
> > On Fri, May 17, 2024 at 10:40:19PM +0300, Andy Shevchenko wrote:
> > > A few cleanups to the driver. No functional change intended.
> > > 
> > > Andy Shevchenko (3):
> > >   spi: bitbang: Use typedef for txrx_*() callbacks
> > >   spi: bitbang: Convert unsigned to unsigned int
> > >   spi: bitbang: Replace hard coded number of SPI modes
> > 
> > Hmm... It's not the first time I noticed that the series
> > (despite even appearing in the CI, but then disappearing)
> > left abandoned without clear feedback,
> 
> > Should I do something here?

Okay, it's just an announce is missing.
I found them in the repository. Thanks!