diff mbox series

[v6,03/26] drm/i915/display: Take panel replay into account in vsc sdp unpacking

Message ID 20240605102553.187309-4-jouni.hogander@intel.com (mailing list archive)
State New, archived
Headers show
Series Panel Replay eDP support | expand

Commit Message

Hogander, Jouni June 5, 2024, 10:25 a.m. UTC
Currently intel_dp_vsc_sdp_unpack is not taking into account Panel Replay
vsc sdp. Fix this by adding vsc sdp revision 0x6 and length 0x10 into
intel_dp_vsc_sdp_unpack

Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
---
 drivers/gpu/drm/i915/display/intel_dp.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

Comments

Manna, Animesh June 6, 2024, 9:59 a.m. UTC | #1
> -----Original Message-----
> From: Hogander, Jouni <jouni.hogander@intel.com>
> Sent: Wednesday, June 5, 2024 3:56 PM
> To: intel-gfx@lists.freedesktop.org
> Cc: Manna, Animesh <animesh.manna@intel.com>; Kahola, Mika
> <mika.kahola@intel.com>; Hogander, Jouni <jouni.hogander@intel.com>
> Subject: [PATCH v6 03/26] drm/i915/display: Take panel replay into account
> in vsc sdp unpacking
> 
> Currently intel_dp_vsc_sdp_unpack is not taking into account Panel Replay
> vsc sdp. Fix this by adding vsc sdp revision 0x6 and length 0x10 into
> intel_dp_vsc_sdp_unpack
> 
> Signed-off-by: Jouni Högander <jouni.hogander@intel.com>

Reviewed-by: Animesh Manna <animesh.manna@intel.com>

> ---
>  drivers/gpu/drm/i915/display/intel_dp.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c
> b/drivers/gpu/drm/i915/display/intel_dp.c
> index fd054e16850d..286119eb77f8 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> @@ -4438,7 +4438,8 @@ static int intel_dp_vsc_sdp_unpack(struct
> drm_dp_vsc_sdp *vsc,
>  	vsc->length = sdp->sdp_header.HB3;
> 
>  	if ((sdp->sdp_header.HB2 == 0x2 && sdp->sdp_header.HB3 == 0x8)
> ||
> -	    (sdp->sdp_header.HB2 == 0x4 && sdp->sdp_header.HB3 == 0xe)) {
> +	    (sdp->sdp_header.HB2 == 0x4 && sdp->sdp_header.HB3 == 0xe) ||
> +	    (sdp->sdp_header.HB2 == 0x6 && sdp->sdp_header.HB3 == 0x10))
> {
>  		/*
>  		 * - HB2 = 0x2, HB3 = 0x8
>  		 *   VSC SDP supporting 3D stereo + PSR
> @@ -4446,6 +4447,8 @@ static int intel_dp_vsc_sdp_unpack(struct
> drm_dp_vsc_sdp *vsc,
>  		 *   VSC SDP supporting 3D stereo + PSR2 with Y-coordinate of
>  		 *   first scan line of the SU region (applies to eDP v1.4b
>  		 *   and higher).
> +		 * - HB2 = 0x6, HB3 = 0x10
> +		 *   VSC SDP supporting 3D stereo + Panel Replay.
>  		 */
>  		return 0;
>  	} else if (sdp->sdp_header.HB2 == 0x5 && sdp->sdp_header.HB3 ==
> 0x13) {
> --
> 2.34.1
diff mbox series

Patch

diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index fd054e16850d..286119eb77f8 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -4438,7 +4438,8 @@  static int intel_dp_vsc_sdp_unpack(struct drm_dp_vsc_sdp *vsc,
 	vsc->length = sdp->sdp_header.HB3;
 
 	if ((sdp->sdp_header.HB2 == 0x2 && sdp->sdp_header.HB3 == 0x8) ||
-	    (sdp->sdp_header.HB2 == 0x4 && sdp->sdp_header.HB3 == 0xe)) {
+	    (sdp->sdp_header.HB2 == 0x4 && sdp->sdp_header.HB3 == 0xe) ||
+	    (sdp->sdp_header.HB2 == 0x6 && sdp->sdp_header.HB3 == 0x10)) {
 		/*
 		 * - HB2 = 0x2, HB3 = 0x8
 		 *   VSC SDP supporting 3D stereo + PSR
@@ -4446,6 +4447,8 @@  static int intel_dp_vsc_sdp_unpack(struct drm_dp_vsc_sdp *vsc,
 		 *   VSC SDP supporting 3D stereo + PSR2 with Y-coordinate of
 		 *   first scan line of the SU region (applies to eDP v1.4b
 		 *   and higher).
+		 * - HB2 = 0x6, HB3 = 0x10
+		 *   VSC SDP supporting 3D stereo + Panel Replay.
 		 */
 		return 0;
 	} else if (sdp->sdp_header.HB2 == 0x5 && sdp->sdp_header.HB3 == 0x13) {