diff mbox series

[3/5] arm64: dts: qcom: sdx75: add missing qlink_logging reserved memory for mpss

Message ID 20240606143858.4026-4-quic_nainmeht@quicinc.com (mailing list archive)
State Superseded
Headers show
Series Add MPSS remoteproc support for SDX75 | expand

Commit Message

Naina Mehta June 6, 2024, 2:38 p.m. UTC
The qlink_logging memory region is also used by the modem firmware,
add it to reserved memory regions.
Also split MPSS DSM region into 2 separate regions.

Signed-off-by: Naina Mehta <quic_nainmeht@quicinc.com>
---
 arch/arm64/boot/dts/qcom/sdx75.dtsi | 17 +++++++++++++----
 1 file changed, 13 insertions(+), 4 deletions(-)

Comments

Krzysztof Kozlowski June 6, 2024, 2:50 p.m. UTC | #1
On 06/06/2024 16:38, Naina Mehta wrote:
> The qlink_logging memory region is also used by the modem firmware,
> add it to reserved memory regions.
> Also split MPSS DSM region into 2 separate regions.
> 
> Signed-off-by: Naina Mehta <quic_nainmeht@quicinc.com>
> ---
>  arch/arm64/boot/dts/qcom/sdx75.dtsi | 17 +++++++++++++----
>  1 file changed, 13 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sdx75.dtsi b/arch/arm64/boot/dts/qcom/sdx75.dtsi
> index 9b93f6501d55..9349b1c4e196 100644
> --- a/arch/arm64/boot/dts/qcom/sdx75.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdx75.dtsi
> @@ -366,7 +366,12 @@
>  			no-map;
>  		};
>  
> -		qdss_mem: qdss@88800000 {
> +		qdss_mem: qdss@88500000 {
> +			reg = <0x0 0x88500000 0x0 0x300000>;
> +			no-map;
> +		};
> +
> +		qlink_logging_mem: qlink_logging@88800000 {

Sorry, no downstream code.

Please follow DTS coding style - no underscores in node names. This
applies to all work sent upstream.



Best regards,
Krzysztof
Naina Mehta June 7, 2024, 6:51 a.m. UTC | #2
On 6/6/2024 8:20 PM, Krzysztof Kozlowski wrote:
> On 06/06/2024 16:38, Naina Mehta wrote:
>> The qlink_logging memory region is also used by the modem firmware,
>> add it to reserved memory regions.
>> Also split MPSS DSM region into 2 separate regions.
>>
>> Signed-off-by: Naina Mehta <quic_nainmeht@quicinc.com>
>> ---
>>   arch/arm64/boot/dts/qcom/sdx75.dtsi | 17 +++++++++++++----
>>   1 file changed, 13 insertions(+), 4 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sdx75.dtsi b/arch/arm64/boot/dts/qcom/sdx75.dtsi
>> index 9b93f6501d55..9349b1c4e196 100644
>> --- a/arch/arm64/boot/dts/qcom/sdx75.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sdx75.dtsi
>> @@ -366,7 +366,12 @@
>>   			no-map;
>>   		};
>>   
>> -		qdss_mem: qdss@88800000 {
>> +		qdss_mem: qdss@88500000 {
>> +			reg = <0x0 0x88500000 0x0 0x300000>;
>> +			no-map;
>> +		};
>> +
>> +		qlink_logging_mem: qlink_logging@88800000 {
> 
> Sorry, no downstream code.
> 
> Please follow DTS coding style - no underscores in node names. This
> applies to all work sent upstream.
> 

Thanks for pointing this out. I will update in next revision.

Regards,
Naina

> 
> 
> Best regards,
> Krzysztof
>
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/qcom/sdx75.dtsi b/arch/arm64/boot/dts/qcom/sdx75.dtsi
index 9b93f6501d55..9349b1c4e196 100644
--- a/arch/arm64/boot/dts/qcom/sdx75.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdx75.dtsi
@@ -366,7 +366,12 @@ 
 			no-map;
 		};
 
-		qdss_mem: qdss@88800000 {
+		qdss_mem: qdss@88500000 {
+			reg = <0x0 0x88500000 0x0 0x300000>;
+			no-map;
+		};
+
+		qlink_logging_mem: qlink_logging@88800000 {
 			reg = <0x0 0x88800000 0x0 0x300000>;
 			no-map;
 		};
@@ -377,18 +382,22 @@ 
 			no-map;
 		};
 
-		mpss_dsmharq_mem: mpss-dsmharq@88f00000 {
-			reg = <0x0 0x88f00000 0x0 0x5080000>;
+		mpss_dsm_mem_2: mpss-dsmharq-2@88f00000 {
+			reg = <0x0 0x88f00000 0x0 0x2500000>;
 			no-map;
 		};
 
+		mpss_dsm_mem: mpss-dsmharq@8b400000 {
+			reg = <0x0 0x8b400000 0x0 0x2b80000>;
+		};
+
 		q6_mpss_dtb_mem: q6-mpss-dtb@8df80000 {
 			reg = <0x0 0x8df80000 0x0 0x80000>;
 			no-map;
 		};
 
 		mpssadsp_mem: mpssadsp@8e000000 {
-			reg = <0x0 0x8e000000 0x0 0xf400000>;
+			reg = <0x0 0x8e000000 0x0 0xf100000>;
 			no-map;
 		};