| Message ID | de4aa3b67aa3b61e5a5de5eb7402a08d6a9cbf6a.1717514638.git.jani.nikula@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/i915: finish the job of removing implicit dev_priv | expand |
On Tue, Jun 04, 2024 at 06:25:58PM +0300, Jani Nikula wrote: > Avoid the implicit dev_priv local variable use, and pass dev_priv > explicitly to the _PIPEB_FLIPCOUNT_G4X register macro. > > Signed-off-by: Jani Nikula <jani.nikula@intel.com> > --- > drivers/gpu/drm/i915/i915_reg.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h > index f5367ec58400..fb1dc6f5e903 100644 > --- a/drivers/gpu/drm/i915/i915_reg.h > +++ b/drivers/gpu/drm/i915/i915_reg.h > @@ -2302,7 +2302,7 @@ > #define _PIPEBFRAMEHIGH 0x71040 > #define _PIPEBFRAMEPIXEL 0x71044 > #define _PIPEB_FRMCOUNT_G4X(dev_priv) (DISPLAY_MMIO_BASE(dev_priv) + 0x71040) > -#define _PIPEB_FLIPCOUNT_G4X (DISPLAY_MMIO_BASE(dev_priv) + 0x71044) > +#define _PIPEB_FLIPCOUNT_G4X(dev_priv) (DISPLAY_MMIO_BASE(dev_priv) + 0x71044) G4X? and many cases... starting to have a feeling that those are really not going to be used so soon and should be removed. but, again, up to you: Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com> > > > /* Display B control */ > -- > 2.39.2 >
diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h index f5367ec58400..fb1dc6f5e903 100644 --- a/drivers/gpu/drm/i915/i915_reg.h +++ b/drivers/gpu/drm/i915/i915_reg.h @@ -2302,7 +2302,7 @@ #define _PIPEBFRAMEHIGH 0x71040 #define _PIPEBFRAMEPIXEL 0x71044 #define _PIPEB_FRMCOUNT_G4X(dev_priv) (DISPLAY_MMIO_BASE(dev_priv) + 0x71040) -#define _PIPEB_FLIPCOUNT_G4X (DISPLAY_MMIO_BASE(dev_priv) + 0x71044) +#define _PIPEB_FLIPCOUNT_G4X(dev_priv) (DISPLAY_MMIO_BASE(dev_priv) + 0x71044) /* Display B control */
Avoid the implicit dev_priv local variable use, and pass dev_priv explicitly to the _PIPEB_FLIPCOUNT_G4X register macro. Signed-off-by: Jani Nikula <jani.nikula@intel.com> --- drivers/gpu/drm/i915/i915_reg.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)