[v5] dt-bindings: ufs: qcom,ufs: drop source clock entries

Commit Message

Dmitry Baryshkov May 28, 2024, 1:36 p.m. UTC

There is no need to mention and/or to touch in any way the intermediate
(source) clocks. Drop them from MSM8996 UFSHCD schema, making it follow
the example lead by all other platforms.

Reviewed-by: Krzysztof Kozlowski <[e-mail]>
Acked-by: Manivannan Sadhasivam <[e-mail]>
Signed-off-by: Dmitry Baryshkov <[e-mail]>
---
Changes in v5:
- Rebased on top of linux-next
- Dropped arm64 / DT patches applied by Bjorn
- Link to v4: https://lore.kernel.org/r/[e-mail]

Changes in v4:
- Rebased on top of linux-next to resolve conflict with UFS schema
  changes
- Link to v3: https://lore.kernel.org/r/[e-mail]

Changes in v3:
- dropped the patch conflicting with Yassine's patch that got accepted
- Cc stable on the UFS change (Manivannan)
- Fixed typos in the commit message (Manivannan)
- Link to v2: https://lore.kernel.org/r/[e-mail]

Changes in v2:
- Dropped patches adding RX_SYMBOL_1_CLK, MSM8996 uses single lane
  (Krzysztof).
- Link to v1: https://lore.kernel.org/r/[e-mail]
---
 Documentation/devicetree/bindings/ufs/qcom,ufs.yaml | 12 +++++-------
 1 file changed, 5 insertions(+), 7 deletions(-)


---
base-commit: 652f7c84aa3d99568e9e57d74b08cad927adba4e
change-id: 20240209-msm8996-fix-ufs-f80ae6d4d8cf

Best regards,

Comments

Rob Herring (Arm) June 6, 2024, 8:54 p.m. UTC | #1

On Tue, 28 May 2024 16:36:48 +0300, Dmitry Baryshkov wrote:
> There is no need to mention and/or to touch in any way the intermediate
> (source) clocks. Drop them from MSM8996 UFSHCD schema, making it follow
> the example lead by all other platforms.
> 
> Reviewed-by: Krzysztof Kozlowski <[e-mail]>
> Acked-by: Manivannan Sadhasivam <[e-mail]>
> Signed-off-by: Dmitry Baryshkov <[e-mail]>
> ---
> Changes in v5:
> - Rebased on top of linux-next
> - Dropped arm64 / DT patches applied by Bjorn
> - Link to v4: https://lore.kernel.org/r/[e-mail]
> 
> Changes in v4:
> - Rebased on top of linux-next to resolve conflict with UFS schema
>   changes
> - Link to v3: https://lore.kernel.org/r/[e-mail]
> 
> Changes in v3:
> - dropped the patch conflicting with Yassine's patch that got accepted
> - Cc stable on the UFS change (Manivannan)
> - Fixed typos in the commit message (Manivannan)
> - Link to v2: https://lore.kernel.org/r/[e-mail]
> 
> Changes in v2:
> - Dropped patches adding RX_SYMBOL_1_CLK, MSM8996 uses single lane
>   (Krzysztof).
> - Link to v1: https://lore.kernel.org/r/[e-mail]
> ---
>  Documentation/devicetree/bindings/ufs/qcom,ufs.yaml | 12 +++++-------
>  1 file changed, 5 insertions(+), 7 deletions(-)
> 

Applied, thanks!

Patch

diff --git a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
index cd3680dc002f..25a5edeea164 100644
--- a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
+++ b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
@@ -46,11 +46,11 @@  properties:
 
   clocks:
     minItems: 7
-    maxItems: 11
+    maxItems: 9
 
   clock-names:
     minItems: 7
-    maxItems: 11
+    maxItems: 9
 
   dma-coherent: true
 
@@ -217,16 +217,14 @@  allOf:
     then:
       properties:
         clocks:
-          minItems: 11
-          maxItems: 11
+          minItems: 9
+          maxItems: 9
         clock-names:
           items:
-            - const: core_clk_src
             - const: core_clk
             - const: bus_clk
             - const: bus_aggr_clk
             - const: iface_clk
-            - const: core_clk_unipro_src
             - const: core_clk_unipro
             - const: core_clk_ice
             - const: ref_clk
@@ -287,7 +285,7 @@  allOf:
           maxItems: 2
         clocks:
           minItems: 7
-          maxItems: 11
+          maxItems: 9
 
 unevaluatedProperties: false