| Message ID | 2747286.mvXUDI8C0e@yuki-p (mailing list archive) |
|---|---|
| State | New |
| Delegated to: | Jiri Kosina |
| Headers | show |
| Series | HID: Ignore battery for ELAN touchscreens 2F2C and 4116 on ASUS Zenbook 14 OLED (2023) and ASUS Zenbook Pro 14 OLED (2023) | expand |
Hello! Is the whitespace damage still an issue on the latest email? On Tuesday, June 4, 2024 11:57:44 AM GMT+2 you wrote: > The touchscreen reports a battery status of 0% and jumps to 1% when a > stylus is used. > The device ID was added and the battery ignore quirk was enabled for it. > > Signed-off-by: Louis Dalibard <ontake@ontake.dev> > --- > drivers/hid/hid-ids.h | 2 ++ > drivers/hid/hid-input.c | 4 ++++ > 2 files changed, 6 insertions(+) > > diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h > index 61d2a21affa2..72d56ee7ce1b 100644 > --- a/drivers/hid/hid-ids.h > +++ b/drivers/hid/hid-ids.h > @@ -423,6 +423,8 @@ > #define I2C_DEVICE_ID_HP_SPECTRE_X360_13_AW0020NG 0x29DF > #define I2C_DEVICE_ID_ASUS_TP420IA_TOUCHSCREEN 0x2BC8 > #define I2C_DEVICE_ID_ASUS_GV301RA_TOUCHSCREEN 0x2C82 > +#define I2C_DEVICE_ID_ASUS_UX3402_TOUCHSCREEN 0x2F2C > +#define I2C_DEVICE_ID_ASUS_UX6404_TOUCHSCREEN 0x4116 > #define USB_DEVICE_ID_ASUS_UX550VE_TOUCHSCREEN 0x2544 > #define USB_DEVICE_ID_ASUS_UX550_TOUCHSCREEN 0x2706 > #define I2C_DEVICE_ID_SURFACE_GO_TOUCHSCREEN 0x261A > diff --git a/drivers/hid/hid-input.c b/drivers/hid/hid-input.c > index e03d300d2bac..0d21590e2d2c 100644 > --- a/drivers/hid/hid-input.c > +++ b/drivers/hid/hid-input.c > @@ -377,6 +377,10 @@ static const struct hid_device_id > hid_battery_quirks[] = { > HID_BATTERY_QUIRK_IGNORE }, > { HID_I2C_DEVICE(USB_VENDOR_ID_ELAN, > I2C_DEVICE_ID_ASUS_GV301RA_TOUCHSCREEN), > HID_BATTERY_QUIRK_IGNORE }, > + { HID_I2C_DEVICE(USB_VENDOR_ID_ELAN, > I2C_DEVICE_ID_ASUS_UX3402_TOUCHSCREEN), + HID_BATTERY_QUIRK_IGNORE }, > + { HID_I2C_DEVICE(USB_VENDOR_ID_ELAN, > I2C_DEVICE_ID_ASUS_UX6404_TOUCHSCREEN), + HID_BATTERY_QUIRK_IGNORE }, > { HID_USB_DEVICE(USB_VENDOR_ID_ELAN, > USB_DEVICE_ID_ASUS_UX550_TOUCHSCREEN), > HID_BATTERY_QUIRK_IGNORE }, > { HID_USB_DEVICE(USB_VENDOR_ID_ELAN, > USB_DEVICE_ID_ASUS_UX550VE_TOUCHSCREEN),
On Fri, 7 Jun 2024, Louis Dalibard wrote: > Hello! > Is the whitespace damage still an issue on the latest email? Hi Louis, unfortunately it is. All of the incarnations look pretty much the same :)
diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h index 61d2a21affa2..72d56ee7ce1b 100644 --- a/drivers/hid/hid-ids.h +++ b/drivers/hid/hid-ids.h @@ -423,6 +423,8 @@ #define I2C_DEVICE_ID_HP_SPECTRE_X360_13_AW0020NG 0x29DF #define I2C_DEVICE_ID_ASUS_TP420IA_TOUCHSCREEN 0x2BC8 #define I2C_DEVICE_ID_ASUS_GV301RA_TOUCHSCREEN 0x2C82 +#define I2C_DEVICE_ID_ASUS_UX3402_TOUCHSCREEN 0x2F2C +#define I2C_DEVICE_ID_ASUS_UX6404_TOUCHSCREEN 0x4116 #define USB_DEVICE_ID_ASUS_UX550VE_TOUCHSCREEN 0x2544 #define USB_DEVICE_ID_ASUS_UX550_TOUCHSCREEN 0x2706 #define I2C_DEVICE_ID_SURFACE_GO_TOUCHSCREEN 0x261A diff --git a/drivers/hid/hid-input.c b/drivers/hid/hid-input.c index e03d300d2bac..0d21590e2d2c 100644 --- a/drivers/hid/hid-input.c +++ b/drivers/hid/hid-input.c @@ -377,6 +377,10 @@ static const struct hid_device_id hid_battery_quirks[] = { HID_BATTERY_QUIRK_IGNORE }, { HID_I2C_DEVICE(USB_VENDOR_ID_ELAN, I2C_DEVICE_ID_ASUS_GV301RA_TOUCHSCREEN), HID_BATTERY_QUIRK_IGNORE }, + { HID_I2C_DEVICE(USB_VENDOR_ID_ELAN, I2C_DEVICE_ID_ASUS_UX3402_TOUCHSCREEN), + HID_BATTERY_QUIRK_IGNORE }, + { HID_I2C_DEVICE(USB_VENDOR_ID_ELAN, I2C_DEVICE_ID_ASUS_UX6404_TOUCHSCREEN), + HID_BATTERY_QUIRK_IGNORE }, { HID_USB_DEVICE(USB_VENDOR_ID_ELAN,
The touchscreen reports a battery status of 0% and jumps to 1% when a stylus is used. The device ID was added and the battery ignore quirk was enabled for it. Signed-off-by: Louis Dalibard <ontake@ontake.dev> --- drivers/hid/hid-ids.h | 2 ++ drivers/hid/hid-input.c | 4 ++++ 2 files changed, 6 insertions(+) USB_DEVICE_ID_ASUS_UX550_TOUCHSCREEN), HID_BATTERY_QUIRK_IGNORE }, { HID_USB_DEVICE(USB_VENDOR_ID_ELAN, USB_DEVICE_ID_ASUS_UX550VE_TOUCHSCREEN),