diff mbox series

[net-next,01/13] dt-bindings: net: dsa: lantiq_gswip: Add missing phy-mode and fixed-link

Message ID 20240606085234.565551-2-ms@dev.tdt.de (mailing list archive)
State Superseded
Delegated to: Netdev Maintainers
Headers show
Series net: dsa: lantiq_gswip: code improvements | expand

Checks

Context Check Description
netdev/series_format success Posting correctly formatted
netdev/tree_selection success Clearly marked for net-next
netdev/ynl success Generated files up to date; no warnings/errors; no diff in generated;
netdev/fixes_present success Fixes tag not required for -next series
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 8 this patch: 8
netdev/build_tools success No tools touched, skip
netdev/cc_maintainers success CCed 11 of 11 maintainers
netdev/build_clang success Errors and warnings before: 8 this patch: 8
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/deprecated_api success None detected
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success No Fixes tag
netdev/build_allmodconfig_warn success Errors and warnings before: 8 this patch: 8
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 13 lines checked
netdev/build_clang_rust success No Rust files in patch. Skipping build
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0
netdev/contest success net-next-2024-06-07--09-00 (tests: 1041)

Commit Message

Martin Schiller June 6, 2024, 8:52 a.m. UTC 
From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>

The CPU port has to specify a phy-mode and either a phy or a fixed-link.
Since GSWIP is connected using a SoC internal protocol there's no PHY
involved. Add phy-mode = "internal" and a fixed-link to describe the
communication between the PMAC (Ethernet controller) and GSWIP switch.

Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
---
 Documentation/devicetree/bindings/net/dsa/lantiq-gswip.txt | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Vladimir Oltean June 7, 2024, 10:59 a.m. UTC | #1 
On Thu, Jun 06, 2024 at 10:52:22AM +0200, Martin Schiller wrote:
> From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> 
> The CPU port has to specify a phy-mode and either a phy or a fixed-link.
> Since GSWIP is connected using a SoC internal protocol there's no PHY
> involved. Add phy-mode = "internal" and a fixed-link to describe the
> communication between the PMAC (Ethernet controller) and GSWIP switch.
> 
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> ---

Reviewed-by: Vladimir Oltean <olteanv@gmail.com>

Long-term it would be good to also see a dt-schema conversion.
Krzysztof Kozlowski June 10, 2024, 8:55 a.m. UTC | #2 
On 06/06/2024 10:52, Martin Schiller wrote:
> From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> 
> The CPU port has to specify a phy-mode and either a phy or a fixed-link.
> Since GSWIP is connected using a SoC internal protocol there's no PHY
> involved. Add phy-mode = "internal" and a fixed-link to describe the
> communication between the PMAC (Ethernet controller) and GSWIP switch.

You did nothing in the binding to describe them. You only extended
example, which does not really matter if there is DTS with it.

Best regards,
Krzysztof
Martin Schiller June 10, 2024, 9:07 a.m. UTC | #3 
On 2024-06-10 10:55, Krzysztof Kozlowski wrote:
> On 06/06/2024 10:52, Martin Schiller wrote:
>> From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
>> 
>> The CPU port has to specify a phy-mode and either a phy or a 
>> fixed-link.
>> Since GSWIP is connected using a SoC internal protocol there's no PHY
>> involved. Add phy-mode = "internal" and a fixed-link to describe the
>> communication between the PMAC (Ethernet controller) and GSWIP switch.
> 
> You did nothing in the binding to describe them. You only extended
> example, which does not really matter if there is DTS with it.
> 
> Best regards,
> Krzysztof

OK, so I'll update subject and commit message to signal that we only
update the example code.
Rob Herring June 10, 2024, 10:05 p.m. UTC | #4 
On Mon, Jun 10, 2024 at 11:07:15AM +0200, Martin Schiller wrote:
> On 2024-06-10 10:55, Krzysztof Kozlowski wrote:
> > On 06/06/2024 10:52, Martin Schiller wrote:
> > > From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> > > 
> > > The CPU port has to specify a phy-mode and either a phy or a
> > > fixed-link.
> > > Since GSWIP is connected using a SoC internal protocol there's no PHY
> > > involved. Add phy-mode = "internal" and a fixed-link to describe the
> > > communication between the PMAC (Ethernet controller) and GSWIP switch.
> > 
> > You did nothing in the binding to describe them. You only extended
> > example, which does not really matter if there is DTS with it.
> > 
> > Best regards,
> > Krzysztof
> 
> OK, so I'll update subject and commit message to signal that we only
> update the example code.

Either convert it or leave it alone. If you are worried about users' DTs 
being wrong due to copying a bad example, then you should care enough to 
do the conversion. Given the errors we find in examples, it's likely 
not the only problem.

Rob
Martin Schiller June 11, 2024, 11:12 a.m. UTC | #5 
On 2024-06-11 00:05, Rob Herring wrote:
> On Mon, Jun 10, 2024 at 11:07:15AM +0200, Martin Schiller wrote:
>> On 2024-06-10 10:55, Krzysztof Kozlowski wrote:
>> > On 06/06/2024 10:52, Martin Schiller wrote:
>> > > From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
>> > >
>> > > The CPU port has to specify a phy-mode and either a phy or a
>> > > fixed-link.
>> > > Since GSWIP is connected using a SoC internal protocol there's no PHY
>> > > involved. Add phy-mode = "internal" and a fixed-link to describe the
>> > > communication between the PMAC (Ethernet controller) and GSWIP switch.
>> >
>> > You did nothing in the binding to describe them. You only extended
>> > example, which does not really matter if there is DTS with it.
>> >
>> > Best regards,
>> > Krzysztof
>> 
>> OK, so I'll update subject and commit message to signal that we only
>> update the example code.
> 
> Either convert it or leave it alone. If you are worried about users' 
> DTs
> being wrong due to copying a bad example, then you should care enough 
> to
> do the conversion. Given the errors we find in examples, it's likely
> not the only problem.
> 
> Rob

Then I will convert the bindings to the new YAML format and send another
update of this patch-set.

Thanks,
Martin
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/net/dsa/lantiq-gswip.txt b/Documentation/devicetree/bindings/net/dsa/lantiq-gswip.txt
index 8bb1eff21cb1..e81ba0e0da0f 100644
--- a/Documentation/devicetree/bindings/net/dsa/lantiq-gswip.txt
+++ b/Documentation/devicetree/bindings/net/dsa/lantiq-gswip.txt
@@ -96,7 +96,13 @@  switch@e108000 {
 
 		port@6 {
 			reg = <0x6>;
+			phy-mode = "internal";
 			ethernet = <&eth0>;
+
+			fixed-link {
+				speed = <1000>;
+				full-duplex;
+			};
 		};
 	};