| Message ID | acb442e38544bc5c60dcaa61d56ca1e6bbbc82fe.1715823610.git.tanggeliang@kylinos.cn (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [bpf-next] selftests/bpf: Enable INET_XFRM_TUNNEL in config | expand |
On 5/16/24 3:41 AM, Geliang Tang wrote: > From: Geliang Tang <tanggeliang@kylinos.cn> > > The kconfigs CONFIG_INET_XFRM_TUNNEL and CONFIG_INET6_XFRM_TUNNEL are > needed by test_tunnel tests. This patch enables them together with the > dependent kconfigs CONFIG_INET_IPCOMP and CONFIG_INET6_IPCOMP. > > Signed-off-by: Geliang Tang <tanggeliang@kylinos.cn> > --- > tools/testing/selftests/bpf/config | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/tools/testing/selftests/bpf/config b/tools/testing/selftests/bpf/config > index eeabd798bc3a..8aa56e6bdac1 100644 > --- a/tools/testing/selftests/bpf/config > +++ b/tools/testing/selftests/bpf/config > @@ -95,3 +95,7 @@ CONFIG_XDP_SOCKETS=y > CONFIG_XFRM_INTERFACE=y > CONFIG_TCP_CONG_DCTCP=y > CONFIG_TCP_CONG_BBR=y > +CONFIG_INET_IPCOMP=y > +CONFIG_INET_XFRM_TUNNEL=y > +CONFIG_INET6_IPCOMP=y > +CONFIG_INET6_XFRM_TUNNEL=y > [ +Ilya ] Looks like this triggers a boot hang on s390x : https://github.com/kernel-patches/bpf/actions/runs/9215175853/job/25353574288
On Fri, 2024-05-24 at 18:27 +0200, Daniel Borkmann wrote: > On 5/16/24 3:41 AM, Geliang Tang wrote: > > From: Geliang Tang <tanggeliang@kylinos.cn> > > > > The kconfigs CONFIG_INET_XFRM_TUNNEL and CONFIG_INET6_XFRM_TUNNEL > > are > > needed by test_tunnel tests. This patch enables them together with > > the > > dependent kconfigs CONFIG_INET_IPCOMP and CONFIG_INET6_IPCOMP. > > > > Signed-off-by: Geliang Tang <tanggeliang@kylinos.cn> > > --- > > tools/testing/selftests/bpf/config | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/tools/testing/selftests/bpf/config > > b/tools/testing/selftests/bpf/config > > index eeabd798bc3a..8aa56e6bdac1 100644 > > --- a/tools/testing/selftests/bpf/config > > +++ b/tools/testing/selftests/bpf/config > > @@ -95,3 +95,7 @@ CONFIG_XDP_SOCKETS=y > > CONFIG_XFRM_INTERFACE=y > > CONFIG_TCP_CONG_DCTCP=y > > CONFIG_TCP_CONG_BBR=y > > +CONFIG_INET_IPCOMP=y > > +CONFIG_INET_XFRM_TUNNEL=y > > +CONFIG_INET6_IPCOMP=y > > +CONFIG_INET6_XFRM_TUNNEL=y > > > > [ +Ilya ] > > Looks like this triggers a boot hang on s390x : > > https://github.com/kernel-patches/bpf/actions/runs/9215175853/job/25353574288 Hi, I could not reproduce this neither with vmtest nor with my own build, and it doesn't look related. I'm not exactly sure what could cause d_alloc_parallel() to hang, but apparently the CI is using a different vmtest script, which uses 9p to mount root - perhaps there is a deadlock in 9p? Can someone retrigger the build to see if the issue persists? Best regards, Ilya
On Wed, May 29, 2024 at 02:01:06AM +0200, Ilya Leoshkevich wrote: > On Fri, 2024-05-24 at 18:27 +0200, Daniel Borkmann wrote: > > On 5/16/24 3:41 AM, Geliang Tang wrote: > > > From: Geliang Tang <tanggeliang@kylinos.cn> > > > > > > The kconfigs CONFIG_INET_XFRM_TUNNEL and CONFIG_INET6_XFRM_TUNNEL > > > are > > > needed by test_tunnel tests. This patch enables them together with > > > the > > > dependent kconfigs CONFIG_INET_IPCOMP and CONFIG_INET6_IPCOMP. > > > > > > Signed-off-by: Geliang Tang <tanggeliang@kylinos.cn> > > > --- > > > tools/testing/selftests/bpf/config | 4 ++++ > > > 1 file changed, 4 insertions(+) > > > > > > diff --git a/tools/testing/selftests/bpf/config > > > b/tools/testing/selftests/bpf/config > > > index eeabd798bc3a..8aa56e6bdac1 100644 > > > --- a/tools/testing/selftests/bpf/config > > > +++ b/tools/testing/selftests/bpf/config > > > @@ -95,3 +95,7 @@ CONFIG_XDP_SOCKETS=y > > > CONFIG_XFRM_INTERFACE=y > > > CONFIG_TCP_CONG_DCTCP=y > > > CONFIG_TCP_CONG_BBR=y > > > +CONFIG_INET_IPCOMP=y > > > +CONFIG_INET_XFRM_TUNNEL=y > > > +CONFIG_INET6_IPCOMP=y > > > +CONFIG_INET6_XFRM_TUNNEL=y > > > > > > > [ +Ilya ] > > > > Looks like this triggers a boot hang on s390x : > > > > https://github.com/kernel-patches/bpf/actions/runs/9215175853/job/25353574288 > > Hi, > > I could not reproduce this neither with vmtest nor with my own build, > and it doesn't look related. > > I'm not exactly sure what could cause d_alloc_parallel() to hang, but > apparently the CI is using a different vmtest script, which uses 9p to > mount root - perhaps there is a deadlock in 9p? > > Can someone retrigger the build to see if the issue persists? Hi Daniel, Ilya, I'll resend this patch together with another fix for test_tunnel soon. At that time, CI can be triggered again. I changed this patch status as "Superseded" on patchwork. Thanks, -Geliang > > Best regards, > Ilya
diff --git a/tools/testing/selftests/bpf/config b/tools/testing/selftests/bpf/config index eeabd798bc3a..8aa56e6bdac1 100644 --- a/tools/testing/selftests/bpf/config +++ b/tools/testing/selftests/bpf/config @@ -95,3 +95,7 @@ CONFIG_XDP_SOCKETS=y CONFIG_XFRM_INTERFACE=y CONFIG_TCP_CONG_DCTCP=y CONFIG_TCP_CONG_BBR=y +CONFIG_INET_IPCOMP=y +CONFIG_INET_XFRM_TUNNEL=y +CONFIG_INET6_IPCOMP=y +CONFIG_INET6_XFRM_TUNNEL=y