mbox series

[5.10.y-cip,00/19] Add suspend to RAM support for pin and IA55 IRQ controllers

Message ID 20240607140711.2497286-1-claudiu.beznea.uj@bp.renesas.com (mailing list archive)
Headers show
Series Add suspend to RAM support for pin and IA55 IRQ controllers | expand

Message

Claudiu Beznea June 7, 2024, 2:06 p.m. UTC
From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>

Hi,

Series adds suspend to RAM support for PIN and IA55 IRQ controller.
Support is needed for RZ/G3S SoC.

Along with it pin controller and IA55 interrupt controller drivers
were updated with enhancements.

Series is split as follows:
- patch 01:      add clock and reset support for IA55 IRQ controller on
                 RZ/G3S
- patches 02-08: update the pin controller driver with fixes for spurious
                 interrupts when pin controller interrupt lines are routed
                 to IA55 IRQ controller
- patch 09:      add suspend to RAM support for pinctrl driver
- patch 10:      add suspend to RAM support for IA55 IRQ controler
- patches 11-14: documentation patches
- patches 15-19: update the device tree with IA55, gpio keys, PSCI
                 support

Thank you,
Claudiu Beznea

Biju Das (3):
  pinctrl: renesas: rzg2l: Configure interrupt input mode
  pinctrl: renesas: rzg2l: Simplify rzg2l_gpio_irq_{en,dis}able()
  pinctrl: renesas: rzg2l: Avoid configuring ISEL in
    gpio_irq_{en,dis}able*(

Claudiu Beznea (7):
  clk: renesas: r9a08g045: Add IA55 pclk and its reset
  pinctrl: renesas: rzg2l: Add suspend/resume support
  irqchip/renesas-rzg2l: Add support for suspend to RAM
  dt-bindings: interrupt-controller: renesas,rzg2l-irqc: Document RZ/G3S
  arm64: dts: renesas: r9a08g045: Add IA55 interrupt controller node
  arm64: dts: renesas: rzg3s-smarc: Add gpio keys
  arm64: dts: renesas: r9a08g045: Add PSCI support

Johannes Berg (1):
  bitfield: add FIELD_PREP_CONST()

Lad Prabhakar (8):
  pinctrl: renesas: rzg2l: Improve code for readability
  pinctrl: renesas: rzg2l: Include pinmap in RZG2L_GPIO_PORT_PACK()
    macro
  pinctrl: renesas: pinctrl-rzg2l: Add the missing port pins P19 to P28
  dt-bindings: interrupt-controller: renesas,rzg2l-irqc: Document RZ/V2L
    SoC
  dt-bindings: interrupt-controller: renesas,rzg2l-irqc: Update
    description for '#interrupt-cells' property
  dt-bindings: interrupt-controller: renesas,rzg2l-irqc: Document
    RZ/G2UL SoC
  arm64: dts: renesas: r9a08g045: Add missing interrupts to IRQC node
  arm64: dts: renesas: rzg2l: Add missing interrupts to IRQC nodes

 .../renesas,rzg2l-irqc.yaml                   | 236 ++++--
 arch/arm64/boot/dts/renesas/r9a07g043u.dtsi   |  12 +-
 arch/arm64/boot/dts/renesas/r9a07g044.dtsi    |  22 +-
 arch/arm64/boot/dts/renesas/r9a07g054.dtsi    |  22 +-
 arch/arm64/boot/dts/renesas/r9a08g045.dtsi    |  77 ++
 arch/arm64/boot/dts/renesas/rzg3s-smarc.dtsi  |  53 ++
 arch/riscv/boot/dts/renesas/r9a07g043f.dtsi   |   4 +
 drivers/clk/renesas/r9a08g045-cpg.c           |   3 +
 drivers/irqchip/irq-renesas-rzg2l.c           |  70 +-
 drivers/pinctrl/renesas/pinctrl-rzg2l.c       | 777 ++++++++++++++++--
 include/linux/bitfield.h                      |  26 +
 11 files changed, 1157 insertions(+), 145 deletions(-)

Comments

Pavel Machek June 10, 2024, 9:26 p.m. UTC | #1
Hi!

> Series adds suspend to RAM support for PIN and IA55 IRQ controller.
> Support is needed for RZ/G3S SoC.
> 
> Along with it pin controller and IA55 interrupt controller drivers
> were updated with enhancements.
> 
> Series is split as follows:
> - patch 01:      add clock and reset support for IA55 IRQ controller on
>                  RZ/G3S
> - patches 02-08: update the pin controller driver with fixes for spurious
>                  interrupts when pin controller interrupt lines are routed
>                  to IA55 IRQ controller
> - patch 09:      add suspend to RAM support for pinctrl driver
> - patch 10:      add suspend to RAM support for IA55 IRQ controler
> - patches 11-14: documentation patches
> - patches 15-19: update the device tree with IA55, gpio keys, PSCI
>                  support

Thanks for the series. It looks pretty similar to 6.1 version.

I noticed "pinctrl: renesas: rzg2l: Select GPIOLIB_IRQCHIP and
IRQ_DOMAIN_HIERARCHY" is missing from this version, should we have it,
too?

I can apply it if it passes testing and if there are no other
comments.

Thanks and best regards,
								Pavel
Pavel Machek June 11, 2024, 12:39 p.m. UTC | #2
Hi!

> Series adds suspend to RAM support for PIN and IA55 IRQ controller.
> Support is needed for RZ/G3S SoC.
> 
> Along with it pin controller and IA55 interrupt controller drivers
> were updated with enhancements.
> 
> Series is split as follows:
> - patch 01:      add clock and reset support for IA55 IRQ controller on
>                  RZ/G3S
> - patches 02-08: update the pin controller driver with fixes for spurious
>                  interrupts when pin controller interrupt lines are routed
>                  to IA55 IRQ controller
> - patch 09:      add suspend to RAM support for pinctrl driver
> - patch 10:      add suspend to RAM support for IA55 IRQ controler
> - patches 11-14: documentation patches
> - patches 15-19: update the device tree with IA55, gpio keys, PSCI
>                  support

Thank you, applied.

Best regards,
								Pavel
Claudiu Beznea June 11, 2024, 1:19 p.m. UTC | #3
Hi, Pavel,

On 11.06.2024 00:26, Pavel Machek wrote:
> Hi!
> 
>> Series adds suspend to RAM support for PIN and IA55 IRQ controller.
>> Support is needed for RZ/G3S SoC.
>>
>> Along with it pin controller and IA55 interrupt controller drivers
>> were updated with enhancements.
>>
>> Series is split as follows:
>> - patch 01:      add clock and reset support for IA55 IRQ controller on
>>                  RZ/G3S
>> - patches 02-08: update the pin controller driver with fixes for spurious
>>                  interrupts when pin controller interrupt lines are routed
>>                  to IA55 IRQ controller
>> - patch 09:      add suspend to RAM support for pinctrl driver
>> - patch 10:      add suspend to RAM support for IA55 IRQ controler
>> - patches 11-14: documentation patches
>> - patches 15-19: update the device tree with IA55, gpio keys, PSCI
>>                  support
> 
> Thanks for the series. It looks pretty similar to 6.1 version.
> 
> I noticed "pinctrl: renesas: rzg2l: Select GPIOLIB_IRQCHIP and
> IRQ_DOMAIN_HIERARCHY" is missing from this version, should we have it,
> too?

This is already integrated in v5.10.y-cip:

https://git.kernel.org/pub/scm/linux/kernel/git/cip/linux-cip.git/commit/drivers/pinctrl/renesas/Kconfig?h=linux-5.10.y-cip&id=c51f1776f4a935aa01c96286f93553c46e252daf

Thank you,
Claudiu Beznea

> 
> I can apply it if it passes testing and if there are no other
> comments.
> 
> Thanks and best regards,
> 								Pavel