mbox series

[v2,md-6.11,00/12] md: refacotor and some fixes related to sync_thread

Message ID 20240611132251.1967786-1-yukuai1@huaweicloud.com (mailing list archive)
Headers show
Series md: refacotor and some fixes related to sync_thread | expand

Message

Yu Kuai June 11, 2024, 1:22 p.m. UTC
From: Yu Kuai <yukuai3@huawei.com>

Changes from v1:
 - respin on the top of md-6.11 branch

Changes from RFC:
 - fix some typos;
 - add patch 7 to prevent some mdadm tests failure;
 - add patch 12 to fix BUG_ON() panic by mdadm test 07revert-grow;

Yu Kuai (12):
  md: rearrange recovery_flags
  md: add a new enum type sync_action
  md: add new helpers for sync_action
  md: factor out helper to start reshape from action_store()
  md: replace sysfs api sync_action with new helpers
  md: remove parameter check_seq for stop_sync_thread()
  md: don't fail action_store() if sync_thread is not registered
  md: use new helers in md_do_sync()
  md: replace last_sync_action with new enum type
  md: factor out helpers for different sync_action in md_do_sync()
  md: pass in max_sectors for pers->sync_request()
  md/raid5: avoid BUG_ON() while continue reshape after reassembling

 drivers/md/dm-raid.c |   2 +-
 drivers/md/md.c      | 437 ++++++++++++++++++++++++++-----------------
 drivers/md/md.h      | 124 +++++++++---
 drivers/md/raid1.c   |   5 +-
 drivers/md/raid10.c  |   8 +-
 drivers/md/raid5.c   |  23 ++-
 6 files changed, 388 insertions(+), 211 deletions(-)

Comments

Paul Menzel June 11, 2024, 2:10 p.m. UTC | #1
Dear Yu,


Thank you for your series.


Am 11.06.24 um 15:22 schrieb Yu Kuai:
> From: Yu Kuai <yukuai3@huawei.com>

It’d be great if you wrote a small summary, what the same fixes are, are 
what patches are that.

Nit: Small typo in the summary/title: refacotor → refactor.

> Changes from v1:
>   - respin on the top of md-6.11 branch
> 
> Changes from RFC:
>   - fix some typos;
>   - add patch 7 to prevent some mdadm tests failure;
>   - add patch 12 to fix BUG_ON() panic by mdadm test 07revert-grow;
> 
> Yu Kuai (12):
>    md: rearrange recovery_flags
>    md: add a new enum type sync_action
>    md: add new helpers for sync_action
>    md: factor out helper to start reshape from action_store()
>    md: replace sysfs api sync_action with new helpers
>    md: remove parameter check_seq for stop_sync_thread()
>    md: don't fail action_store() if sync_thread is not registered
>    md: use new helers in md_do_sync()

hel*p*ers

>    md: replace last_sync_action with new enum type
>    md: factor out helpers for different sync_action in md_do_sync()
>    md: pass in max_sectors for pers->sync_request()
>    md/raid5: avoid BUG_ON() while continue reshape after reassembling
> 
>   drivers/md/dm-raid.c |   2 +-
>   drivers/md/md.c      | 437 ++++++++++++++++++++++++++-----------------
>   drivers/md/md.h      | 124 +++++++++---
>   drivers/md/raid1.c   |   5 +-
>   drivers/md/raid10.c  |   8 +-
>   drivers/md/raid5.c   |  23 ++-
>   6 files changed, 388 insertions(+), 211 deletions(-)


Kind regards,

Paul
Song Liu June 12, 2024, 4:34 p.m. UTC | #2
On Tue, Jun 11, 2024 at 7:11 AM Paul Menzel <pmenzel@molgen.mpg.de> wrote:
[...]
> >    md: use new helers in md_do_sync()
>
> hel*p*ers
>

Fixed this typo and applied to md-6.11. Thanks!

Song