| Message ID | 20240612011221.822-1-naoki@radxa.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2] arm64: dts: rockchip: make poweroff(8) work on Radxa ROCK 5A | expand |
Hello Fukami, On 2024-06-12 03:12, FUKAUMI Naoki wrote: > Designate the RK806 PMIC on the Radxa ROCK 5A as the system power > controller, so the board shuts down properly on poweroff(8). > > Fixes: 75fdcbc8f4c1 ("arm64: dts: rockchip: add PMIC to rock-5a") > > Signed-off-by: FUKAUMI Naoki <naoki@radxa.com> > Reviewed-by: Dragan Simic <dsimic@manjaro.org> Thanks for the v2. Just another small suggestion, the tags above should go like this, with no empty lines between them: Fixes: ... Reviewed-by: ... Signed-off-by: ... > Changes in v2: > - remove an empty line above "system-power-controller;" > - reword commit message > - add R-b tag > --- > arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts > b/arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts > index b070955627be..3b9a349362db 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts > @@ -394,6 +394,7 @@ pmic@0 { > pinctrl-0 = <&pmic_pins>, <&rk806_dvs1_null>, > <&rk806_dvs2_null>, <&rk806_dvs3_null>; > spi-max-frequency = <1000000>; > + system-power-controller; > > vcc1-supply = <&vcc5v0_sys>; > vcc2-supply = <&vcc5v0_sys>;
diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts b/arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts index b070955627be..3b9a349362db 100644 --- a/arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts +++ b/arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts @@ -394,6 +394,7 @@ pmic@0 { pinctrl-0 = <&pmic_pins>, <&rk806_dvs1_null>, <&rk806_dvs2_null>, <&rk806_dvs3_null>; spi-max-frequency = <1000000>; + system-power-controller; vcc1-supply = <&vcc5v0_sys>; vcc2-supply = <&vcc5v0_sys>;
Designate the RK806 PMIC on the Radxa ROCK 5A as the system power controller, so the board shuts down properly on poweroff(8). Fixes: 75fdcbc8f4c1 ("arm64: dts: rockchip: add PMIC to rock-5a") Signed-off-by: FUKAUMI Naoki <naoki@radxa.com> Reviewed-by: Dragan Simic <dsimic@manjaro.org> Changes in v2: - remove an empty line above "system-power-controller;" - reword commit message - add R-b tag --- arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts | 1 + 1 file changed, 1 insertion(+)