| Message ID | 20240611-ls_waring_esdhc-v4-0-d0d8a5b3f3cb@nxp.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | arm64: dts: convert fsl,esdhc.txt to yaml and fix layerscape dts warning | expand |
Hello Frank, Please see my comment below. On 2024-06-11 18:01, Frank Li wrote: > Start from v4 because fsl.esdhc.txt to yaml already sent out as v3. > > Change from v3 to v4 > - Add dts warning fixes > - Add mmc-spi-slot's voltage range fix, (not sure why it apply to > layserscape's dts file. > - clock-frequency is not required property > - add dma-conherence: true in binding doc > > Now only "bit-endian" proptery warning left. > > Signed-off-by: Frank Li <Frank.Li@nxp.com> > --- > Frank Li (8): > dt-bindings: mmc: Convert fsl-esdhc.txt to yaml > dt-bindings: mmc: mmc-spi-slot: Change voltage-ranges to > uint32-matrix > arm64: dts: ls1012a: Chang node name from 'esdhc' to 'mmc' > arm64: dts: ls1043a: Chang node name from 'esdhc' to 'mmc' > arm64: dts: ls1046a: Chang node name from 'esdhc' to 'mmc' > arm64: dts: ls1088a: Chang node name from 'esdhc' to 'mmc' > arm64: dts: ls208ax: Chang node name from 'esdhc' to 'mmc' > arm64: dts: lx2160a: Chang node name from 'esdhc' to 'mmc' s/Chang /Change / -- in all patch subjects > .../devicetree/bindings/mmc/fsl,esdhc.yaml | 105 > +++++++++++++++++++++ > .../devicetree/bindings/mmc/fsl-esdhc.txt | 52 ---------- > .../devicetree/bindings/mmc/mmc-spi-slot.yaml | 17 ++-- > arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi | 4 +- > arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi | 2 +- > arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi | 2 +- > arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi | 2 +- > arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi | 2 +- > arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi | 8 +- > 9 files changed, 125 insertions(+), 69 deletions(-) > --- > base-commit: d35b2284e966c0bef3e2182a5c5ea02177dd32e4 > change-id: 20240610-ls_waring_esdhc-93136a5dd794 > > Best regards, > --- > Frank Li <Frank.Li@nxp.com>
On Tue, Jun 11, 2024 at 12:01:45PM -0400, Frank Li wrote: > Start from v4 because fsl.esdhc.txt to yaml already sent out as v3. > > Change from v3 to v4 > - Add dts warning fixes > - Add mmc-spi-slot's voltage range fix, (not sure why it apply to > layserscape's dts file. > - clock-frequency is not required property > - add dma-conherence: true in binding doc > > Now only "bit-endian" proptery warning left. > > Signed-off-by: Frank Li <Frank.Li@nxp.com> > --- > Frank Li (8): > dt-bindings: mmc: Convert fsl-esdhc.txt to yaml > dt-bindings: mmc: mmc-spi-slot: Change voltage-ranges to uint32-matrix > arm64: dts: ls1012a: Chang node name from 'esdhc' to 'mmc' > arm64: dts: ls1043a: Chang node name from 'esdhc' to 'mmc' > arm64: dts: ls1046a: Chang node name from 'esdhc' to 'mmc' > arm64: dts: ls1088a: Chang node name from 'esdhc' to 'mmc' > arm64: dts: ls208ax: Chang node name from 'esdhc' to 'mmc' > arm64: dts: lx2160a: Chang node name from 'esdhc' to 'mmc' It is all the same change to the same maintainer, so these can be just one patch. Then you just have 1 typo to fix. Rob
On 11/06/2024 22:16, Rob Herring wrote: > On Tue, Jun 11, 2024 at 12:01:45PM -0400, Frank Li wrote: >> Start from v4 because fsl.esdhc.txt to yaml already sent out as v3. >> >> Change from v3 to v4 >> - Add dts warning fixes >> - Add mmc-spi-slot's voltage range fix, (not sure why it apply to >> layserscape's dts file. >> - clock-frequency is not required property >> - add dma-conherence: true in binding doc >> >> Now only "bit-endian" proptery warning left. >> >> Signed-off-by: Frank Li <Frank.Li@nxp.com> >> --- >> Frank Li (8): >> dt-bindings: mmc: Convert fsl-esdhc.txt to yaml >> dt-bindings: mmc: mmc-spi-slot: Change voltage-ranges to uint32-matrix > >> arm64: dts: ls1012a: Chang node name from 'esdhc' to 'mmc' >> arm64: dts: ls1043a: Chang node name from 'esdhc' to 'mmc' >> arm64: dts: ls1046a: Chang node name from 'esdhc' to 'mmc' >> arm64: dts: ls1088a: Chang node name from 'esdhc' to 'mmc' >> arm64: dts: ls208ax: Chang node name from 'esdhc' to 'mmc' >> arm64: dts: lx2160a: Chang node name from 'esdhc' to 'mmc' > > It is all the same change to the same maintainer, so these can be just > one patch. Then you just have 1 typo to fix. Yeah, considering that this is trivial node name alignment, so rather style issue. Best regards, Krzysztof
Start from v4 because fsl.esdhc.txt to yaml already sent out as v3. Change from v3 to v4 - Add dts warning fixes - Add mmc-spi-slot's voltage range fix, (not sure why it apply to layserscape's dts file. - clock-frequency is not required property - add dma-conherence: true in binding doc Now only "bit-endian" proptery warning left. Signed-off-by: Frank Li <Frank.Li@nxp.com> --- Frank Li (8): dt-bindings: mmc: Convert fsl-esdhc.txt to yaml dt-bindings: mmc: mmc-spi-slot: Change voltage-ranges to uint32-matrix arm64: dts: ls1012a: Chang node name from 'esdhc' to 'mmc' arm64: dts: ls1043a: Chang node name from 'esdhc' to 'mmc' arm64: dts: ls1046a: Chang node name from 'esdhc' to 'mmc' arm64: dts: ls1088a: Chang node name from 'esdhc' to 'mmc' arm64: dts: ls208ax: Chang node name from 'esdhc' to 'mmc' arm64: dts: lx2160a: Chang node name from 'esdhc' to 'mmc' .../devicetree/bindings/mmc/fsl,esdhc.yaml | 105 +++++++++++++++++++++ .../devicetree/bindings/mmc/fsl-esdhc.txt | 52 ---------- .../devicetree/bindings/mmc/mmc-spi-slot.yaml | 17 ++-- arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi | 4 +- arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi | 2 +- arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi | 2 +- arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi | 2 +- arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi | 2 +- arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi | 8 +- 9 files changed, 125 insertions(+), 69 deletions(-) --- base-commit: d35b2284e966c0bef3e2182a5c5ea02177dd32e4 change-id: 20240610-ls_waring_esdhc-93136a5dd794 Best regards, --- Frank Li <Frank.Li@nxp.com>