diff mbox series

soc: add missing MODULE_DESCRIPTION() macros

Message ID 20240611-md-drivers-soc-v1-1-8f0fc9fff234@quicinc.com (mailing list archive)
State New, archived
Headers show
Series soc: add missing MODULE_DESCRIPTION() macros | expand

Commit Message

Jeff Johnson June 12, 2024, 5:50 a.m. UTC 
With ARCH=x86, make allmodconfig && make W=1 C=1 reports:
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/soc/imx/soc-imx8m.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/soc/ixp4xx/ixp4xx-qmgr.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/soc/ixp4xx/ixp4xx-npe.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/soc/mediatek/mtk-cmdq-helper.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/soc/amlogic/meson-clk-measure.o

Add the missing invocations of the MODULE_DESCRIPTION() macro.

Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
---
This is the last of the issues that I see in the soc directory
---
 drivers/soc/amlogic/meson-clk-measure.c | 1 +
 drivers/soc/imx/soc-imx8m.c             | 1 +
 drivers/soc/ixp4xx/ixp4xx-npe.c         | 1 +
 drivers/soc/ixp4xx/ixp4xx-qmgr.c        | 1 +
 drivers/soc/mediatek/mtk-cmdq-helper.c  | 1 +
 5 files changed, 5 insertions(+)


---
base-commit: 83a7eefedc9b56fe7bfeff13b6c7356688ffa670
change-id: 20240611-md-drivers-soc-1780b1939627

Comments

Neil Armstrong June 12, 2024, 7:58 a.m. UTC | #1 
On 12/06/2024 07:50, Jeff Johnson wrote:
> With ARCH=x86, make allmodconfig && make W=1 C=1 reports:
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/soc/imx/soc-imx8m.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/soc/ixp4xx/ixp4xx-qmgr.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/soc/ixp4xx/ixp4xx-npe.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/soc/mediatek/mtk-cmdq-helper.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/soc/amlogic/meson-clk-measure.o
> 
> Add the missing invocations of the MODULE_DESCRIPTION() macro.
> 
> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
> ---
> This is the last of the issues that I see in the soc directory
> ---
>   drivers/soc/amlogic/meson-clk-measure.c | 1 +

Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org> # for amlogic/meson-clk-measure.c

>   drivers/soc/imx/soc-imx8m.c             | 1 +
>   drivers/soc/ixp4xx/ixp4xx-npe.c         | 1 +
>   drivers/soc/ixp4xx/ixp4xx-qmgr.c        | 1 +
>   drivers/soc/mediatek/mtk-cmdq-helper.c  | 1 +
>   5 files changed, 5 insertions(+)
> 
> diff --git a/drivers/soc/amlogic/meson-clk-measure.c b/drivers/soc/amlogic/meson-clk-measure.c
> index 3f3039600357..a6453ffeb753 100644
> --- a/drivers/soc/amlogic/meson-clk-measure.c
> +++ b/drivers/soc/amlogic/meson-clk-measure.c
> @@ -688,4 +688,5 @@ static struct platform_driver meson_msr_driver = {
>   	},
>   };
>   module_platform_driver(meson_msr_driver);
> +MODULE_DESCRIPTION("Amlogic Meson SoC Clock Measure driver");
>   MODULE_LICENSE("GPL v2");
> diff --git a/drivers/soc/imx/soc-imx8m.c b/drivers/soc/imx/soc-imx8m.c
> index ec87d9d878f3..fe111bae38c8 100644
> --- a/drivers/soc/imx/soc-imx8m.c
> +++ b/drivers/soc/imx/soc-imx8m.c
> @@ -252,4 +252,5 @@ static int __init imx8_soc_init(void)
>   	return ret;
>   }
>   device_initcall(imx8_soc_init);
> +MODULE_DESCRIPTION("NXP i.MX8M SoC driver");
>   MODULE_LICENSE("GPL");
> diff --git a/drivers/soc/ixp4xx/ixp4xx-npe.c b/drivers/soc/ixp4xx/ixp4xx-npe.c
> index 35825ee95dff..34a6f187c220 100644
> --- a/drivers/soc/ixp4xx/ixp4xx-npe.c
> +++ b/drivers/soc/ixp4xx/ixp4xx-npe.c
> @@ -764,6 +764,7 @@ static struct platform_driver ixp4xx_npe_driver = {
>   module_platform_driver(ixp4xx_npe_driver);
>   
>   MODULE_AUTHOR("Krzysztof Halasa");
> +MODULE_DESCRIPTION("Intel IXP4xx Network Processor Engine driver");
>   MODULE_LICENSE("GPL v2");
>   MODULE_FIRMWARE(NPE_A_FIRMWARE);
>   MODULE_FIRMWARE(NPE_B_FIRMWARE);
> diff --git a/drivers/soc/ixp4xx/ixp4xx-qmgr.c b/drivers/soc/ixp4xx/ixp4xx-qmgr.c
> index 244ad8d7e80b..cb112f3643e9 100644
> --- a/drivers/soc/ixp4xx/ixp4xx-qmgr.c
> +++ b/drivers/soc/ixp4xx/ixp4xx-qmgr.c
> @@ -465,6 +465,7 @@ static struct platform_driver ixp4xx_qmgr_driver = {
>   };
>   module_platform_driver(ixp4xx_qmgr_driver);
>   
> +MODULE_DESCRIPTION("Intel IXP4xx Queue Manager driver");
>   MODULE_LICENSE("GPL v2");
>   MODULE_AUTHOR("Krzysztof Halasa");
>   
> diff --git a/drivers/soc/mediatek/mtk-cmdq-helper.c b/drivers/soc/mediatek/mtk-cmdq-helper.c
> index 046522664dc1..dd70d4d2bed7 100644
> --- a/drivers/soc/mediatek/mtk-cmdq-helper.c
> +++ b/drivers/soc/mediatek/mtk-cmdq-helper.c
> @@ -526,4 +526,5 @@ int cmdq_pkt_finalize(struct cmdq_pkt *pkt)
>   }
>   EXPORT_SYMBOL(cmdq_pkt_finalize);
>   
> +MODULE_DESCRIPTION("MediaTek Command Queue (CMDQ) driver");
>   MODULE_LICENSE("GPL v2");
> 
> ---
> base-commit: 83a7eefedc9b56fe7bfeff13b6c7356688ffa670
> change-id: 20240611-md-drivers-soc-1780b1939627
>
AngeloGioacchino Del Regno June 12, 2024, 8:12 a.m. UTC | #2 
Il 12/06/24 09:58, Neil Armstrong ha scritto:
> On 12/06/2024 07:50, Jeff Johnson wrote:
>> With ARCH=x86, make allmodconfig && make W=1 C=1 reports:
>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/soc/imx/soc-imx8m.o
>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/soc/ixp4xx/ixp4xx-qmgr.o
>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/soc/ixp4xx/ixp4xx-npe.o
>> WARNING: modpost: missing MODULE_DESCRIPTION() in 
>> drivers/soc/mediatek/mtk-cmdq-helper.o
>> WARNING: modpost: missing MODULE_DESCRIPTION() in 
>> drivers/soc/amlogic/meson-clk-measure.o
>>
>> Add the missing invocations of the MODULE_DESCRIPTION() macro.
>>
>> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
>> ---
>> This is the last of the issues that I see in the soc directory
>> ---
>>   drivers/soc/amlogic/meson-clk-measure.c | 1 +
> 
> Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org> # for 
> amlogic/meson-clk-measure.c
> 
>>   drivers/soc/imx/soc-imx8m.c             | 1 +
>>   drivers/soc/ixp4xx/ixp4xx-npe.c         | 1 +
>>   drivers/soc/ixp4xx/ixp4xx-qmgr.c        | 1 +
>>   drivers/soc/mediatek/mtk-cmdq-helper.c  | 1 +
>>   5 files changed, 5 insertions(+)
>>

MediaTek:
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>

...but I'm not sure how we should apply this? :-)

Either Arnd takes it directly, or you split it per-soc... and I don't have any
preference anyway.

(P.S.: Added Arnd to the loop)

Cheers,
Angelo

>> diff --git a/drivers/soc/mediatek/mtk-cmdq-helper.c 
>> b/drivers/soc/mediatek/mtk-cmdq-helper.c
>> index 046522664dc1..dd70d4d2bed7 100644
>> --- a/drivers/soc/mediatek/mtk-cmdq-helper.c
>> +++ b/drivers/soc/mediatek/mtk-cmdq-helper.c
>> @@ -526,4 +526,5 @@ int cmdq_pkt_finalize(struct cmdq_pkt *pkt)
>>   }
>>   EXPORT_SYMBOL(cmdq_pkt_finalize);
>> +MODULE_DESCRIPTION("MediaTek Command Queue (CMDQ) driver");
>>   MODULE_LICENSE("GPL v2");
>>
>> ---
>> base-commit: 83a7eefedc9b56fe7bfeff13b6c7356688ffa670
>> change-id: 20240611-md-drivers-soc-1780b1939627
>>
>
Arnd Bergmann June 12, 2024, 8:18 a.m. UTC | #3 
On Wed, Jun 12, 2024, at 10:12, AngeloGioacchino Del Regno wrote:

> MediaTek:
> Reviewed-by: AngeloGioacchino Del Regno 
> <angelogioacchino.delregno@collabora.com>
>
> ...but I'm not sure how we should apply this? :-)
>
> Either Arnd takes it directly, or you split it per-soc... and I don't have any
> preference anyway.
>
> (P.S.: Added Arnd to the loop)

I think in this case it makes sense to keep it as a single
patch, no need to clutter up the git log with identical
one-line changes.

Jeff, can you send this to soc@kernel.org (cc:lakml)
once you feel you have enough Acks? That will put it
into my patchwork queue.

      Arnd
Jeff Johnson June 12, 2024, 1:56 p.m. UTC | #4 
On 6/12/2024 1:18 AM, Arnd Bergmann wrote:
> On Wed, Jun 12, 2024, at 10:12, AngeloGioacchino Del Regno wrote:
> 
>> MediaTek:
>> Reviewed-by: AngeloGioacchino Del Regno 
>> <angelogioacchino.delregno@collabora.com>
>>
>> ...but I'm not sure how we should apply this? :-)
>>
>> Either Arnd takes it directly, or you split it per-soc... and I don't have any
>> preference anyway.
>>
>> (P.S.: Added Arnd to the loop)
> 
> I think in this case it makes sense to keep it as a single
> patch, no need to clutter up the git log with identical
> one-line changes.
> 
> Jeff, can you send this to soc@kernel.org (cc:lakml)
> once you feel you have enough Acks? That will put it
> into my patchwork queue.
> 
>       Arnd
Will do, thanks Arnd
Shawn Guo June 17, 2024, 2:26 a.m. UTC | #5 
On Tue, Jun 11, 2024 at 10:50:58PM -0700, Jeff Johnson wrote:
> With ARCH=x86, make allmodconfig && make W=1 C=1 reports:
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/soc/imx/soc-imx8m.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/soc/ixp4xx/ixp4xx-qmgr.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/soc/ixp4xx/ixp4xx-npe.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/soc/mediatek/mtk-cmdq-helper.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/soc/amlogic/meson-clk-measure.o
> 
> Add the missing invocations of the MODULE_DESCRIPTION() macro.
> 
> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
> ---
> This is the last of the issues that I see in the soc directory
> ---
>  drivers/soc/amlogic/meson-clk-measure.c | 1 +
>  drivers/soc/imx/soc-imx8m.c             | 1 +

Acked-by: Shawn Guo <shawnguo@kernel.org>

>  drivers/soc/ixp4xx/ixp4xx-npe.c         | 1 +
>  drivers/soc/ixp4xx/ixp4xx-qmgr.c        | 1 +
>  drivers/soc/mediatek/mtk-cmdq-helper.c  | 1 +
>  5 files changed, 5 insertions(+)
Linus Walleij June 18, 2024, 10:25 a.m. UTC | #6 
On Wed, Jun 12, 2024 at 7:51 AM Jeff Johnson <quic_jjohnson@quicinc.com> wrote:

> With ARCH=x86, make allmodconfig && make W=1 C=1 reports:
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/soc/imx/soc-imx8m.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/soc/ixp4xx/ixp4xx-qmgr.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/soc/ixp4xx/ixp4xx-npe.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/soc/mediatek/mtk-cmdq-helper.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/soc/amlogic/meson-clk-measure.o
>
> Add the missing invocations of the MODULE_DESCRIPTION() macro.
>
> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij
diff mbox series

Patch

diff --git a/drivers/soc/amlogic/meson-clk-measure.c b/drivers/soc/amlogic/meson-clk-measure.c
index 3f3039600357..a6453ffeb753 100644
--- a/drivers/soc/amlogic/meson-clk-measure.c
+++ b/drivers/soc/amlogic/meson-clk-measure.c
@@ -688,4 +688,5 @@  static struct platform_driver meson_msr_driver = {
 	},
 };
 module_platform_driver(meson_msr_driver);
+MODULE_DESCRIPTION("Amlogic Meson SoC Clock Measure driver");
 MODULE_LICENSE("GPL v2");
diff --git a/drivers/soc/imx/soc-imx8m.c b/drivers/soc/imx/soc-imx8m.c
index ec87d9d878f3..fe111bae38c8 100644
--- a/drivers/soc/imx/soc-imx8m.c
+++ b/drivers/soc/imx/soc-imx8m.c
@@ -252,4 +252,5 @@  static int __init imx8_soc_init(void)
 	return ret;
 }
 device_initcall(imx8_soc_init);
+MODULE_DESCRIPTION("NXP i.MX8M SoC driver");
 MODULE_LICENSE("GPL");
diff --git a/drivers/soc/ixp4xx/ixp4xx-npe.c b/drivers/soc/ixp4xx/ixp4xx-npe.c
index 35825ee95dff..34a6f187c220 100644
--- a/drivers/soc/ixp4xx/ixp4xx-npe.c
+++ b/drivers/soc/ixp4xx/ixp4xx-npe.c
@@ -764,6 +764,7 @@  static struct platform_driver ixp4xx_npe_driver = {
 module_platform_driver(ixp4xx_npe_driver);
 
 MODULE_AUTHOR("Krzysztof Halasa");
+MODULE_DESCRIPTION("Intel IXP4xx Network Processor Engine driver");
 MODULE_LICENSE("GPL v2");
 MODULE_FIRMWARE(NPE_A_FIRMWARE);
 MODULE_FIRMWARE(NPE_B_FIRMWARE);
diff --git a/drivers/soc/ixp4xx/ixp4xx-qmgr.c b/drivers/soc/ixp4xx/ixp4xx-qmgr.c
index 244ad8d7e80b..cb112f3643e9 100644
--- a/drivers/soc/ixp4xx/ixp4xx-qmgr.c
+++ b/drivers/soc/ixp4xx/ixp4xx-qmgr.c
@@ -465,6 +465,7 @@  static struct platform_driver ixp4xx_qmgr_driver = {
 };
 module_platform_driver(ixp4xx_qmgr_driver);
 
+MODULE_DESCRIPTION("Intel IXP4xx Queue Manager driver");
 MODULE_LICENSE("GPL v2");
 MODULE_AUTHOR("Krzysztof Halasa");
 
diff --git a/drivers/soc/mediatek/mtk-cmdq-helper.c b/drivers/soc/mediatek/mtk-cmdq-helper.c
index 046522664dc1..dd70d4d2bed7 100644
--- a/drivers/soc/mediatek/mtk-cmdq-helper.c
+++ b/drivers/soc/mediatek/mtk-cmdq-helper.c
@@ -526,4 +526,5 @@  int cmdq_pkt_finalize(struct cmdq_pkt *pkt)
 }
 EXPORT_SYMBOL(cmdq_pkt_finalize);
 
+MODULE_DESCRIPTION("MediaTek Command Queue (CMDQ) driver");
 MODULE_LICENSE("GPL v2");