| Message ID | 20240530-fsl-ifc-config-v3-1-1fd2c3d233dd@geanix.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | memory: fsl_ifc: Make FSL_IFC config visible and selectable | expand |
On Thu, 30 May 2024 16:46:36 +0200, Esben Haabendal wrote: > While use of fsl_ifc driver with NAND flash is fine, as the fsl_ifc_nand > driver selects FSL_IFC automatically, we need the CONFIG_FSL_IFC option to > be selectable for platforms using fsl_ifc with NOR flash. > > Applied first patch only, because: 1. I did not get acks for the defconfigs, 2. I do not consider stable defconfig as a hard-bisectability requirment, thus it can break within one release as long as next is not affected. The last statement is kind of not true, because next is now affected, so, Esben, I think you should resend the defconfigs to respective platform maintainers. To recall: arm64 goes via your SoC subarch/platform maintainers, not arm64 maintainers. Applied, thanks! [1/3] memory: fsl_ifc: Make FSL_IFC config visible and selectable https://git.kernel.org/krzk/linux-mem-ctrl/c/9ba0cae3cac07c21c583f9ff194f74043f90d29c Best regards,
diff --git a/drivers/memory/Kconfig b/drivers/memory/Kconfig index 8efdd1f97139..c82d8d8a16ea 100644 --- a/drivers/memory/Kconfig +++ b/drivers/memory/Kconfig @@ -167,7 +167,7 @@ config FSL_CORENET_CF represents a coherency violation. config FSL_IFC - bool "Freescale IFC driver" if COMPILE_TEST + bool "Freescale IFC driver" depends on FSL_SOC || ARCH_LAYERSCAPE || SOC_LS1021A || COMPILE_TEST depends on HAS_IOMEM diff --git a/drivers/mtd/nand/raw/Kconfig b/drivers/mtd/nand/raw/Kconfig index cbf8ae85e1ae..614257308516 100644 --- a/drivers/mtd/nand/raw/Kconfig +++ b/drivers/mtd/nand/raw/Kconfig @@ -234,8 +234,7 @@ config MTD_NAND_FSL_IFC tristate "Freescale IFC NAND controller" depends on FSL_SOC || ARCH_LAYERSCAPE || SOC_LS1021A || COMPILE_TEST depends on HAS_IOMEM - select FSL_IFC - select MEMORY + depends on FSL_IFC help Various Freescale chips e.g P1010, include a NAND Flash machine with built-in hardware ECC capabilities.
While use of fsl_ifc driver with NAND flash is fine, as the fsl_ifc_nand driver selects FSL_IFC automatically, we need the CONFIG_FSL_IFC option to be selectable for platforms using fsl_ifc with NOR flash. Fixes: ea0c0ad6b6eb ("memory: Enable compile testing for most of the drivers") Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com> Signed-off-by: Esben Haabendal <esben@geanix.com> --- drivers/memory/Kconfig | 2 +- drivers/mtd/nand/raw/Kconfig | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-)