diff mbox series

[1/4] btrfs: remove unused Opt enums

Message ID f97d2899f6e701257b3304d553af79d39ea8e2f3.1718082585.git.wqu@suse.com (mailing list archive)
State New, archived
Headers show
Series btrfs: rescue= mount options enhancement to support interrupted csum conversion | expand

Commit Message

Qu Wenruo June 11, 2024, 5:21 a.m. UTC
The following three Opt_* enums are not utilized at all:

- Opt_ignorebadroots
- Opt_ignoredatacsums
- Opt_rescue_all

All those handling are inside "rescue=" mount option groups, and there
is no corresponding token for them, so we can safely remove them.

Signed-off-by: Qu Wenruo <wqu@suse.com>
---
 fs/btrfs/super.c | 3 ---
 1 file changed, 3 deletions(-)

Comments

David Sterba June 12, 2024, 7:31 p.m. UTC | #1
On Tue, Jun 11, 2024 at 02:51:35PM +0930, Qu Wenruo wrote:
> The following three Opt_* enums are not utilized at all:
> 
> - Opt_ignorebadroots
> - Opt_ignoredatacsums
> - Opt_rescue_all

They've been duplicated in the new mount API rewrite and the currently
used enums are in Opt_rescue_* group, like Opt_rescue_parameter_all.

> All those handling are inside "rescue=" mount option groups, and there
> is no corresponding token for them, so we can safely remove them.

Yes.
diff mbox series

Patch

diff --git a/fs/btrfs/super.c b/fs/btrfs/super.c
index 549ad700e49e..902423f2839c 100644
--- a/fs/btrfs/super.c
+++ b/fs/btrfs/super.c
@@ -125,9 +125,6 @@  enum {
 	Opt_rescue,
 	Opt_usebackuproot,
 	Opt_nologreplay,
-	Opt_ignorebadroots,
-	Opt_ignoredatacsums,
-	Opt_rescue_all,
 
 	/* Debugging options */
 	Opt_enospc_debug,