diff mbox series

[RFC,-next,1/7] kernfs: export pr_cont_kernfs_path()

Message ID 20240613014937.1326020-2-yukuai1@huaweicloud.com (mailing list archive)
State New, archived
Headers show
Series blk-iocost: support to build iocost as kernel module | expand

Commit Message

Yu Kuai June 13, 2024, 1:49 a.m. UTC 
From: Yu Kuai <yukuai3@huawei.com>

This helper is used in iocost, prepare to build iocost as kernel module.

Signed-off-by: Yu Kuai <yukuai3@huawei.com>
---
 fs/kernfs/dir.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Greg Kroah-Hartman June 13, 2024, 5:55 a.m. UTC | #1 
On Thu, Jun 13, 2024 at 09:49:31AM +0800, Yu Kuai wrote:
> From: Yu Kuai <yukuai3@huawei.com>
> 
> This helper is used in iocost, prepare to build iocost as kernel module.
> 
> Signed-off-by: Yu Kuai <yukuai3@huawei.com>
> ---
>  fs/kernfs/dir.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/fs/kernfs/dir.c b/fs/kernfs/dir.c
> index 458519e416fe..84ad163a4281 100644
> --- a/fs/kernfs/dir.c
> +++ b/fs/kernfs/dir.c
> @@ -279,6 +279,7 @@ void pr_cont_kernfs_path(struct kernfs_node *kn)
>  out:
>  	spin_unlock_irqrestore(&kernfs_pr_cont_lock, flags);
>  }
> +EXPORT_SYMBOL_GPL(pr_cont_kernfs_path);

This isn't the helper that needs to be exported, it's a include wrapper
that is using this for cgroups.  Please document this much better and
perhaps, just fix up the cgroups code instead?

thanks,

greg k-h
Yu Kuai June 13, 2024, 6:55 a.m. UTC | #2 
Hi,

在 2024/06/13 13:55, Greg KH 写道:
> On Thu, Jun 13, 2024 at 09:49:31AM +0800, Yu Kuai wrote:
>> From: Yu Kuai <yukuai3@huawei.com>
>>
>> This helper is used in iocost, prepare to build iocost as kernel module.
>>
>> Signed-off-by: Yu Kuai <yukuai3@huawei.com>
>> ---
>>   fs/kernfs/dir.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/fs/kernfs/dir.c b/fs/kernfs/dir.c
>> index 458519e416fe..84ad163a4281 100644
>> --- a/fs/kernfs/dir.c
>> +++ b/fs/kernfs/dir.c
>> @@ -279,6 +279,7 @@ void pr_cont_kernfs_path(struct kernfs_node *kn)
>>   out:
>>   	spin_unlock_irqrestore(&kernfs_pr_cont_lock, flags);
>>   }
>> +EXPORT_SYMBOL_GPL(pr_cont_kernfs_path);
> 
> This isn't the helper that needs to be exported, it's a include wrapper
> that is using this for cgroups.  Please document this much better and
> perhaps, just fix up the cgroups code instead?

Thanks for the notice, I didn't think much of this, just export API that
is called from iocost. I'll look into this.

Thanks,
Kuai

> 
> thanks,
> 
> greg k-h
> .
>
diff mbox series

Patch

diff --git a/fs/kernfs/dir.c b/fs/kernfs/dir.c
index 458519e416fe..84ad163a4281 100644
--- a/fs/kernfs/dir.c
+++ b/fs/kernfs/dir.c
@@ -279,6 +279,7 @@  void pr_cont_kernfs_path(struct kernfs_node *kn)
 out:
 	spin_unlock_irqrestore(&kernfs_pr_cont_lock, flags);
 }
+EXPORT_SYMBOL_GPL(pr_cont_kernfs_path);
 
 /**
  * kernfs_get_parent - determine the parent node and pin it