mbox series

[v7,0/6] Mediatek thermal sensor driver support for MT8186 and MT8188

Message ID 20240603-mtk-thermal-mt818x-dtsi-v7-0-8c8e3c7a3643@baylibre.com (mailing list archive)
Headers show
Series Mediatek thermal sensor driver support for MT8186 and MT8188 | expand

Message

Julien Panis June 3, 2024, 10:50 a.m. UTC
This is a bunch of patches to support the MT8186 and MT8188 thermal
sensor configurations.

Since the patches of v3 were applied except those related to the SoC
device trees, this series includes mainly patches for 'mt8186.dtsi'
and 'mt8188.dtsi'. Due to some thermal zone renaming in these 2 device
trees, the related definitions were also renamed in the dt-bindings and
in the driver.

Because of the GPU thermal zone, this series must be applied on top of [1].

[1] https://lore.kernel.org/all/20240527093908.97574-1-angelogioacchino.delregno@collabora.com/

Signed-off-by: Julien Panis <jpanis@baylibre.com>
---
Changes in v7:
- Change commit message for dt-bindings patches.
- Link to v6: https://lore.kernel.org/r/20240529-mtk-thermal-mt818x-dtsi-v6-0-0c71478a9c37@baylibre.com

Changes in v6:
- Reorganize patches related to thermal zone renaming (dt-bindings + driver).
- Add cooling-cells property to GPU node in 'mt8188.dtsi'
- Link to v5: https://lore.kernel.org/r/20240524-mtk-thermal-mt818x-dtsi-v5-0-56f8579820e7@baylibre.com

Changes in v5:
- Rename some thermal zones
  (mfg -> gpu / soc1 -> adsp / soc2 -> vdo / soc3 -> infra).
- Add cooling-device for GPUs.
- Link to v4: https://lore.kernel.org/r/20240521-mtk-thermal-mt818x-dtsi-v4-0-b91ee678411c@baylibre.com

Changes in v4:
- Fix wrong thermal zone names.
- Lower 'polling-delay-passive' values.
- Set 'hysteresis' value to 0 for 'critical' trips.
- Add a 'hot' trip point in between 'passive' and 'critical' trips.
- Link to v3: https://lore.kernel.org/all/20240402032729.2736685-1-nico@fluxnic.net/

Changes in v3:
- use meaningful name for binding index definitions
- reuse LVTS_COEFF_*_MT7988 on MT8186 per reviewer request
- do similarly for MT8188 that now reuses LVTS_COEFF_*_MT8195
- use thermal zone names the svs driver wants
- adjust some DT node names and iospace length
- remove variable .hw_tshut_temp as it is constant across all SOCs
- Link to v2: https://lore.kernel.org/all/20240318212428.3843952-1-nico@fluxnic.net/

Changes in v2:
- renamed CPU cluster thermal zones in DT
- fixed logic to cope with empty controller slots at the beginning
- isolated bindings to their own patches
- added MT8188 default thermal zones
- Link to v1: https://lore.kernel.org/all/20240111223020.3593558-1-nico@fluxnic.net/T/

---
Julien Panis (2):
      dt-bindings: thermal: mediatek: Fix thermal zone definition for MT8186
      dt-bindings: thermal: mediatek: Fix thermal zone definitions for MT8188

Nicolas Pitre (4):
      arm64: dts: mediatek: mt8186: add lvts definitions
      arm64: dts: mediatek: mt8186: add default thermal zones
      arm64: dts: mediatek: mt8188: add lvts definitions
      arm64: dts: mediatek: mt8188: add default thermal zones

 arch/arm64/boot/dts/mediatek/mt8186.dtsi           | 316 ++++++++++++++
 arch/arm64/boot/dts/mediatek/mt8188.dtsi           | 482 +++++++++++++++++++++
 drivers/thermal/mediatek/lvts_thermal.c            |  12 +-
 .../dt-bindings/thermal/mediatek,lvts-thermal.h    |  12 +-
 4 files changed, 810 insertions(+), 12 deletions(-)
---
base-commit: b321abd919e22b240d53329cd726ea7afa8aca98
change-id: 20240520-mtk-thermal-mt818x-dtsi-eca378f9b6a0

Best regards,

Comments

AngeloGioacchino Del Regno June 13, 2024, 8:07 a.m. UTC | #1
On Mon, 03 Jun 2024 12:50:47 +0200, Julien Panis wrote:
> This is a bunch of patches to support the MT8186 and MT8188 thermal
> sensor configurations.
> 
> Since the patches of v3 were applied except those related to the SoC
> device trees, this series includes mainly patches for 'mt8186.dtsi'
> and 'mt8188.dtsi'. Due to some thermal zone renaming in these 2 device
> trees, the related definitions were also renamed in the dt-bindings and
> in the driver.
> 
> [...]

Applied to v6.10-next/dts64, thanks!

[3/6] arm64: dts: mediatek: mt8186: add lvts definitions
      commit: 0c598e50e6c823c1057ddad17c546e368a415d6a
[4/6] arm64: dts: mediatek: mt8186: add default thermal zones
      commit: d7c1bde38bf37a59551cfd52cfdb5bd974b17431
[5/6] arm64: dts: mediatek: mt8188: add lvts definitions
      commit: 7e3e18f2ed40ea9018590b4533fa148954a725bc
[6/6] arm64: dts: mediatek: mt8188: add default thermal zones
      commit: 2f950510411a33d98eea28c22d7880eeb48adb61

Cheers,
Angelo
Julien Panis July 31, 2024, 3:34 p.m. UTC | #2
On 6/13/24 10:07, AngeloGioacchino Del Regno wrote:
> On Mon, 03 Jun 2024 12:50:47 +0200, Julien Panis wrote:
>> This is a bunch of patches to support the MT8186 and MT8188 thermal
>> sensor configurations.
>>
>> Since the patches of v3 were applied except those related to the SoC
>> device trees, this series includes mainly patches for 'mt8186.dtsi'
>> and 'mt8188.dtsi'. Due to some thermal zone renaming in these 2 device
>> trees, the related definitions were also renamed in the dt-bindings and
>> in the driver.
>>
>> [...]
> Applied to v6.10-next/dts64, thanks!
>
> [3/6] arm64: dts: mediatek: mt8186: add lvts definitions
>        commit: 0c598e50e6c823c1057ddad17c546e368a415d6a
> [4/6] arm64: dts: mediatek: mt8186: add default thermal zones
>        commit: d7c1bde38bf37a59551cfd52cfdb5bd974b17431
> [5/6] arm64: dts: mediatek: mt8188: add lvts definitions
>        commit: 7e3e18f2ed40ea9018590b4533fa148954a725bc
> [6/6] arm64: dts: mediatek: mt8188: add default thermal zones
>        commit: 2f950510411a33d98eea28c22d7880eeb48adb61
>
> Cheers,
> Angelo
>

Hello Angelo,

About this series, the DT patches were initially applied, but removed
due to missing dt-bindings in linux-next[1].

But now the dt-bindings patches are applied in mainline[2].

Would it be possible to re-apply the dts patches please ?

[1] https://lore.kernel.org/all/ZnBn-vSj-ssrJFr2@sirena.org.uk/

[2] https://git.kernel.org/pub/scm/linux/kernel/git/thermal/linux.git/log/?h=thermal/linux-next
4262b8d782a7 ("dt-bindings: thermal: mediatek: Fix thermal zone definition for MT8186")
744ca11f52e5 ("dt-bindings: thermal: mediatek: Fix thermal zone definitions for MT8188")

Julien
AngeloGioacchino Del Regno Aug. 1, 2024, 8:20 a.m. UTC | #3
Il 31/07/24 17:34, Julien Panis ha scritto:
> On 6/13/24 10:07, AngeloGioacchino Del Regno wrote:
>> On Mon, 03 Jun 2024 12:50:47 +0200, Julien Panis wrote:
>>> This is a bunch of patches to support the MT8186 and MT8188 thermal
>>> sensor configurations.
>>>
>>> Since the patches of v3 were applied except those related to the SoC
>>> device trees, this series includes mainly patches for 'mt8186.dtsi'
>>> and 'mt8188.dtsi'. Due to some thermal zone renaming in these 2 device
>>> trees, the related definitions were also renamed in the dt-bindings and
>>> in the driver.
>>>
>>> [...]
>> Applied to v6.10-next/dts64, thanks!
>>
>> [3/6] arm64: dts: mediatek: mt8186: add lvts definitions
>>        commit: 0c598e50e6c823c1057ddad17c546e368a415d6a
>> [4/6] arm64: dts: mediatek: mt8186: add default thermal zones
>>        commit: d7c1bde38bf37a59551cfd52cfdb5bd974b17431
>> [5/6] arm64: dts: mediatek: mt8188: add lvts definitions
>>        commit: 7e3e18f2ed40ea9018590b4533fa148954a725bc
>> [6/6] arm64: dts: mediatek: mt8188: add default thermal zones
>>        commit: 2f950510411a33d98eea28c22d7880eeb48adb61
>>
>> Cheers,
>> Angelo
>>
> 
> Hello Angelo,
> 
> About this series, the DT patches were initially applied, but removed
> due to missing dt-bindings in linux-next[1].
> 
> But now the dt-bindings patches are applied in mainline[2].
> 
> Would it be possible to re-apply the dts patches please ?
> 
> [1] https://lore.kernel.org/all/ZnBn-vSj-ssrJFr2@sirena.org.uk/
> 
> [2] 
> https://git.kernel.org/pub/scm/linux/kernel/git/thermal/linux.git/log/?h=thermal/linux-next
> 4262b8d782a7 ("dt-bindings: thermal: mediatek: Fix thermal zone definition for 
> MT8186")
> 744ca11f52e5 ("dt-bindings: thermal: mediatek: Fix thermal zone definitions for 
> MT8188")
> 

Thanks for the reminder; I have applied those to v6.11-next/dts64.

Cheers,
Angelo