| Message ID | 20240606-hdmi-tx-v3-2-9d7feb6d3647@freebox.fr |
|---|---|
| State | Superseded |
| Headers | show |
| Series | HDMI TX support in msm8998 | expand |
On Thu, Jun 06, 2024 at 06:07:48PM +0200, Marc Gonzalez wrote: > HDMI TX block embedded in the APQ8098. > > Signed-off-by: Marc Gonzalez <mgonzalez@freebox.fr> Reviewed-by: Conor Dooley <conor.dooley@microchip.com> Thanks, Conor.
On Thu, 06 Jun 2024 18:07:48 +0200, Marc Gonzalez wrote: > HDMI TX block embedded in the APQ8098. > > Signed-off-by: Marc Gonzalez <mgonzalez@freebox.fr> > --- > .../devicetree/bindings/display/msm/hdmi.yaml | 28 ++++++++++++++++++++-- > 1 file changed, 26 insertions(+), 2 deletions(-) > Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
On 06-06-24, 18:07, Marc Gonzalez wrote:
> HDMI TX block embedded in the APQ8098.
This one too
On 12/06/2024 19:44, Vinod Koul wrote: > On 06-06-24, 18:07, Marc Gonzalez wrote: > >> HDMI TX block embedded in the APQ8098. > > This one too I assume this refers to: "Why is the patch titled display/msm, this is phy patch and it should be tagged as such." I always copy what others have done before me: $ git log --oneline Documentation/devicetree/bindings/display/msm/hdmi.yaml 27339d689d2f9 dt-bindings: display/msm: hdmi: add qcom,hdmi-tx-8998 6c04d89a6138a dt-bindings: display/msm: hdmi: mark hdmi-mux-supply as deprecated e3c5ce88e8f93 dt-bindings: display/msm: hdmi: mark old GPIO properties as deprecated 2f14bc38d88a4 dt-bindings: display/msm: hdmi: split and convert to yaml Are you saying we should diverge from the previous nomenclature? Regards.
On Thu, Jun 13, 2024 at 04:02:24AM +0200, Marc Gonzalez wrote: > On 12/06/2024 19:44, Vinod Koul wrote: > > > On 06-06-24, 18:07, Marc Gonzalez wrote: > > > >> HDMI TX block embedded in the APQ8098. > > > > This one too > > I assume this refers to: > "Why is the patch titled display/msm, this is phy patch and it should be > tagged as such." > > I always copy what others have done before me: > > $ git log --oneline Documentation/devicetree/bindings/display/msm/hdmi.yaml > 27339d689d2f9 dt-bindings: display/msm: hdmi: add qcom,hdmi-tx-8998 > 6c04d89a6138a dt-bindings: display/msm: hdmi: mark hdmi-mux-supply as deprecated > e3c5ce88e8f93 dt-bindings: display/msm: hdmi: mark old GPIO properties as deprecated > 2f14bc38d88a4 dt-bindings: display/msm: hdmi: split and convert to yaml > > Are you saying we should diverge from the previous nomenclature? This one is fine. For the phy bindings please use phy: prefix.
diff --git a/Documentation/devicetree/bindings/display/msm/hdmi.yaml b/Documentation/devicetree/bindings/display/msm/hdmi.yaml index 47e97669821c3..d4a2033afea8d 100644 --- a/Documentation/devicetree/bindings/display/msm/hdmi.yaml +++ b/Documentation/devicetree/bindings/display/msm/hdmi.yaml @@ -19,14 +19,15 @@ properties: - qcom,hdmi-tx-8974 - qcom,hdmi-tx-8994 - qcom,hdmi-tx-8996 + - qcom,hdmi-tx-8998 clocks: minItems: 1 - maxItems: 5 + maxItems: 8 clock-names: minItems: 1 - maxItems: 5 + maxItems: 8 reg: minItems: 1 @@ -142,6 +143,7 @@ allOf: properties: clocks: minItems: 5 + maxItems: 5 clock-names: items: - const: mdp_core @@ -151,6 +153,28 @@ allOf: - const: extp hdmi-mux-supplies: false + - if: + properties: + compatible: + contains: + enum: + - qcom,hdmi-tx-8998 + then: + properties: + clocks: + minItems: 8 + maxItems: 8 + clock-names: + items: + - const: mdp_core + - const: iface + - const: core + - const: alt_iface + - const: extp + - const: bus + - const: mnoc + - const: iface_mmss + additionalProperties: false examples:
HDMI TX block embedded in the APQ8098. Signed-off-by: Marc Gonzalez <mgonzalez@freebox.fr> --- .../devicetree/bindings/display/msm/hdmi.yaml | 28 ++++++++++++++++++++-- 1 file changed, 26 insertions(+), 2 deletions(-)