| Message ID | 20240614-dpu-mode-config-width-v3-5-29ec4069c99b@linaro.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | drm/msm/dpu: be more friendly to X.org | expand |
On 6/13/2024 3:36 PM, Dmitry Baryshkov wrote: > Move a call to dpu_format_populate_plane_sizes() to the atomic_check > step, so that any issues with the FB layout can be reported as early as > possible. > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > Did anything change between v2 to v3 that R-b was dropped? Here it is again, Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
On Thu, Jun 13, 2024 at 04:19:07PM GMT, Abhinav Kumar wrote: > > > On 6/13/2024 3:36 PM, Dmitry Baryshkov wrote: > > Move a call to dpu_format_populate_plane_sizes() to the atomic_check > > step, so that any issues with the FB layout can be reported as early as > > possible. > > > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > > --- > > drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 12 ++++++------ > > 1 file changed, 6 insertions(+), 6 deletions(-) > > > > Did anything change between v2 to v3 that R-b was dropped? No, it was my failure to run b4 trailers, please excuse me. > > Here it is again, > > Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
On 6/14/2024 3:34 AM, Dmitry Baryshkov wrote: > On Thu, Jun 13, 2024 at 04:19:07PM GMT, Abhinav Kumar wrote: >> >> >> On 6/13/2024 3:36 PM, Dmitry Baryshkov wrote: >>> Move a call to dpu_format_populate_plane_sizes() to the atomic_check >>> step, so that any issues with the FB layout can be reported as early as >>> possible. >>> >>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> >>> --- >>> drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 12 ++++++------ >>> 1 file changed, 6 insertions(+), 6 deletions(-) >>> >> >> Did anything change between v2 to v3 that R-b was dropped? > > No, it was my failure to run b4 trailers, please excuse me. > no problem. Tested-by: Abhinav Kumar <quic_abhinavk@quicinc.com> # sc7280 >> >> Here it is again, >> >> Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com> >
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c index a57853ac70b1..927fde2f1391 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c @@ -674,12 +674,6 @@ static int dpu_plane_prepare_fb(struct drm_plane *plane, } } - ret = dpu_format_populate_plane_sizes(new_state->fb, &pstate->layout); - if (ret) { - DPU_ERROR_PLANE(pdpu, "failed to get format plane sizes, %d\n", ret); - return ret; - } - /* validate framebuffer layout before commit */ ret = dpu_format_populate_addrs(pstate->aspace, new_state->fb, @@ -865,6 +859,12 @@ static int dpu_plane_atomic_check(struct drm_plane *plane, return -E2BIG; } + ret = dpu_format_populate_plane_sizes(new_plane_state->fb, &pstate->layout); + if (ret) { + DPU_ERROR_PLANE(pdpu, "failed to get format plane sizes, %d\n", ret); + return ret; + } + fmt = msm_framebuffer_format(new_plane_state->fb); max_linewidth = pdpu->catalog->caps->max_linewidth;
Move a call to dpu_format_populate_plane_sizes() to the atomic_check step, so that any issues with the FB layout can be reported as early as possible. Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> --- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)